Compiling Compiling error tfs 1.4.2 FMT and STD

[XiolenceOT]

Trying to compile the server but I'm getting these issues, followed a tutorial for the same version but it's just not working, 2 errors, 160 messages and 50 warnings.

 Severity	Code	Description	Project	File	Line	Suppression State
Error	C2338	static_assert failed: 'Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt' (compiling source file ..\src\iomarket.cpp)	theforgottenserver	D:\vcpkg\installed\x64-windows\include\fmt\core.h	1691	
Severity	Code	Description	Project	File	Line	Suppression State
Error	C2338	static_assert failed: 'Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt' (compiling source file ..\src\iomapserialize.cpp)	theforgottenserver	D:\vcpkg\installed\x64-windows\include\fmt\core.h	1691
Severity	Code	Description	Project	File	Line	Suppression State
Message		see declaration of 'std::runtime_error' (compiling source file ..\src\iomarket.cpp)	theforgottenserver	C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\include\stdexcept	101	
Severity	Code	Description	Project	File	Line	Suppression State
Message		see declaration of 'fmt::v10::format_error' (compiling source file ..\src\iomarket.cpp)	theforgottenserver	D:\vcpkg\installed\x64-windows\include\fmt\format.h	1055

 

[lursky]

Check this out:

Compilation Error - FMT::FORMAT() · Issue #4465 · otland/forgottenserver

Before creating an issue, please ensure: [X ] This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support) [ X] Th...

github.com

It's due to change in FMT 10.x

Release 10.0.0 · fmtlib/fmt

Replaced Grisu with a new floating-point formatting algorithm for given precision (#3262, #2750, #3269, #3276). The new algorithm is based on Dragonbox already used for the shortest representation ...

github.com

Removed deprecated implicit conversions for enums and conversions to primitive types for compatibility with std::format and to prevent potential ODR violations. Use format_as instead.

forgottenserver/vcpkg.json at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[XiolenceOT]

thanks xd

 

[XiolenceOT]

Check this out:

Compilation Error - FMT::FORMAT() · Issue #4465 · otland/forgottenserver

Before creating an issue, please ensure: [X ] This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support) [ X] Th...

github.com

It's due to change in FMT 10.x

Release 10.0.0 · fmtlib/fmt

Replaced Grisu with a new floating-point formatting algorithm for given precision (#3262, #2750, #3269, #3276). The new algorithm is based on Dragonbox already used for the shortest representation ...

github.com

forgottenserver/vcpkg.json at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Is the VCPKG.JSON file I'm editing supposed to be in workflows? I'm not seeing it or is it in vcpkg?

 

[Codinablack]

for anyone who runs into this problem, the exact commit that fixes the issue is here

Add extra & pedantic warnings and fix the code (#4491) · otland/forgottenserver@61452aa

* Remove discarded qualifiers in return types * Add more warnings and fix underlying enums

github.com

If you add the method that is added in tools.h anywhere, and then make the changes in the io* files then that is all you need, and problem solved.

 

[Dakos]

use vcpkg manifest and downgrade FMT version, that resolve 95% of problems with compiling raw tfs version

 

[Codinablack]

use vcpkg manifest and downgrade FMT version, that resolve 95% of problems with compiling raw tfs version

This also makes them use double the storage space if they have already used vcpkg to install the dependencies, as it now downloads them all directly to tfs project folder... which is a waste of time and storage, and is a crap fix IMO. (we should be moving forward with our dependencies, not halting them at a version that is outdated)

I highly suggest taking the 1 minute it takes to make those edits, and then recompiling. Then there will be 100% of the errors gone.