TFS 1.X+ Crash when player logout or die [tfs 1.3]

[Seitron]

Hi, I'm having trouble solving this. I don't have much experience and I don't find a similar error on the internet.

It is not always that the player logs out or dies, sometimes it is hours without problems.
I will post the log, if anyone can help me solve it I would be very grateful.

Using Ubuntu 20

Log:

crash tfs 1.3 - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

pastebin.com

 

[Loney]

Try upgrading MariaDB to latest version

 

[Infernum]

what caused the crash is the destructor for some Container inside of DepotLocker it seems, what does that character's depot locker contain?
it's hard to pinpoint the issue with no symbols

 

[Seitron]

Try upgrading MariaDB to latest version

I was using mariaDB 10.3. I found the latest version 10.5. It had no effect .

Post automatically merged: Aug 25, 2020

what caused the crash is the destructor for some Container inside of DepotLocker it seems, what does that character's depot locker contain?
it's hard to pinpoint the issue with no symbols

I'll see if I find any items that players have in common. The strange thing that doesn't always happen, even keeping the same items in the depot.

Post automatically merged: Aug 25, 2020

 

[Seitron]

I recompile using
cmake -DCMAKE_BUILD_TYPE=DEBUG ..

I got this more detailed log, if you can help me

log tfs 1.3 - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

pastebin.com

 

[Sajgon]

I am not sure if this will help you but I had similar issue with depotLocker and crash and for me I had to implement this piece:

Fix crash issue when parentContainer is nullptr for playerMoveUpConta… · nekiro/forgottenserver@120e07a

…iner

github.com

 

[Seitron]

in my game.cpp in the same part there are more details. Should I delete it or is it more updated?

    Container* parentContainer = dynamic_cast<Container*>(container->getRealParent());
    if (!parentContainer) {
        Tile* tile = container->getTile();
        if (!tile) {
            return;
        }

        auto it = browseFields.find(tile);
        if (it == browseFields.end()) {
            parentContainer = new Container(tile);
            parentContainer->incrementReferenceCounter();
            browseFields[tile] = parentContainer;
            g_scheduler.addEvent(createSchedulerTask(30000, std::bind(&Game::decreaseBrowseFieldRef, this, tile->getPosition())));
        } else {
            parentContainer = it->second;
        }
    }

 

[darkmu]

I'm also having the same problem, can someone help us?

 

[Seitron]

I couldn't solve it yet

 

[esigma94]

It would be easier if you'll provide the source code. The lines described in your gdb log does not match the newest TFS.
Have you modified Container's code anyhow? Could you provide TFS version (commit hash) you use or Container class source code?

Easiest solution: If it is possible, try to use the newest TFS and check if the problem still occurs.

 

[Seitron]

im using this source

otg-premium-version/src at master · Johncorex/otg-premium-version

A free and open-source MMORPG server emulator written in C++ Copyright (C) 2020 Mark Samman - Johncorex/otg-premium-version

github.com

 

[esigma94]

At first glance I am not sure what might be causing the problem, but...
It looks strange that Container's destructors are displayed twice in stack trace (I don't understand why it might happen, probably just a compiler artifact - meaningless).

2020-08-26 05:46:27 -  #1  0x000055555564fe9c in Container::~Container (this=<optimized out>, this=<optimized out>) at /home/otserv1/src/container.cpp:69
2020-08-26 05:46:27 -          item = 0x7fff422d3700
2020-08-26 05:46:27 -          __for_range = std::deque with 18 elements = {0x7fff422d3700, 0x7fff7f9d1e00, 0x7fff61871630, 0x7fff61abdd40, 0x7fffc4057a20, 0x7fff61b4f460, 0x7fff9402e5e0, 0x7fff26ae3a50, 0x7fff3e53a040, 0x7fff7fbb7bb0, 0x7fff61b51ab0, 0x7fff616575a0, 0x7fff61ba4d20, 0x7fff360df220, 0x7fffa7173ed0, 0x7fff9f945ae0, 0x7fffcf29da00, 0x7fffcee80d80}
2020-08-26 05:46:27 -          __for_begin = 0x7fff422d3700
2020-08-26 05:46:27 -          __for_end = 0x7fffc0b24400
2020-08-26 05:46:27 -          item = <optimized out>
2020-08-26 05:46:27 -          __for_range = <optimized out>
2020-08-26 05:46:27 -          __for_begin = <optimized out>
2020-08-26 05:46:27 -          __for_end = <optimized out>
2020-08-26 05:46:27 -          item = <optimized out>
2020-08-26 05:46:27 -          __for_range = <optimized out>
2020-08-26 05:46:27 -          __for_begin = <optimized out>
2020-08-26 05:46:27 -          __for_end = <optimized out>
2020-08-26 05:46:27 -  #2  0x000055555564ff0e in Container::~Container (this=<optimized out>, this=<optimized out>) at /home/otserv1/src/container.cpp:73

Also it looks like it is failing at line 69:

item->setParent(nullptr);

And the next step is not refering to setParent:

2020-08-26 05:46:27 -  #0  0x00007fff422d36f0 in ?? ()

It probably means that the item is already nulled.

Try to print its name and address. It will allow you to check what items are being removed. If it was already removed then you should check why it is trying to be removed once again.

 

[Seitron]

I'm also having the same problem, can someone help us?

A fix was posted for this problem. Test to see if you got it.
Try this.

[fix] this cause crash · Johncorex/otg-premium-version@5db545d

A free and open-source MMORPG server emulator written in C++ Copyright (C) 2020 Mark Samman - [fix] this cause crash · Johncorex/otg-premium-version@5db545d

github.com

Thank you all for your help.

 

[esigma94]

@Seitron
Good to hear Mark your post with the GitHub link to the commit as a solution to this topic then.