TFS 1.X+ create tile on no ground tile 1.5

bpm91 · Mar 21, 2023

Hey guys, I'm trying to make the bridge do and undo when pulling levers, but it doesn't create the floor, the lever moves

LUA:

function onUse(cid, item, frompos, item2, topos)

gatepos1 = {x=32426, y=32201, z=14, stackpos=1}
getgate1 = getThingfromPos(gatepos1)
gatepos2 = {x=32426, y=32202, z=14, stackpos=1}
getgate2 = getThingfromPos(gatepos2)

switchpos1 = {x=32428, y=32198, z=14}
switchpos2 = {x=32428, y=32203, z=14}


    
if item.itemid == 1946 then   

doCreateItem(1284,1,gatepos1)
doCreateItem(1284,1,gatepos2)

doTransformItem(getTileItemById(switchpos1, 1946).uid,1945)
doTransformItem(getTileItemById(switchpos2, 1946).uid,1945)         

elseif item.itemid == 1945 then

doRemoveItem(1284,1,gatepos1)
doRemoveItem(1284,1,gatepos2)

doTransformItem(getTileItemById(switchpos1, 1945).uid,1946)
doTransformItem(getTileItemById(switchpos2, 1945).uid,1946)
      
else
doPlayerSendCancel(cid,"Sorry not possible.")
end
  return 1
  end

Sprrw · Mar 21, 2023

bpm91 said:
i change line local tile = t[4]:getTile()
to local tile = t[4]:getTile(Position)
and work Constme Poff
but no create item

Post automatically merged: Mar 21, 2023

Now Work, i chnge to scripts/action <3 ty so much u save me <3

So happy it helped friend! Good luck with your project!

Btw :
on line 6 add :

LUA:

local effect = CONST_ME_POFF

on line 45 add :

LUA:

bridgePos1:sendMagicEffect(effect)
bridgePos2:sendMagicEffect(effect)

If you want that visual effect aswell.

bpm91 · Mar 21, 2023

nice i want effect too <3

Post automatically merged: Mar 21, 2023

I have a small problem, I need to be kicked when I'm in the middle of the bridge and someone closes..

Sprrw · Mar 21, 2023

bpm91 said:
nice i want effect too <3

Post automatically merged: Mar 21, 2023

I have a small problem, I need to be kicked when I'm in the middle of the bridge and someone closes..

Yea, I know. I will fix up the script and get back to you!

Azerty · Mar 21, 2023

Sprrw said:
Yea, I know. I will fix up the script and get back to you!

The player on the bridge is not being teleported

Sprrw · Mar 21, 2023

Azerty said:
The player on the bridge is not being teleported

bpm91 said:
nice i want effect too <3

Post automatically merged: Mar 21, 2023

I have a small problem, I need to be kicked when I'm in the middle of the bridge and someone closes..

LUA:

local switchBridge = Action()

local leverOn = 1946
local leverOff = 1945
local bridgeTile = 405
local effect = CONST_ME_POFF

local bridgePos = {Position({
    x = 1090,
    y = 1003,
    z = 8
}), Position({
    x = 1091,
    y = 1003,
    z = 8
})}

local leverTile = {Position({
    x = 1089,
    y = 1002,
    z = 8
}), Position({
    x = 1092,
    y = 1004,
    z = 8
})}

local teleportToPos = Position({x = 1089, y = 1003, z = 8})

function Position:createItem(itemid, count)
    local toTile = Tile(self)
    if not toTile or not toTile:getItems() or not toTile:getGround() then
        doAreaCombatHealth(0, 0, self, 0, 0, 0, CONST_ME_NONE)
        Game.createItem(itemid, count, self)
    end
end

function switchBridge.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if not player then
        return
    end

    for i, v in ipairs(leverTile) do
        if Tile(v):getItemById(leverOff) then
            Tile(v):getItemById(leverOff):transform(leverOn)
        else
            Tile(v):getItemById(leverOn):transform(leverOff)
        end
    end

    if item.itemid == leverOn then
        for i, v in ipairs(bridgePos) do
            v:sendMagicEffect(effect)
            v:createItem(bridgeTile, 1)
        end
    else
        for i, v in ipairs(bridgePos) do
            local bridgeTilePos = Tile(v):getItemById(bridgeTile)
            print(Tile(v):getItemById(2120))
            local searchCreature = getTopCreature(v).uid
            if Creature(searchCreature) then
                Creature(searchCreature):teleportTo(teleportToPos)
            end
            bridgeTilePos:remove()
        end
    end
end

switchBridge:aid(32191)
switchBridge:register()

Azerty · Mar 21, 2023

Sprrw said:

LUA:

local switchBridge = Action()

local leverOn = 1946
local leverOff = 1945
local bridgeTile = 405
local effect = CONST_ME_POFF

local bridgePos = {Position({
    x = 1090,
    y = 1003,
    z = 8
}), Position({
    x = 1091,
    y = 1003,
    z = 8
})}

local leverTile = {Position({
    x = 1089,
    y = 1002,
    z = 8
}), Position({
    x = 1092,
    y = 1004,
    z = 8
})}

local teleportToPos = Position({x = 1089, y = 1003, z = 8})

function Position:createItem(itemid, count)
    local toTile = Tile(self)
    if not toTile or not toTile:getItems() or not toTile:getGround() then
        doAreaCombatHealth(0, 0, self, 0, 0, 0, CONST_ME_NONE)
        Game.createItem(itemid, count, self)
    end
end

function switchBridge.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if not player then
        return
    end

    for i, v in ipairs(leverTile) do
        if Tile(v):getItemById(leverOff) then
            Tile(v):getItemById(leverOff):transform(leverOn)
        else
            Tile(v):getItemById(leverOn):transform(leverOff)
        end
    end

    if item.itemid == leverOn then
        for i, v in ipairs(bridgePos) do
            v:sendMagicEffect(effect)
            v:createItem(bridgeTile, 1)
        end
    else
        for i, v in ipairs(bridgePos) do
            local bridgeTilePos = Tile(v):getItemById(bridgeTile)
            print(Tile(v):getItemById(2120))
            local searchCreature = getTopCreature(v).uid
            if Creature(searchCreature) then
                Creature(searchCreature):teleportTo(teleportToPos)
            end
            bridgeTilePos:remove()
        end
    end
end

switchBridge:aid(32191)
switchBridge:register()

bad argument #1 to 'ipairs' (table expected, got nil)

Sprrw · Mar 21, 2023

Fixed so that it removes items + fluids aswell

LUA:

local switchBridge = Action()

local leverOn = 1946
local leverOff = 1945
local bridgeTile = 405
local effect = CONST_ME_POFF

local bridgePos = {Position({
    x = 1090,
    y = 1003,
    z = 8
}), Position({
    x = 1091,
    y = 1003,
    z = 8
})}

local leverTile = {Position({
    x = 1089,
    y = 1002,
    z = 8
}), Position({
    x = 1092,
    y = 1004,
    z = 8
})}

local teleportToPos = Position({
    x = 1089,
    y = 1003,
    z = 8
})

function Position:createItem(itemid, count)
    local toTile = Tile(self)
    if not toTile or not toTile:getItems() or not toTile:getGround() then
        doAreaCombatHealth(0, 0, self, 0, 0, 0, CONST_ME_NONE)
        Game.createItem(itemid, count, self)
    end
end

function switchBridge.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if not player then
        return
    end

    for i, v in ipairs(leverTile) do
        if Tile(v):getItemById(leverOff) then
            Tile(v):getItemById(leverOff):transform(leverOn)
        else
            Tile(v):getItemById(leverOn):transform(leverOff)
        end
    end

    if item.itemid == leverOn then
        for i, v in ipairs(bridgePos) do
            v:sendMagicEffect(effect)
            v:createItem(bridgeTile, 1)
        end
    else
        for i, v in ipairs(bridgePos) do
            local bridgeTilePos = Tile(v):getItemById(bridgeTile)
            local items = Tile(v):getItems()
            if items then
                for i = 1, #items do
                    items[i]:remove()
                end
            end
            local searchCreature = getTopCreature(v).uid
            if Creature(searchCreature) then
                Creature(searchCreature):teleportTo(teleportToPos)
            end
            bridgeTilePos:remove()
        end
    end
end

switchBridge:aid(32191)
switchBridge:register()

Azerty said:
bad argument #1 to 'ipairs' (table expected, got nil)

Post full error

bpm91 · Mar 21, 2023

lursky · Mar 21, 2023

@bpm91 Show the whole script so we can see why it has null instead of array in that loop, (most likely bridgePos is wrongly defined - but line number do not match with posted script)

Sprrw · Mar 21, 2023

bpm91 said:
View attachment 74281

Hmm, Im not sure. It's hard to debug when Im not getting the error on my hand. Can you post your script?

Azerty · Mar 21, 2023

LUA:

local switchBridge = Action()

local leverOn = 1946
local leverOff = 1945
local bridgeTile = 1284
local effect = CONST_ME_POFF

local bridgePos1 = Position({
    x = 32426,
    y = 32201,
    z = 14
})
local bridgePos2 = Position({
    x = 32426,
    y = 32202,
    z = 14
})

local bridgePos3 = Position({
    x = 32427,
    y = 32201,
    z = 14
})
local bridgePos4 = Position({
    x = 32427,
    y = 32202,
    z = 14
})


local leverTile1 = Position({
    x = 32428,
    y = 32198,
    z = 14
})

local leverTile2 = Position({
    x = 32428,
    y = 32203,
    z = 14
})


local teleportToPos = Position({
    x = 32426,
    y = 32200,
    z = 14
})

function Position:createItem(itemid, count)
    local toTile = Tile(self)
    if not toTile or not toTile:getItems() or not toTile:getGround() then
        doAreaCombatHealth(0, 0, self, 0, 0, 0, CONST_ME_NONE)
        Game.createItem(itemid, count, self)
    end
end

function switchBridge.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if not player then
        return
    end

    for i, v in ipairs(leverTile) do
        if Tile(v):getItemById(leverOff) then
            Tile(v):getItemById(leverOff):transform(leverOn)
        else
            Tile(v):getItemById(leverOn):transform(leverOff)
        end
    end

    if item.itemid == leverOn then
        for i, v in ipairs(bridgePos) do
            v:sendMagicEffect(effect)
            v:createItem(bridgeTile, 1)
        end
    else
        for i, v in ipairs(bridgePos) do
            local bridgeTilePos = Tile(v):getItemById(bridgeTile)
            local items = Tile(v):getItems()
            if items then
                for i = 1, #items do
                    items[i]:remove()
                end
            end
            local searchCreature = getTopCreature(v).uid
            if Creature(searchCreature) then
                Creature(searchCreature):teleportTo(teleportToPos)
            end
            bridgeTilePos:remove()
        end
    end
end

switchBridge:aid(19120)
switchBridge:register()

Sprrw · Mar 21, 2023

lursky said:
@bpm91 Show the whole script so we can see why it has null instead of array in that loop, (most likely bridgePos is wrongly defined - but line number do not match with posted script)

Yea exactly what I thought, I was like "how does he get an Ipair error on this line

LUA:

local items = Tile(v):getItems()

XD

Post automatically merged: Mar 21, 2023

Azerty said:

LUA:

local switchBridge = Action()

local leverOn = 1946
local leverOff = 1945
local bridgeTile = 1284
local effect = CONST_ME_POFF

local bridgePos1 = Position({
    x = 32426,
    y = 32201,
    z = 14
})
local bridgePos2 = Position({
    x = 32426,
    y = 32202,
    z = 14
})

local bridgePos3 = Position({
    x = 32427,
    y = 32201,
    z = 14
})
local bridgePos4 = Position({
    x = 32427,
    y = 32202,
    z = 14
})


local leverTile1 = Position({
    x = 32428,
    y = 32198,
    z = 14
})

local leverTile2 = Position({
    x = 32428,
    y = 32203,
    z = 14
})


local teleportToPos = Position({
    x = 32426,
    y = 32200,
    z = 14
})

function Position:createItem(itemid, count)
    local toTile = Tile(self)
    if not toTile or not toTile:getItems() or not toTile:getGround() then
        doAreaCombatHealth(0, 0, self, 0, 0, 0, CONST_ME_NONE)
        Game.createItem(itemid, count, self)
    end
end

function switchBridge.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if not player then
        return
    end

    for i, v in ipairs(leverTile) do
        if Tile(v):getItemById(leverOff) then
            Tile(v):getItemById(leverOff):transform(leverOn)
        else
            Tile(v):getItemById(leverOn):transform(leverOff)
        end
    end

    if item.itemid == leverOn then
        for i, v in ipairs(bridgePos) do
            v:sendMagicEffect(effect)
            v:createItem(bridgeTile, 1)
        end
    else
        for i, v in ipairs(bridgePos) do
            local bridgeTilePos = Tile(v):getItemById(bridgeTile)
            local items = Tile(v):getItems()
            if items then
                for i = 1, #items do
                    items[i]:remove()
                end
            end
            local searchCreature = getTopCreature(v).uid
            if Creature(searchCreature) then
                Creature(searchCreature):teleportTo(teleportToPos)
            end
            bridgeTilePos:remove()
        end
    end
end

switchBridge:aid(19120)
switchBridge:register()

Ohh, you need to change the positions. Check how I did it, they are supposed to be grouped under bridgePos instead of bridgePos1 etc

Azerty · Mar 21, 2023

Sprrw said:
Yea exactly what I thougt, I was like "how does he get an Ipair error on this line

LUA:

local items = Tile(v):getItems()

XD

Post automatically merged: Mar 21, 2023

Ohh, you need to change the positions. Check how I did it, they are supposed to be grouped under bridgePos instead of bridgePos1 etc

How do I do?

Sprrw · Mar 21, 2023

Sprrw said:
Yea exactly what I thougt, I was like "how does he get an Ipair error on this line

LUA:

local items = Tile(v):getItems()

XD

Post automatically merged: Mar 21, 2023

Ohh, you need to change the positions. Check how I did it, they are supposed to be grouped under bridgePos instead of bridgePos1 etc

Should look like :

LUA:

local bridgePos = { Position({
    x = 32426,
    y = 32201,
    z = 14
}),
Position({
    x = 32426,
    y = 32202,
    z = 14
}),
Position({
    x = 32427,
    y = 32201,
    z = 14
}),
Position({
    x = 32427,
    y = 32202,
    z = 14
})}


local leverTile = { Position({
    x = 32428,
    y = 32198,
    z = 14
}),
Position({
    x = 32428,
    y = 32203,
    z = 14
})
}

Post automatically merged: Mar 21, 2023

Sprrw said:

Should look like :

LUA:

local bridgePos = { Position({
    x = 32426,
    y = 32201,
    z = 14
}),
Position({
    x = 32426,
    y = 32202,
    z = 14
}),
Position({
    x = 32427,
    y = 32201,
    z = 14
}),
Position({
    x = 32427,
    y = 32202,
    z = 14
})}


local leverTile = { Position({
    x = 32428,
    y = 32198,
    z = 14
}),
Position({
    x = 32428,
    y = 32203,
    z = 14
})
}

This is because I made it loop instead of having to to everything per tile.

Azerty · Mar 21, 2023

Sprrw said:
Should look like :

LUA:

local bridgePos = { Position({ x = 32426, y = 32201, z = 14 }), Position({ x = 32426, y = 32202, z = 14 }), Position({ x = 32427, y = 32201, z = 14 }), Position({ x = 32427, y = 32202, z = 14 })} local leverTile = { Position({ x = 32428, y = 32198, z = 14 }), Position({ x = 32428, y = 32203, z = 14 }) }

Post automatically merged: Mar 21, 2023

This is because I made it loop instead of having to to everything per tile.

Perfect bro THX!

Sprrw · Mar 21, 2023

Azerty said:
Perfect bro THX!

No worries, feel free to get back to me if you find any more errors!

bpm91 · Mar 21, 2023

for me it works correctly but an error appears

Post automatically merged: Mar 21, 2023

i fix with
Creature(searchCreature):teleportTo(teleportToPos, true)

Sprrw · Mar 21, 2023

bpm91 said:
for me it works correctly but an error appears
View attachment 74282

Post automatically merged: Mar 21, 2023

i fix with
Creature(searchCreature):teleportTo(teleportToPos, true)

Oh, yea. Thats the correct way to do it. Mb! Well done friend!

TFS 1.X+ create tile on no ground tile 1.5

bpm91

Advanced OT User

Sprrw

Well-Known Member

bpm91

Advanced OT User

Sprrw

Well-Known Member

Azerty

Active Member

Sprrw

Well-Known Member

Azerty

Active Member

Sprrw

Well-Known Member

bpm91

Advanced OT User

lursky

Advanced OT User

Sprrw

Well-Known Member

Azerty

Active Member

Sprrw

Well-Known Member

Azerty

Active Member

Sprrw

Well-Known Member

Azerty

Active Member

Sprrw

Well-Known Member

bpm91

Advanced OT User

Sprrw

Well-Known Member