Solved creature:getMana and doTargetCombatMana()

[lukatxd]

I'm using the TFS 1.3 downgraded by Nekiro to work on Tibia 8.6. This is what happens when I try to use potions:

Lua Script Error: [Action Interface]
data/actions/scripts/other/potions.lua:onUse
data/actions/scripts/other/potions.lua:56: attempt to call global 'doTargetCombatHealth' (a nil value)
stack traceback:
        [C]: in function 'doTargetCombatHealth'
        data/actions/scripts/other/potions.lua:56: in function <data/actions/scripts/other/potions.lua:35>

Lua Script Error: [Action Interface]
data/actions/scripts/other/potions.lua:onUse
data/actions/scripts/other/potions.lua:56: attempt to call global 'doTargetCombatHealth' (a nil value)
stack traceback:
        [C]: in function 'doTargetCombatHealth'
        data/actions/scripts/other/potions.lua:56: in function <data/actions/scripts/other/potions.lua:35>

I can see the doTargetCombatMana in this file in the sources (original TFS, not the one I'm actually using)

forgottenserver/data/lib/compat/compat.lua at 4f5f0fb0837ae3ad814ae00a2ac751164cb4adc1 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

In the downgraded version I can't find any of these functions

Build software better, together

GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 420 million projects.

github.com

Plus, I'm also testing an item stat upgrade system, that invokes creature:getMana() which also happens to end in a 'nil value' and if any item has a mana drain attribute, the player owning the item can't even attack. What can I do to resolve this?

 

[Xikini]

combat

https://github.com/nekiro/forgottenserver/blob/master/src/luascript.cpp#L3291

 

[Evil Puncker]

first issue: add these changes to your compat.lua

Combat and boosts changes (#2497) · otland/forgottenserver@831adb2

completely rewritten combat.cpp, instead of bunch of functions, we are now using only two "internal" ones. one main function doCombat() with target and position parameter, which leads to...

github.com

second issue: I need a print of the error and the code part that invokes creature:getMana()

 

[lukatxd]

@Xikini
These are on the master branch.. I'm using the downagraded version that is in another repository. So I'm not sure if it would work well if I just compared the differences since I'm not versed in the tfs sources.


@Evil Puncker:

first issue: the difference from compat.lua only?

second issue:
I tried switching the creature:getMana() to creature:getHealth(), but then I eventually got into the doTargetCombatMana issue.

CreatureEvent - [TFS 1.1] Ultimate item stat system (elements, skills, exp, loot and more)

Abandoned by OP, code is most likely bugged Hello OtLand. I put together four different scripts in one lib which took a lot of work to make them compatible, they work as one system now. TFS I used: 1.1 from 29 Mar 2015 No, it won't work on 1.0 No, no version for 0.2/0.3/0.4, move on already...

otland.net

stats.lua
creture:getMana()




I eventually found this list of available functions where it does contain creature:getMana(), but i'm not entirely sure for what version it is, I found it laying around in the forum.

Game Game.createContainer(itemId, size[, position]) Game.createItem(it - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

pastebin.com

 

[Evil Puncker]

@Evil Puncker:

first issue: the difference from compat.lua only?

yes add these to your compat.lua

function doTargetCombatHealth(...) return doTargetCombat(...) end
function doAreaCombatHealth(...) return doAreaCombat(...) end
function doTargetCombatMana(cid, target, min, max, effect) return doTargetCombat(cid, target, COMBAT_MANADRAIN, min, max, effect) end
function doAreaCombatMana(cid, pos, area, min, max, effect) return doAreaCombat(cid, COMBAT_MANADRAIN, pos, area, min, max, effect) end

 

[lukatxd]

yes add these to your compat.lua

function doTargetCombatHealth(...) return doTargetCombat(...) end
function doAreaCombatHealth(...) return doAreaCombat(...) end
function doTargetCombatMana(cid, target, min, max, effect) return doTargetCombat(cid, target, COMBAT_MANADRAIN, min, max, effect) end
function doAreaCombatMana(cid, pos, area, min, max, effect) return doAreaCombat(cid, COMBAT_MANADRAIN, pos, area, min, max, effect) end

So far so good, it resolved the situation about potions. Now for the creature:getMana()

 

[Evil Puncker]

So far so good, it resolved the situation about potions. Now for the creature:getMana()

try changing the if to this:

if Player(cid):getMana() > 0 then

 

[lukatxd]

try changing the if to this:

if Player(cid):getMana() > 0 then

Nope, didnt work:

Lua Script Error: [CreatureScript Interface]
data/creaturescripts/scripts/stats.lua:onHealthChange
data/stats.lua:1576: attempt to index a nil value
stack traceback:
        [C]: in function '__index'
        data/stats.lua:1576: in function <data/stats.lua:1509>

But since it is used only in this single line of code. I'll remove it for simplicity's sake. I don't need to do the actual drain of mana, just restore some based on the damage (which is like global does).
I thank you once more for the time spent helping me.

 

[Xazzil]

to fix it