TalkAction Creature Kill Count System

[gigastar]

-Updated-

Usage: !kills monstername

Talkaction:

function onSay(cid, words, param)
if (param == "") then
return false
end
 
t = string.explode(param, ",")
t[1] = monster
 
 
if (isCreature(monster)) then
if getPlayerStorageValue(monster) > 0 then
local amount = getPlayerStorageValue(param)
local text = "You have killed " .. amount .. " " .. param .."!"
 
doShowTextDialog(cid, 2175, text)
else
	doPlayerSendCancel(cid, "You have not killed any of these monsters.")
	return false
end
 
 
end
else
	doPlayerSendCancel(cid, "You need to type a monster name.")
return false
end
end

Creaturescript:

function onKill(cid, target)
if (isCreature(target)) then
			setPlayerStorageValue(cid, getCreatureByName(target) + 1)
		end
	return true
	end

For anyone that doesn't get it....

1) gets storage of creature name + 1
so the storage IS the creatures NAME....
2) Everytime he killes a monster, it sets the storage +1 of that monsters name.
3) They use the talkaction to check there storage for each monster name.
4) YES THIS MAKES THE TALKACTION CAP LOCKED

!kills Orc Worrior

 

[Wangsta]

Storage can be corrupted the way this is written, you'll want to do the math before setting the storage.

 

[hodleo]

creature uid as storage key?

 

[gigastar]

edited, small change in creature script.

 

[Wangsta]

That won't work at all, it needs to look something like this:

function onKill(cid, target)
	if (isCreature(target)) then
		local counter = getPlayerStorageValue(cid, getCreatureByName(target)) +1
		setPlayerStorageValue(cid, getCreatureByName(target), count)
	end
return true
end

 

[JuggaloUser]

Any final update?

 

[gigastar]

Talkaction:

function onSay(cid, words, param)
if (param == "") then
return false
end

t = string.explode(param, ",")
t[1] = monster


if (isCreature(monster)) then
if getPlayerStorageValue(monster) > 0 then
local amount = getPlayerStorageValue(param)
local text = "You have killed " .. amount .. " " .. param .."!"
 
doShowTextDialog(cid, 2175, text)
else
	doPlayerSendCancel(cid, "You have not killed any of these monsters.")
	return false
end
 
 
end
else
	doPlayerSendCancel(cid, "You need to type a monster name.")
return false
end
end

Creaturescript:

function onKill(cid, target)
if (isCreature(target)) then
			setPlayerStorageValue(cid, getCreatureByName(target) + 1)
		end
	return true
	end

- - - Updated - - -

Storage can be corrupted the way this is written, you'll want to do the math before setting the storage.

You will want to do the math before posting...

- - - Updated - - -

That won't work at all, it needs to look something like this:

function onKill(cid, target)
	if (isCreature(target)) then
		local counter = getPlayerStorageValue(cid, getCreatureByName(target)) +1
		setPlayerStorageValue(cid, getCreatureByName(target), count)
	end
return true
end

Do you know what scripting is?