Lua Creature Position - Bug?

[HeberPcL]

Hey,

I did the following script and found a strange error and for this reason I am sharing it may be a bug.

Code:

    toPosition = player:getPosition()
    local skeleton = doSummonCreature("Skeleton", toPosition)
    local skeletonCheckPositionNow = skelelton:getPosition() -- return error
    local skeletonCheckPositionNoww = getCreaturePosition(skeleton) -- work fine

 

[EvulMastah]

https://github.com/otland/forgotten...82d10769f205c/data/lib/compat/compat.lua#L536
doSummonCreature returns id and not metatable. You should probably use Game.createMonster(monsterName, position[, extended = false[, force = false]]).

 

[Moj mistrz]

Hey,

I did the following script and found a strange error and for this reason I am sharing it may be a bug.

Code:

    toPosition = player:getPosition()
    local skeleton = doSummonCreature("Skeleton", toPosition)
    local skeletonCheckPositionNow = skelelton:getPosition() -- return error
    local skeletonCheckPositionNoww = getCreaturePosition(skeleton) -- work fine

local skeletonCheckPositionNow = skelelton:getPosition() -- return error
Maybe that's the error?

 

[Printer]

As Evual stated. doSummonCreature return a id, so you need todo:

    local creatureId = doSummonCreature("Skeleton", toPosition)
    if creatureId ~= false then
        local monster = Monster(creatureId)
        monster:getPosition():sendMagicEffect(CONST_ME_TELEPORT)
    else
        toPosition:sendMagicEffect(CONST_ME_POFF)
    end

or, do this which i recommend:

    local monster = Game.createMonster("Skeleton", toPosition)
    if monster ~= nil then
        monster:getPosition():sendMagicEffect(CONST_ME_TELEPORT)
    else
        toPosition:sendMagicEffect(CONST_ME_POFF)
    end

 

[HeberPcL]

@EvulMastah, @Moj mistrz and @Printer

Thanks for the tips.

* * *
I'm trying to do two monsters attack, but in TFS 1.x'm not getting.
Have any of you done something?
* * *

 

[HeberPcL]

function onSay(player, words, param)
    local toPosition = player:getPosition()
    local creatureID_1 = Game.createMonster("Orc",         toPosition)
    local creatureID_2 = Game.createMonster("Skeleton", toPosition)
  
    if ( creatureID_1 ~= nil and creatureID_2 ~= nil )then
        creatureID_1:getPosition():sendMagicEffect(CONST_ME_TELEPORT)
        creatureID_2:getPosition():sendMagicEffect(CONST_ME_TELEPORT)
        -- Set Target
        creatureID_1:addTarget(creatureID_2)
        creatureID_2:addTarget(creatureID_1)
      
    else
        toPosition:sendMagicEffect(CONST_ME_POFF)
    end
 
    return true
end

Using this code the monsters are to target each other, but it does not cause damage.

 

[Shadow Dan]

Hey,

I did the following script and found a strange error and for this reason I am sharing it may be a bug.

Code:

    toPosition = player:getPosition()
    local skeleton = doSummonCreature("Skeleton", toPosition)
    local skeletonCheckPositionNow = skelelton:getPosition() -- return error
    local skeletonCheckPositionNoww = getCreaturePosition(skeleton) -- work fine

toPosition = player:getPosition()
local skeleton = doSummonCreature("Skeleton", toPosition)
local skeletonCheckPositionNow = skelelton:getPosition() -- return error
local skeletonCheckPositionNoww = getCreaturePosition(skeleton) -- work fine

Please try to compare green text with red text. It's why you saw error.

#edit
Sorry i'm tired, didn't saw moj mistrz post. Delete please.

 

[Printer]

This is why monster cannot deal damage to eachother
https://github.com/otland/forgottenserver/blob/master/src/combat.cpp#L351

 

[HeberPcL]

This is why monster cannot deal damage to eachother
https://github.com/otland/forgottenserver/blob/master/src/combat.cpp#L351

If you remove you are part solves?

else if (attacker->getMonster()) {
                const Creature* targetMaster = target->getMaster();

                if (!targetMaster || !targetMaster->getPlayer()) {
                    const Creature* attackerMaster = attacker->getMaster();

                    if (!attackerMaster || !attackerMaster->getPlayer()) {
                        return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE;
                    }
                }
            }

Thx