CreatureEvent [CreatureEvent/Npc] Killing in the name of...

Discussion in 'GlobalEvents, Spells & CreatureEvents' started by Darkhaos, Mar 16, 2011.

  1. Knight God

    Knight God Active Member

    Joined:
    Oct 19, 2008
    Messages:
    1,182
  2. rafaelclaumann

    rafaelclaumann New Member

    Joined:
    Jul 7, 2011
    Messages:
    13
    player can chose the task?
     
  3. GOD Suimy

    GOD Suimy Member

    Joined:
    Sep 11, 2012
    Messages:
    94
    Darkhaos I have a problem with this script, I killed 2 trolls and the Npc say this:

    15:41 Grizzly Adams: Current 0 Trolls killed, you need to kill 100.

    SO it doesn't work :S?
     
  4. djtuca

    djtuca Technical Support

    Joined:
    Jun 25, 2011
    Messages:
    198
    Nice Script
     
    Last edited: May 29, 2013
  5. mct

    mct New Member

    Joined:
    May 7, 2013
    Messages:
    54
    Not count the killed monsters :/
     
  6. Danger II

    Danger II FluppiX.com

    Joined:
    Nov 21, 2012
    Messages:
    1,349
    You doin something wrong, this script works 100% :)
     
  7. Wavoz

    Wavoz Oldschooler

    Joined:
    Jul 10, 2011
    Messages:
    972
    Not working for me :(
    There are like no working task scripts out there... This one is so far the best but IT DOESN'T COUNT THE KILLS... I also tried addings tags to monsters, still nothing....


    13:16 Grizzly Adams: Current 0 Trolls killed, you need to kill 100.
     
  8. djtuca

    djtuca Technical Support

    Joined:
    Jun 25, 2011
    Messages:
    198
    how to make cancel current task?
     
  9. mct

    mct New Member

    Joined:
    May 7, 2013
    Messages:
    54
    I have no more ideas.

    I pasted the code 100%, Im using tfs 0.3.6pl7.... and not count the monsters kill :(
     
  10. 70011983

    70011983 :)

    Joined:
    Nov 21, 2011
    Messages:
    277
    For that:
    local THESNAPPER_POSITION = {x = 100, y = 100, z = 7}

    Do I put the position of the teleport that leads to the boss or where the boss spawns?
     
  11. Ray Rewind

    Ray Rewind Doctor

    Joined:
    Jun 6, 2009
    Messages:
    1,352
    How the system work to kill the boss??? will the NPC spawn a portal to get to the boss or what?
     
  12. Diemorko

    Diemorko Member

    Joined:
    Jan 31, 2011
    Messages:
    64
    How to make it work on TFS 1.0? there is not 000-constant.lua
    I want it with quest log, ANy one can help me? :)
     
  13. LuisPro

    LuisPro War <3

    Joined:
    May 10, 2009
    Messages:
    353
    +1
     
  14. Lifer420

    Lifer420 Well-Known Member

    Joined:
    Jul 27, 2009
    Messages:
    1,492
    Using on tfs 0.4, script isnt working. Getting this error.

    grizzly.png
     
    Ryxy likes this.
  15. psychosisneamia

    psychosisneamia ~Beginner~

    Joined:
    Jun 7, 2012
    Messages:
    162
    @Darkhaos I get this error

    [21/04/2014 13:26:36] [Error - Npc interface]
    [21/04/2014 13:26:36] data/npc/scripts/killinginthenameof.lua:eek:nCreatureSay
    [21/04/2014 13:26:36] Description:
    [21/04/2014 13:26:36] data/npc/scripts/killinginthenameof.lua:124: attempt to concatenate field 'raceName' (a nil value)
    [21/04/2014 13:26:36] stack traceback:
    [21/04/2014 13:26:36] data/npc/scripts/killinginthenameof.lua:124: in function 'callback'
    [21/04/2014 13:26:36] data/npc/lib/npcsystem/npchandler.lua:383: in function 'onCreatureSay'
    [21/04/2014 13:26:36] data/npc/scripts/killinginthenameof.lua:92: in function <data/npc/scripts/killinginthenameof.lua:92>
     
  16. blaahsnos

    blaahsnos New Member

    Joined:
    May 2, 2013
    Messages:
    9
    Npc not count monsters killed =/
     
  17. Ryxy

    Ryxy SYN - Morta8.6

    Joined:
    Jul 23, 2013
    Messages:
    96
    I have the same "error" than @Lifer420

    I'm using "TFS 0.4"

    [9:31:28.254] [Error - LuaInterface::loadFile] data/npc/scripts/killinginthename
    of.lua:90: function arguments expected near ':'
    [9:31:28.255] [Warning - NpcEvents::NpcEvents] Cannot load script: data/npc/scri
    pts/killinginthenameof.lua
    [9:31:28.257] data/npc/scripts/killinginthenameof.lua:90: function arguments exp
    ected near ':'
     
  18. Fiodor

    Fiodor Lua & Maps

    Joined:
    Mar 14, 2009
    Messages:
    392
    Everything works, but NPC does not give any reward (he says "congratulations etc." but no reward)
    how to fix it? :/
    0.4 tfs

    Code:
    local THESNAPPER_POSITION = {x = 100, y = 100, z = 7}
    local HIDE_POSITION = {x = 100, y = 100, z = 7}
    local THEBLOODTUSK_POSITION = {x = 100, y = 100, z = 7}
    local SHARDHEAD_POSITION = {x = 100, y = 100, z = 7}
    local THUL_POSITION = {x = 100, y = 100, z = 7}
    local ESMERALDA_POSITION = {x = 100, y = 100, z = 7}
    local THEOLDWIDOW_POSITION = {x = 100, y = 100, z = 7}
    local THEMANY_POSITION = {x = 100, y = 100, z = 7}
    local LEVIATHAN_POSITION = {x = 100, y = 100, z = 7}
    local STONECRACKER_POSITION = {x = 100, y = 100, z = 7}
    local THENOXIUSSPAWN_POSITION = {x = 100, y = 100, z = 7}
    local MERIKHTHESLAUGHTERER_POSITION = {x = 100, y = 100, z = 7}
    local FAHIMTHEWISE_POSITION = {x = 100, y = 100, z = 7}
    local RANDOMPIRATEBOSS_POSITION = {x = 100, y = 100, z = 7}
    local THEHORNEDFOX_POSITION = {x = 100, y = 100, z = 7}
    local NECROPHARUS_POSITION = {x = 100, y = 100, z = 7}
    
    
    local tasks =
    {
    [1] = {questStarted = 1510, questStorage = 65000, killsRequired = 100, raceName = "Trolls", rewards = {{enable = true, type = "exp", values = 200}, {enable = true, type = "money", values = 200}}},
    
    [2] = {questStarted = 1511, questStorage = 65001, killsRequired = 150, raceName = "Goblins", rewards = {{enable = true, type = "exp", values = 300}, {enable = true, type = "money", values = 250}}},
    
    [3] = {questStarted = 1512, questStorage = 65002, killsRequired = 300, raceName = "Rotworms", rewards = {{enable = true, type = "exp", values = 1000}, {enable = true, type = "money", values = 400}}},
    
    [4] = {questStarted = 1513, questStorage = 65003, killsRequired = 500, raceName = "Cyclops", rewards = {{enable = true, type = "exp", values = 3000}, {enable = true, type = "money", values = 800}}},
    
    [5] = {questStarted = 1514, questStorage = 65004, killsRequired = 300, raceName = "Crocodiles", rewards = {{enable = true, type = "exp", values = 800}, {enable = true, type = "boss", values = THESNAPPER_POSITION}, {enable = true, type = "points", values = 7}}},
    
    [6] = {questStarted = 1515, questStorage = 65005, killsRequired = 300, raceName = "Tarantulas", rewards = {{enable = true, type = "money", values = 1500}, {enable = true, type = "boss", values = HIDE_POSITION}, {enable = true, type = "points", values = 2}}},
    
    [7] = {questStarted = 1516, questStorage = 65006, killsRequired = 150, raceName = "Carniphilas", rewards = {{enable = true, type = "item", values = 2160,1}, {enable = false, type = "points", values = 1}}},
    
    [8] = {questStarted = 1517, questStorage = 65007, killsRequired = 200, raceName = "Stone Golems", rewards = {{enable = true, type = "exp", values = 2000}, {enable = true, type = "points", values = 1}}},
    
    [9] = {questStarted = 1518, questStorage = 65008, killsRequired = 300, raceName = "Mammoths", rewards = {{enable = true, type = "exp", values = 4000}, {enable = true, type = "item", values = 2160,1}}},
    
    [10] = {questStarted = 1519, questStorage = 65009, killsRequired = 300, raceName = "Ice Golems", rewards = {{enable = true, type = "exp", values = 15000}, {enable = true, type = "boss", values = SHARDHEAD_POSITION}, {enable = true, type = "points", values = 2}}},
    
    [11] = {questStarted = 1520, questStorage = 65010, killsRequired = 300, raceName = "Quaras Scout", rewards = {{enable = true, type = "exp", values = 10000}, {enable = true, type = "points", values = 1}}},
    
    [12] = {questStarted = 1521, questStorage = 65011, killsRequired = 300, raceName = "Quaras", rewards = {{enable = true, type = "exp", values = 12000}, {enable = true, type = "boss", values = THUL_POSITION}, {enable = true, type = "points", values = 2}}},
    
    [13] = {questStarted = 1522, questStorage = 65012, killsRequired = 70, raceName = "Water Elementals", rewards = {{enable = true, type = "exp", values = 7000}, {enable = true, type = "points", values = 1}}},
    
    [14] = {questStarted = 1523, questStorage = 65013, killsRequired = 70, raceName = "Earth Elementals", rewards = {{enable = true, type = "exp", values = 10000}, {enable = true, type = "points", values = 1}}},
    
    [15] = {questStarted = 1524, questStorage = 65014, killsRequired = 70, raceName = "Energy Elementals", rewards = {{enable = true, type = "exp", values = 10000}, {enable = true, type = "points", values = 1}}},
    
    [16] = {questStarted = 1525, questStorage = 65015, killsRequired = 70, raceName = "Fire Elementals", rewards = {{enable = true, type = "exp", values = 7000}, {enable = true, type = "points", values = 1}}},
    
    [17] = {questStarted = 1526, questStorage = 65016, killsRequired = 200, raceName = "Mutated Rats", rewards = {{enable = true, type = "exp", values = 10000}, {enable = true, type = "boss", values = ESMERALDA_POSITION}, {enable = true, type = "points", values = 2}}},
    
    [18] = {questStarted = 1527, questStorage = 65017, killsRequired = 500, raceName = "Giant Spiders", rewards = {{enable = true, type = "exp", values = 5000}, {enable = true, type = "boss", values = THEOLDWIDOW_POSITION}, {enable = true, type = "points", values = 2}}},
    
    [19] = {questStarted = 1528, questStorage = 65018, killsRequired = 2000, raceName = "Hydras", rewards = {{enable = true, type = "boss", values = THEMANY_POSITION}, {enable = true, type = "points", values = 4}}},
    
    [20] = {questStarted = 1529, questStorage = 65019, killsRequired = 2000, raceName = "Sea Serpents", rewards = {{enable = true, type = "boss", values = LEVIATHAN_POSITION}, {enable = true, type = "points", values = 4}}},
    
    [21] = {questStarted = 1530, questStorage = 65020, killsRequired = 2000, raceName = "Behemoths", rewards = {{enable = true, type = "boss", values = STONECRACKER_POSITION}, {enable = true, type = "points", values = 4}}},
    
    [22] = {questStarted = 1531, questStorage = 65021, killsRequired = 1500, raceName = "Serpents Spawn", rewards = {{enable = true, type = "teleport", values = THENOXIUSSPAWN_POSITION}, {enable = true, type = "points", values = 4}}},
    
    [23] = {questStarted = 1532, questStorage = 65022, killsRequired = 500, raceName = "Green Djinns", rewards = {{enable = true, type = "exp", values = 10000}, {enable = true, type = "money", values = 5000}, {enable = true, type = "boss", values = MERIKHTHESLAUGHTERER_POSITION}}},
    
    [24] = {questStarted = 1533, questStorage = 65023, killsRequired = 500, raceName = "Blue Djinns", rewards = {{enable = true, type = "exp", values = 10000}, {enable = true, type = "money", values = 5000}, {enable = true, type = "boss", values = FAHIMTHEWISE_POSITION}}},
    
    [25] = {questStarted = 1534, questStorage = 65024, killsRequired = 3000, raceName = "Pirates1", rewards = {{enable = true, type = "exp", values = 10000}, {enable = true, type = "money", values = 5000}, {enable = true, type = "boss", values = RANDOMPIRATEBOSS_POSITION}}},
    
    [26] = {questStarted = 1535, questStorage = 65025, killsRequired = 3000, raceName = "Pirates2", rewards = {{enable = true, type = "exp", values = 10000}, {enable = true, type = "money", values = 5000}}},
    
    [27] = {questStarted = 1536, questStorage = 65026, killsRequired = 5000, raceName = "Minotaurs", rewards = {{enable = true, type = "boss", values = THEHORNEDFOX_POSITION}}},
    
    [28] = {questStarted = 1537, questStorage = 65027, killsRequired = 4000, raceName = "Magicians1", rewards = {{enable = true, type = "boss", values = NECROPHARUS_POSITION}}},
    
    [29] = {questStarted = 1538, questStorage = 65028, killsRequired = 1000, raceName = "Magicians2", rewards = {{enable = true, type = "exp", values = 40000}}},
    
    [30] = {questStarted = 1539, questStorage = 65029, killsRequired = 6666, raceName = "Demons", rewards = {{enable = true, type = "storage", values = {65535, 1}}}}
    }
    
    local rankStorage = 32150
    local choose = {}
    
    local keywordHandler = KeywordHandler:new()
    local npcHandler = NpcHandler:new(keywordHandler)
    NpcSystem.parseParameters(npcHandler)
    local talkState = {}
    
    function onCreatureAppear(cid) npcHandler:onCreatureAppear(cid) end
    function onCreatureDisappear(cid) npcHandler:onCreatureDisappear(cid) end
    function onCreatureSay(cid, type, msg) npcHandler:onCreatureSay(cid, type, msg) end
    function onThink() npcHandler:onThink() end
    
    function getTasksStarted(cid)
    local tmp = {}
    for k, v in pairs(tasks) do
    if getCreatureStorage(cid, v.questStarted) == 1 then
    table.insert(tmp, k)
    end
    end
    return tmp
    end
    
    function getTaskByName(name)
    for k, v in pairs(tasks) do
    if v.raceName:lower() == name:lower() then
    return k
    end
    end
    return false
    end
    
    function creatureSayCallback(cid, type, msg)
    
    if(not npcHandler:isFocused(cid)) then
    return false
    end
    local talkUser = NPCHANDLER_CONVBEHAVIOR == CONVERSATION_PRIVATE and 0 or cid
    if isInArray({"task", "tasks"}, msg:lower()) then
    selfSay("There you can see the following tasks, please tell me the number of the task that you want to do.", cid)
    local text = ""
    for i = 1, table.maxn(tasks) do
    text = text .. (text == "" and "" or "\n") .. i .. " - " .. tasks.raceName .. (getCreatureStorage(cid, tasks.questStarted) == 1 and " [...]" or getCreatureStorage(cid, tasks.questStarted) == 2 and " [x]" or "")
    end
    return doShowTextDialog(cid, 5956, text)
    
    elseif getTaskByName(msg) or tasks[tonumber(msg)] then
    msg = (getTaskByName(msg) or tonumber(msg))
    if getCreatureStorage(cid, tasks[msg].questStarted) == 1 then
    selfSay("You already started this task.", cid)
    talkState[talkUser] = 0
    return true
    end
    if getCreatureStorage(cid, tasks[msg].questStarted) == 2 then
    selfSay("You already finished this task.", cid)
    talkState[talkUser] = 0
    return true
    end
    if tasks[msg].level and getPlayerLevel(cid) < tasks[msg].level then
    selfSay("You need level " .. tasks[msg].level .. " or higher to make this task.", cid)
    talkState[talkUser] = 0
    return true
    end
    selfSay("Are you sure that do you want to start the task number " .. msg .. "? In this task you will need to defeat " .. tasks[msg].killsRequired .. " " .. tasks[msg].raceName .. ".", cid)
    choose[cid] = msg
    talkState[talkUser] = 1
    elseif msgcontains(msg, "yes") and talkState[talkUser] == 1 then
    doCreatureSetStorage(cid, tasks[choose[cid]].questStarted, 1)
    selfSay("You have started the task number " .. choose[cid] .. ", remember... in this task you will need to defeat " .. tasks[choose[cid]].killsRequired .. " " .. tasks[choose[cid]].raceName .. ". Good luck!", cid)
    talkState[talkUser] = 0
    return true
    
    elseif msg:lower() == "report" then
    local t = getTasksStarted(cid)
    local response = "You are currently making " .. (#t > 1 and "these" or "this") .. " task" .. (#t > 1 and "s" or "") .. ":\n"
    if table.maxn(t) > 0 then
    for _, tsk in ipairs(t) do
    if getCreatureStorage(cid, tasks[tsk].questStorage) < 0 then doCreatureSetStorage(cid, tasks[tsk].questStorage, 0) end
    response = response .. " Name: " .. tasks[tsk].raceName .. " Kills: " .. getCreatureStorage(cid, tasks[tsk].questStorage) .. " - " .. tasks[tsk].killsRequired .. ".\n"
    end
    response = response .. "Please say report and the name of the task that do you want to report, example: 'Report Trolls'."
    return selfSay(response, cid)
    else
    return selfSay("You need to start at least one task first.", cid)
    end
    elseif string.sub(msg:lower(), 0, 6) == "report" then
    local t = getTaskByName(string.sub(msg, 8, string.len(msg)))
    if not t then
    return selfSay("That task does not exists.", cid)
    end
    
    if getCreatureStorage(cid, tasks[t].questStarted) == 2 then
    return selfSay("You already finished this task.", cid)
    end
    
    if getCreatureStorage(cid, tasks[t].questStarted) < 1 then
    return selfSay("You don't have started this task.", cid)
    end
    
    if tasks[t].killsRequired > getCreatureStorage(cid, tasks[t].questStorage) then
    return selfSay("Current " .. getCreatureStorage(cid, tasks[t].questStorage) .. " " .. tasks[t].raceName .. " killed, you need to kill " .. tasks[t].killsRequired .. ".", cid)
    end
    
    for i = 1, table.maxn(tasks[t].rewards) do
    if(tasks[t].rewards.enable) then
    if isInArray({"boss", "teleport", 1}, tasks[t].rewards.type) then
    doTeleportThing(cid, tasks[t].rewards.values)
    elseif isInArray({"exp", "experience", 2}, tasks[t].rewards.type) then
    doPlayerAddExperience(cid, tasks[t].rewards.values)
    elseif isInArray({"item", 3}, tasks[t].rewards.type) then
    doPlayerAddItem(cid, v.rewards.values[1], tasks[t].rewards.values[2])
    elseif isInArray({"money", 4}, tasks[t].rewards.type) then
    doPlayerAddMoney(cid, tasks[t].rewards.values)
    elseif isInArray({"storage", "stor", 5}, tasks[t].rewards.type) then
    doCreatureSetStorage(cid, tasks[t].rewards.values[1], tasks[t].rewards.values[2])
    elseif isInArray({"points", "rank", 2}, tasks[t].rewards.type) then
    doCreatureSetStorage(cid, rankStorage, getCreatureStorage(cid, rankStorage) + tasks[t].rewards.values)
    else
    print("[Warning - Npc::KillingInTheNameOf] Wrong reward type: " .. (tasks[t].rewards.type or "nil") .. ", reward could not be loaded.")
    end
    end
    end
    local rank = getCreatureStorage(cid, rankStorage)
    selfSay("Great!... you have finished the task number " .. t .. "" .. (rank > 4 and ", you are a " or "") .. "" .. (((rank > 4 and rank < 10) and ("Huntsman") or (rank > 9 and rank < 20) and ("Ranger") or (rank > 19 and rank < 30) and ("Big Game Hunter") or (rank > 29 and rank < 50) and ("Trophy Hunter") or (rank > 49) and ("Elite Hunter")) or "") .. ". Good job.", cid)
    return doCreatureSetStorage(cid, tasks[t].questStarted, 2)
    end
    return true
    end
    
    npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
    npcHandler:addModule(FocusModule:new())
    and i have this bug in console while talking to npc, but I don't think it connects with reward bug

    Code:
    [15:12:39.203] [Error - NpcScript Interface]
    [15:12:39.203] data/npc/scripts/killinginthenameof.lua:onCreatureSay
    [15:12:39.203] Description:
    [15:12:39.203] data/npc/scripts/killinginthenameof.lua:124: attempt to concatenate field 'raceName' (a nil value)
    [15:12:39.203] stack traceback:
    [15:12:39.203]  data/npc/scripts/killinginthenameof.lua:124: in function 'callback'
    [15:12:39.204]  data/npc/lib/npcsystem/npchandler.lua:390: in function 'onCreatureSay'
    [15:12:39.204]  data/npc/scripts/killinginthenameof.lua:92: in function <data/npc/scripts/killinginthenameof.lua:92>
    
     
  19. hellboy

    hellboy Active Member

    Joined:
    Apr 6, 2008
    Messages:
    325

    Try change: (in 123 line)
    Code:
           for i = 1, table.maxn(tasks) do
               text = text .. (text == "" and "" or "\n") .. i .. " - " .. tasks.raceName .. (getCreatureStorage(cid, tasks.questStarted) == 1 and " [...]" or getCreatureStorage(cid, tasks.questStarted) == 2 and " [x]" or "")
           end
    
    To:
    Code:
           for i = 1, table.maxn(tasks) do
               text = text .. (text == "" and "" or "\n") .. i .. " - " .. tasks[i].raceName .. (getCreatureStorage(cid, tasks[i].questStarted) == 1 and " [...]" or getCreatureStorage(cid, tasks[i].questStarted) == 2 and " [x]" or "")
           end
    
     
  20. Fiodor

    Fiodor Lua & Maps

    Joined:
    Mar 14, 2009
    Messages:
    392
    Thanks, now that bug doesn't appear and NPC shows me list of tasks (he didn't do it before)

    But Grizzly Adams still does not give any rewards :/ Everything works fine, until this moment :/ anyone has an idea? no bugs in console, tf 0.4
     

Share This Page