[Creatureevent] onMoveItem(cid, item, count, toContainer, fromContainer, ...)

[Summ]

Hey guys.
This creatureevent is required for a shop system I am going to release this week.
It basically offers every information you need and is more advanced than the default onThrow().

Let's start:
____________________________________
Creatureevent.cpp

Below:

else if(type == "throw")
    _type = CREATURE_EVENT_THROW;

Add:

else if(type == "moveitem")
    _type = CREATURE_EVENT_MOVEITEM;

____________________________________
Below:

case CREATURE_EVENT_THROW:
    return "onThrow";

Add:

case CREATURE_EVENT_MOVEITEM:
    return "onMoveItem";

____________________________________
Below:

case CREATURE_EVENT_THROW:
    return "cid, item, fromPosition, toPosition";

Add:

case CREATURE_EVENT_MOVEITEM:
    return "cid, item, count, toContainer, fromContainer, fromPos, toPos";

____________________________________
After this method:

uint32_t CreatureEvent::executeThrow(Player* player, Item* item, const Position& fromPosition, const Position& toPosition)

Add this method:

uint32_t CreatureEvent::executeMoveItem(Player* player, Item* item, uint8_t count, const Position& fromPos, const Position& toPos, Item* toContainer, Item* fromContainer, int16_t fstack)
{
    //onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
    if(m_interface->reserveEnv())
    {
        ScriptEnviroment* env = m_interface->getEnv();
        if(m_scripted == EVENT_SCRIPT_BUFFER)
        {
            env->setRealPos(player->getPosition());
            std::stringstream scriptstream;
            scriptstream << "local cid = " << env->addThing(player) << std::endl;

            env->streamThing(scriptstream, "item", item, env->addThing(item));
            scriptstream << "local count = " << count << std::endl;
            env->streamThing(scriptstream, "toContainer", toContainer, env->addThing(toContainer));
            env->streamThing(scriptstream, "fromContainer", fromContainer, env->addThing(fromContainer));
            env->streamPosition(scriptstream, "fromPos", fromPos, fstack);
            env->streamPosition(scriptstream, "toPos", toPos, 0);


            scriptstream << m_scriptData;
            bool result = true;
            if(m_interface->loadBuffer(scriptstream.str()))
            {
                lua_State* L = m_interface->getState();
                result = m_interface->getGlobalBool(L, "_result", true);
            }

            m_interface->releaseEnv();
            return result;
        }
        else
        {
            #ifdef __DEBUG_LUASCRIPTS__
            char desc[30];
            sprintf(desc, "%s", player->getName().c_str());
            env->setEvent(desc);
            #endif

            env->setScriptId(m_scriptId, m_interface);
            env->setRealPos(player->getPosition());

            lua_State* L = m_interface->getState();
            m_interface->pushFunction(m_scriptId);

            lua_pushnumber(L, env->addThing(player));

            LuaInterface::pushThing(L, item, env->addThing(item));
            lua_pushnumber(L, count);
            LuaInterface::pushThing(L, toContainer, env->addThing(toContainer));
            LuaInterface::pushThing(L, fromContainer, env->addThing(fromContainer));
            LuaInterface::pushPosition(L, fromPos, fstack);
                        LuaInterface::pushPosition(L, toPos, 0);

            bool result = m_interface->callFunction(7);
            m_interface->releaseEnv();
            return result;
        }
    }
    else
    {
        std::clog << "[Error - CreatureEvent::executeMoveItem] Call stack overflow." << std::endl;
        return 0;
    }
}

____________________________________
creatureevent.h

Below:

uint32_t executePrepareDeath(Creature* creature, DeathList deathList);

Add:

uint32_t executeMoveItem(Player* player, Item* item, uint8_t count, const Position& fromPos, const Position& toPos, Item* toContainer, Item* fromContainer, int16_t fstack);

____________________________________
Below:

CREATURE_EVENT_PREPAREDEATH

Add:

CREATURE_EVENT_MOVEITEM

(Don't forget to add , after CREATURE_EVENT_PREPAREDEATH)
____________________________________
game.cpp

After:

if(!canThrowObjectTo(mapFromPos, mapToPos) && !player->hasCustomFlag(PlayerCustomFlag_CanThrowAnywhere))
{
    player->sendCancelMessage(RET_CANNOTTHROW);
    return false;
}

Add:

bool success = true;
CreatureEventList moveitemEvents = player->getCreatureEvents(CREATURE_EVENT_MOVEITEM);
for(CreatureEventList::iterator it = moveitemEvents.begin(); it != moveitemEvents.end(); ++it)
{
    Item* toContainer = toCylinder->getItem();
    Item* fromContainer = fromCylinder->getItem();
    if(!(*it)->executeMoveItem(player, item, count, fromPos, toPos, (toContainer ? toContainer : 0), (fromContainer ? fromContainer : 0), fromStackpos) && success)
        success = false;
}

if(!success)
    return false;

____________________________________
____________________________________

Example / How to use:

data/creaturescripts/creaturescripts.xml:

    <event type="moveitem" name="MoveItem" event="script" value="moveitem.lua"/>

data/creaturescripts/scripts/moveitem.lua:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
    if item.actionid == 1000 then
        return false
    end

    return true
end

data/creaturescripts/scripts/login.lua:

registerCreatureEvent(cid, "MoveItem")

-> Block items with actionid 1000 from being moved (Really simple example)

 

[Printer]

Great

 

[Jetro]

not bad , thanks for release it

 

[conde2]

case CREATURE_EVENT_MOVEITEM:
return "cid, item, count, count, fromPos, toPos";

These params are correct ??

 

[StreamSide]

These params are correct ??

case CREATURE_EVENT_MOVEITEM: 
            return "cid, item, count, toContainer, fromContainer, fromPos, toPos";

no?

 

[Summ]

Added that, but doesn't really change anything if you aren't using buffers so I never noticed.

 

[Baxnie]

Very Good Summ

 

[conde2]

Added that, but doesn't really change anything if you aren't using buffers so I never noticed.

Yes i know, i just saw the mistake and want to confirm it =)

 

[Summ]

Updated the formatting to new forum code tags.
If you are still using 0.4 you might want to try this out

 

[Evil Puncker]

you rocks! will try it soon

 

[Shackal]

Top!!
Thanks mate!

 

[GOD Fito]

@Summ this can be used to prevent drop items to the floor from inventory or containers? I mean that if is possible that a specific item id only can move in the backpack, inventory, depot but can't be thrown to the floor.

 

[chiitus]

@Summ this can be used to prevent drop items to the floor from inventory or containers? I mean that if is possible that a specific item id only can move in the backpack, inventory, depot but can't be thrown to the floor.

I think its possible, just use the variables "(cid, item, count, toContainer, fromContainer, fromPos, toPos)" to check whatever u want.

 

[Nothxbye]

I saw some problems with stackable items i mean it's not able to get moved item

 

[001rafa]

Please how to convert moveitem to tfs 1.0 ? for version 10.76 ? please

 

[Printer]

Please how to convert moveitem to tfs 1.0 ? for version 10.76 ? please

Update atleast to tfs 1.1, there is already OnMoveItem event added:
https://github.com/otland/forgottenserver/tree/master/data/events

 

[001rafa]

Update atleast to tfs 1.1, there is already OnMoveItem event added:
https://github.com/otland/forgottenserver/tree/master/data/events

Sorry, i have this version my friend, but i can't use this... for example i need to use my energy ring in my backpack... i can't do that :/

do you know about this ? ;/

Thanks soo much for help :$