Feature Critical hit animation

[hesczu]

THIS IS FOR TAGS.
TESTED IN REV 966

In your config.lua add this:

displayCriticalHitNotify = "yes" --made by elf

In configmanager.cpp
under this:

m_confInteger[WHITE_SKULL_TIME] = getGlobalNumber(L, "whiteSkullTime", 15 * 60 * 1000);

paste this

m_confString[DISPLAY_CRITICAL_HIT] = getGlobalString(L, "displayCriticalHitNotify", "no");

AFTER

In configmanager.h
Under this:

GENERATE_ACCOUNT_NUMBER,

paste this

DISPLAY_CRITICAL_HIT,

In player.cpp
In line 4274 add this:

void Player::sendCriticalHit() const
{
	if(g_config.getString(ConfigManager::DISPLAY_CRITICAL_HIT) == "yes")
		g_game.addAnimatedText(getPosition(), TEXTCOLOR_DARKRED, "CRITICAL!");
}

In player.h
line 564 add this:

void sendCriticalHit() const;

In weapons.cpp

In line 384 remplace this:

maxDamage <<= 1;

With this:

{
			maxDamage <<= 1;
			player->sendCriticalHit();
		}

In line 666 remplace this:

maxValue <<= 1;

with this:

{
		maxValue <<= 1;
		player->sendCriticalHit();
	}

In line 891 remplace this:

maxValue <<= 1;

with this

{
		maxValue <<= 1;
		player->sendCriticalHit();
	}

In line 996 remplace this:

if(maxDamage)
		return -maxChange;

	return random_range(-minChange, -maxChange, DISTRO_NORMAL);

With this:

if(maxDamage)
	{
		player->sendCriticalHit();
		return -maxChange;
	}

	return random_range(-minChange, -maxChange, DISTRO_NORMAL);

All credits to Elf, he made this code im only make some changes for capability with tags

If you think the weapons part is hard, feel free to download my attachment

 

[coolashe]

Thank's for this code. Really nice

 

[Keraxel]

I cannot find void Player::sendCriticalHit() const in player.cpp
Tags, rev 866 (0.2.13)

 

[coolashe]

The code is quite unstable. Made my server crash every hit when someone critted.

 

[hesczu]

Dont for me, all works really fine

 

[Sasir]

Works perfectly. Thanks a lot.

 

[Temptation]

Yeah, it's nice.
Thanks.

 

[Dillon1234]

This is included in the TFS Server..

 

[hesczu]

Yes, but only in trunk and this is for tags

 

[koitsalu]

Is it really included in the latest TFS? I can't find that line in config.lua

"displayCriticalHitNotify"

 

[Mystic Prince]

i cant find player cpp wht is that? (XML USER)

 

[Oceanic]

Nice work

 

[Mazen]

I love it! Thank you!

 

[JayBeee]

i cant find player cpp wht is that? (XML USER)

This code is for TFS, either change to TFS or get someone else to do the same for you.

 

[m1n054]

I'm having problems to get this work... i believe that it's better to give a code to locate where to add the code, because lines not always are the same xD.

 

[Kramer infernal]

I don't see any CRITICAL message

 

[Federico]

This has already been implemented in tfs 0.3 only guys that use 0.2 use this

 

[zajacmp3]

(Problem deleted cause of autor stupidity)

After hard time with this code i made it myself ; D I just had to put a little faith in me.
This code is working grat on my TFS 0.2 : D many thanks

 

[telefono]

245 C:\Documents and Settings\Usuario\Mis documentos\0.3.6pl1\configmanager.cpp no matching function for call to `ConfigManager::getGlobalString(lua_State*&, const char[25], const char[3])'

error configmanager.cpp pls HELP =(

 

[Mogex]

can u give us screenshots?