Custom Distance effect problem

[Hashirama479]

---------- TFS 0.4 !!! ---------------

Yoyo otland I have a problem... I did add a custom distance effect to my object builder then i did regirst it on Tools.cpp and const.h and in lib aswell too but for some reasons it does not work... Can someone help me please?

What you mean it does not work?

Also if I use /x 42 as explain its working but once I use it in items xml here a explain:

    <item id="13060" article="a" name="Donation Arrow">
        <attribute key="description" value="This arrow has been created by the poison masters." />
        <attribute key="weight" value="100" />
        <attribute key="attack" value="5000" />
        <attribute key="description" value="+5000 attack." />
        <attribute key="slotType" value="ammo" />
        <attribute key="ammoType" value="arrow" />
        <attribute key="shootType" value="donarrow" />
        <attribute key="weaponType" value="ammunition" />
    </item>

then I atk a monster or what ever and I get debug... how comes? xD

 

[Nekiro]

The only reason that I see here, considering debugging client is wrongly added sprite.

 

[Hashirama479]

hmm idk whats wrong with it xD
but the client does only debug when I put the shoottype as don arrow but if I got a custom script where i can put the "number of the effect" it does work perfectly it shots the arrow without any problem ^^

You see? xD it just debugs when im using this for my arrow
<attribute key="shootType" value="donarrow" />

 

[Infernum]

im pretty sure you need to add a node to parse in items.cpp for "donarrow"
look under shoottype

 

[Hashirama479]

Found something like that

    speed = id = 0;
    clientId = 100;
    maxItems = 8; //maximum size if this is a container
    weight = 0; //weight of the item, e.g. throwing distance depends on it
    showCount = true;
    weaponType = WEAPON_NONE;
    slotPosition = SLOTP_HAND | SLOTP_AMMO;
    wieldPosition = SLOT_HAND;
    ammoType = AMMO_NONE;
    ammoAction = AMMOACTION_NONE;
    shootType = (ShootEffect_t)0;
    magicEffect = MAGIC_EFFECT_NONE;
    attack = extraAttack = 0;
    defense = extraDefense = 0;
    attackSpeed = 0;
    armor = 0;
    decayTo = -1;
    decayTime = 0;
    stopTime = false;
    corpseType = RACE_NONE;
    fluidSource = FLUID_NONE;
    allowDistRead = false;

or this

            else if(tmpStrValue == "shoottype")
            {
                if(readXMLString(itemAttributesNode, "value", strValue))
                {
                    ShootEffect_t shoot = getShootType(strValue);
                    if(shoot != SHOOT_EFFECT_UNKNOWN)
                        it.shootType = shoot;
                    else
                        std::clog << "[Warning - Items::loadFromXml] Unknown shootType " << strValue << std::endl;
                }
            }

Cant find anything else under shoottype :'/

 

[Infernum]

forgottenserver036pl1/tools.cpp at master · peonso/forgottenserver036pl1 · GitHub
did you add donarrow to here?
and the shoot effect to here?
forgottenserver036pl1/const.h at master · peonso/forgottenserver036pl1 · GitHub
add something like SHOOT_EFFECT_DONARROW = 0x2A
then make SHOOT_EFFECT_LAST = SHOOT_EFFECT_DONARROW
and inside tools.cpp
{"donarrow", SHOOT_EFFECT_DONARROW}

 

[Hashirama479]

Ye I did but my donarrow was = 0x30 should I change it to 0x2a as you said ?

 

[Infernum]

yeah, that's not how you count in hex
hex is base 16
0 1 2 3 4 5 6 7 8 9 A B C D E F
0x29 (41) -> 0x2A (42)

 

[Hashirama479]

Its working!!!! Finally haha thanks you Static_