Lua Destroy item on move

luccagomes · Aug 16, 2015

Im tryng use this function to delete item on move!
But dont work, when i start the server dont give me erros on console, when i move itens dont give erros on console
I think the problem is here:

Code:

if item.itemid == 2596 then

Or here:

Code:

doRemoveItem(item.uid, 1)

SCRIPTS \/

data/creaturescript/creaturescript.xml

Code:

<event type="moveitem" name="moveParcelRookgaard" event="script" value="moveParcelRookgaard.lua"/>

data/creaturescript/creaturescript.xml/
moveParcelRookgaard.lua

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
if getPlayerVocation(cid) == 0 then
if item.itemid == 2596 then
doRemoveItem(item.uid, 1)
return true
end
end
end

Sources CODE:

Code:

//Função add por luanluciano93uint32_tCreatureEvent::executeMoveItem(Player* player,Item* item,uint8_t count,constPosition& fromPos,constPosition& toPos,Item* toContainer,Item* fromContainer,int16_t fstack){//onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)if(m_interface->reserveEnv()){ScriptEnviroment* env = m_interface->getEnv();if(m_scripted == EVENT_SCRIPT_BUFFER){
env->setRealPos(player->getPosition());
std::stringstream scriptstream;
scriptstream <<"local cid = "<< env->addThing(player)<< std::endl;

env->streamThing(scriptstream,"item", item, env->addThing(item));
scriptstream <<"local count = "<< count << std::endl;
env->streamThing(scriptstream,"toContainer", toContainer, env->addThing(toContainer));
env->streamThing(scriptstream,"fromContainer", fromContainer, env->addThing(fromContainer));
env->streamPosition(scriptstream,"fromPos", fromPos, fstack);
env->streamPosition(scriptstream,"toPos", toPos,0);


scriptstream << m_scriptData;bool result =true;if(m_interface->loadBuffer(scriptstream.str())){
lua_State* L = m_interface->getState();
result = m_interface->getGlobalBool(L,"_result",true);}

m_interface->releaseEnv();return result;}else{#ifdef __DEBUG_LUASCRIPTS__
char desc[30];
sprintf(desc,"%s", player->getName().c_str());
env->setEvent(desc);#endif

env->setScriptId(m_scriptId, m_interface);
env->setRealPos(player->getPosition());

lua_State* L = m_interface->getState();
m_interface->pushFunction(m_scriptId);

lua_pushnumber(L, env->addThing(player));

LuaInterface::pushThing(L, item, env->addThing(item));
lua_pushnumber(L, count);LuaInterface::pushThing(L, toContainer, env->addThing(toContainer));LuaInterface::pushThing(L, fromContainer, env->addThing(fromContainer));LuaInterface::pushPosition(L, fromPos, fstack);LuaInterface::pushPosition(L, toPos,0);

bool result = m_interface->callFunction(7);
m_interface->releaseEnv();return result;}}else{
std::clog <<"[Error - CreatureEvent::executeMoveItem] Call stack overflow."<< std::endl;return0;}}

Shadow Dan · Aug 16, 2015

Try this:

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
    if getPlayerVocation(cid) == 0 then
        doRemoveItem(item.uid, 1)
        return false
    end
end

In TFS 1.2 i used this:

Code:

    if item.itemid == 2223 then
        item:remove(-1)
        return false
    end

And it worked. You need to write remove item correctly.

Maybe this:

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
    if item.itemid == 2596 then
        if getPlayerVocation(cid) == 0 then
            doRemoveItem(item, 1)
            return false
        end
    end
end

luccagomes · Aug 16, 2015

Shadow Dan said:

Try this:

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
    if getPlayerVocation(cid) == 0 then
        doRemoveItem(item.uid, 1)
        return false
    end
end

In TFS 1.2 i used this:

Code:

    if item.itemid == 2223 then
        item:remove(-1)
        return false
    end

And it worked. You need to write remove item correctly.

Maybe this:

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
    if item.itemid == 2596 then
        if getPlayerVocation(cid) == 0 then
            doRemoveItem(item, 1)
            return false
        end
    end
end

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
    if getPlayerVocation(cid) == 0 then
        doRemoveItem(item.uid, 1)
        return false
    end
end

dont work, dont do nothing

i dont use 1.2, i use 0.4

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
    if getPlayerVocation(cid) == 0 then
        doRemoveItem(item.uid, 1)
        return false
    end
end

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
    if getPlayerVocation(cid) == 0 then
        doRemoveItem(item.uid, 1)
        return false
    end
end

dont work

Xikini · Aug 16, 2015

Are you getting errors?
Returning false might screw it up as well.. Try return true for vocation 0..and return false for everyone else. or other way around. Sorry its 3am.Dx

Shadow Dan · Aug 16, 2015

Xikini said:
Are you getting errors?
Returning false might screw it up as well.. Try return true for vocation 0..and return false for everyone else. or other way around. Sorry its 3am.Dx

lol

luccagomes said:
dont work

0.4? do you have function onMoveItem?? Where you put your script? If you don't have function you need to compile server and use this tutorial to add function.
https://otland.net/threads/creaturescript-onmoveitem-moveitem-frompos-position-cid.96742/

2 months ago i was hosting max 8.6 version, now when i use 10.77 and look at 8.6 engine i am like "wtf there is nothing, zero functions"

Codex NG · Aug 17, 2015

Maybe this will be helpful.
https://otland.net/threads/creaturescript-onmoveitem-moveitem-frompos-position-cid.96742/

luccagomes · Aug 17, 2015

i have the function, run, but dont delete the item!

Shadow Dan · Aug 17, 2015

And no errors in console? thats all you can tell us?
If you have no errors that means you dont have this function or you put it in wrong file.
Say what files you using to run this script and show us full script.
Full paths to scripts from data/ to file.xml/.lua
Take a look on console when you trying to run script and when you reload scripts if there is any error.
Example: cannot load script moveitem.lua or anything that could help us to see the problem.

Answer like not working script is useless for us if you don't post errors.

luccagomes · Aug 18, 2015

Shadow Dan said:
And no errors in console? thats all you can tell us?
If you have no errors that means you dont have this function or you put it in wrong file.
Say what files you using to run this script and show us full script.
Full paths to scripts from data/ to file.xml/.lua
Take a look on console when you trying to run script and when you reload scripts if there is any error.
Example: cannot load script moveitem.lua or anything that could help us to see the problem.

Answer like not working script is useless for us if you don't post errors.

I'm edit the first post (on this topic)

Shadow Dan · Aug 18, 2015

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
print("Script started.")
    if getPlayerVocation(cid) == 0 then
        print("Vocation = 0. OK")
        if item.itemid == 2596 then
            print("item.itemid == 2596. OK")
            doRemoveItem(item.uid, 1)
            return true
        end
    end
    print("END script.")
end

Use this script then show us screen shot from your console after you try to move item.

luccagomes · Aug 20, 2015

Shadow Dan said:

Code:

function onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)
print("Script started.")
    if getPlayerVocation(cid) == 0 then
        print("Vocation = 0. OK")
        if item.itemid == 2596 then
            print("item.itemid == 2596. OK")
            doRemoveItem(item.uid, 1)
            return true
        end
    end
    print("END script.")
end

Use this script then show us screen shot from your console after you try to move item.

Dont print nothing
I think I'm using this function the wrong way

looking at the code in source code, you can tell me the right way?

Code:

//Função add por luanluciano93uint32_tCreatureEvent::executeMoveItem(Player* player,Item* item,uint8_t count,constPosition& fromPos,constPosition& toPos,Item* toContainer,Item* fromContainer,int16_t fstack){//onMoveItem(cid, item, count, toContainer, fromContainer, fromPos, toPos)if(m_interface->reserveEnv()){ScriptEnviroment* env = m_interface->getEnv();if(m_scripted == EVENT_SCRIPT_BUFFER){
env->setRealPos(player->getPosition());
std::stringstream scriptstream;
scriptstream <<"local cid = "<< env->addThing(player)<< std::endl;

env->streamThing(scriptstream,"item", item, env->addThing(item));
scriptstream <<"local count = "<< count << std::endl;
env->streamThing(scriptstream,"toContainer", toContainer, env->addThing(toContainer));
env->streamThing(scriptstream,"fromContainer", fromContainer, env->addThing(fromContainer));
env->streamPosition(scriptstream,"fromPos", fromPos, fstack);
env->streamPosition(scriptstream,"toPos", toPos,0);


scriptstream << m_scriptData;bool result =true;if(m_interface->loadBuffer(scriptstream.str())){
lua_State* L = m_interface->getState();
result = m_interface->getGlobalBool(L,"_result",true);}

m_interface->releaseEnv();return result;}else{#ifdef __DEBUG_LUASCRIPTS__
char desc[30];
sprintf(desc,"%s", player->getName().c_str());
env->setEvent(desc);#endif

env->setScriptId(m_scriptId, m_interface);
env->setRealPos(player->getPosition());

lua_State* L = m_interface->getState();
m_interface->pushFunction(m_scriptId);

lua_pushnumber(L, env->addThing(player));

LuaInterface::pushThing(L, item, env->addThing(item));
lua_pushnumber(L, count);LuaInterface::pushThing(L, toContainer, env->addThing(toContainer));LuaInterface::pushThing(L, fromContainer, env->addThing(fromContainer));LuaInterface::pushPosition(L, fromPos, fstack);LuaInterface::pushPosition(L, toPos,0);

bool result = m_interface->callFunction(7);
m_interface->releaseEnv();return result;}}else{
std::clog <<"[Error - CreatureEvent::executeMoveItem] Call stack overflow."<< std::endl;return0;}}

Shadow Dan · Aug 20, 2015

Im not good in c++, can't help you with something that you don't have, sorry.
It's eot for me, try to add Mock's function https://otland.net/threads/creaturescript-onmoveitem-moveitem-frompos-position-cid.96742/

gmstrikker · Aug 23, 2015

Shadow Dan said:
Im not good in c++, can't help you with something that you don't have, sorry.
It's eot for me, try to add Mock's function https://otland.net/threads/creaturescript-onmoveitem-moveitem-frompos-position-cid.96742/

He have
executeMoveItem

On he sources, but he need know how to use it in lua script

Idk wait a better member

luccagomes · Aug 24, 2015

gmstrikker said:
He have
executeMoveItem

On he sources, but he need know how to use it in lua script

Idk wait a better member

Ty, im waiting

luccagomes · Aug 26, 2015

Lua Destroy item on move

luccagomes

New Member

Shadow Dan

Sh4dowDan

luccagomes

New Member

Xikini

I whore myself out for likes

Shadow Dan

Sh4dowDan

Codex NG

Recurrent Flamer

luccagomes

New Member

Shadow Dan

Sh4dowDan

luccagomes

New Member

Shadow Dan

Sh4dowDan

luccagomes

New Member

Shadow Dan

Sh4dowDan

gmstrikker

Well-Known Member

luccagomes

New Member

luccagomes

New Member

Similar threads