Does not add item to player TFS 1.3

[Marko999x]

heyo
as the title says
people does not get the item for some reason
I do not have any errors + I tried to fix it by myself but at this point im kinda lost now
what im doing wrong?
a explain would be awesome what I did wrong ( Trying to learn )
Script:

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if player:getStorageValue(52003) == -1 then
        player:setStorageValue(52003, 1)
        elseif
        player:getVocation() == 1 then
        player:addItem(7958, 1)
        elseif
        player:getVocation() == 2 then
        player:addItem(2184, 1)
        elseif
        player:getVocation() == 3 then
        player:addItem(7438, 1)
        elseif
        player:getVocation() == 4 then
        player:addItem(2451, 1)
    else
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, 'You alredy got your reward.')
        player:getPosition():sendMagicEffect(3)
    end
    return true
end

 

[Addams]

Try this one, Also wrong section.

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if player:getStorageValue(52003) == -1 then
        player:setStorageValue(52003, 1)
        elseif
        player:getVocation():getID() == 1 then
        player:addItem(7958, 1)
        elseif
        player:getVocation():getID() == 2 then
        player:addItem(2184, 1)
        elseif
        player:getVocation():getID() == 3 then
        player:addItem(7438, 1)
        elseif
        player:getVocation():getID() == 4 then
        player:addItem(2451, 1)
    else
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, 'You alredy got your reward.')
        player:getPosition():sendMagicEffect(3)
    end
    return true
end

 

[Infernum]

pls dont write it like that

local rewards = {
    [1] = 7958,
    [2] = 2184,
    [3] = 7438,
    [4] = 2451
}

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if player:getStorageValue(52003) == -1 then
        local reward = rewards[player:getVocation():getId()]
        if reward then
            player:setStorageValue(52003, 1)
            player:addItem(reward, 1)
        else
            print(debug.traceback('Reward not found'))
        end
    else
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, 'You already got your reward.')
        player:getPosition():sendMagicEffect(CONST_ME_POFF)
    end
    return true
end

 

[aqubjukr]

pls dont write it like that

local rewards = {
    [1] = 7958,
    [2] = 2184,
    [3] = 7438,
    [4] = 2451
}

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if player:getStorageValue(52003) == -1 then
        local reward = rewards[player:getVocation():getId()]
        if reward then
            player:setStorageValue(52003, 1)
            player:addItem(reward, 1)
        else
            print(debug.traceback('Reward not found'))
        end
    else
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, 'You already got your reward.')
        player:getPosition():sendMagicEffect(CONST_ME_POFF)
    end
    return true
end

The script is fine, but won't be missing the reward, if a player has promotion?

 

[Infernum]

The script is fine, but won't be missing the reward, if a player has promotion?

it will be missing but we dont know if his server has promotions or if he only has 4 base vocations overall, i just took the ids he used himself