TFS 1.X+ Door's being locked for some reason

[Joriku]

Hey,
Using OTServBR, some doors all around the map is being locked for some weird reason. For example 1212 is locked (Closed door) can't be open due to "This door is locked". Whole Issavi (almost) Is locked down.
What's causing this and how would it be solved?

 

[EduardoDantas]

This is simple. We redid the doors system in this commit: New door system and reorganization of the folder libs. (#868) · opentibiabr/otservbr-global@f436c91 (https://github.com/opentibiabr/otservbr-global/commit/f436c91bfb8237c8ae4276179e55851e324cf479)

With this, all doors are as in the global tibia, and the key doors (always those that have two doors of equal appearance) were duly registered in the scripts as LOCKED DOOR (they only open with the key / action and door / action of the key. With that, the doors that are KEY but are on the map as an unlocked door, have been locked, so it is now necessary to change them on the map to the correct id.

My advice is to first look for project support for this type of question, I am taking the positions of the doors there and correcting them on the map at localhost, to go up in the repository.

 

[HalfAway]

EduardoDantas was faster.

-----

It is defined as a locked door.

otservbr-global/data/lib/tables/door.lua at ddc4c892efed021d9aa9e7f2ccc723d941d3448e · opentibiabr/otservbr-global

OTServBR-Global datapack was migrated to Canary repository: https://github.com/opentibiabr/canary - opentibiabr/otservbr-global

github.com

List of unlocked doors:

otservbr-global/data/lib/tables/door.lua at ddc4c892efed021d9aa9e7f2ccc723d941d3448e · opentibiabr/otservbr-global

OTServBR-Global datapack was migrated to Canary repository: https://github.com/opentibiabr/canary - opentibiabr/otservbr-global

github.com

Check inside the script for the doors here:

otservbr-global/data/scripts/actions/door/key_door.lua at e422a4631aac6a32515271b1ad8eb4083e6913cf · opentibiabr/otservbr-global

OTServBR-Global datapack was migrated to Canary repository: https://github.com/opentibiabr/canary - opentibiabr/otservbr-global

github.com

 

[EduardoDantas]

EduardoDantas was faster.

-----

It is defined as a locked door.

otservbr-global/data/lib/tables/door.lua at ddc4c892efed021d9aa9e7f2ccc723d941d3448e · opentibiabr/otservbr-global

OTServBR-Global datapack was migrated to Canary repository: https://github.com/opentibiabr/canary - opentibiabr/otservbr-global

github.com

List of unlocked doors:

otservbr-global/data/lib/tables/door.lua at ddc4c892efed021d9aa9e7f2ccc723d941d3448e · opentibiabr/otservbr-global

OTServBR-Global datapack was migrated to Canary repository: https://github.com/opentibiabr/canary - opentibiabr/otservbr-global

github.com

Check inside the script for the doors here:

otservbr-global/data/scripts/actions/door/key_door.lua at e422a4631aac6a32515271b1ad8eb4083e6913cf · opentibiabr/otservbr-global

OTServBR-Global datapack was migrated to Canary repository: https://github.com/opentibiabr/canary - opentibiabr/otservbr-global

github.com

Yes, it is defined as locked door.

It is locked by default, in its description when using (set in items.xml) it has "It is locked"
It cannot be opened and should not be used unless it has a key or is impossible to enter.

It could easily be changed in the script, but that would not be correct, the correct thing is to change it on the map, (previous global projects put it wrong).

 

[Joriku]

Yes, it is defined as locked door.

It is locked by default, in its description when using (set in items.xml) it has "It is locked"
It cannot be opened and should not be used unless it has a key or is impossible to enter.

It could easily be changed in the script, but that would not be correct, the correct thing is to change it on the map, (previous global projects put it wrong).

Allright, so just recommending to change all the doors that's locked?

 

[EduardoDantas]

Allright, so just recommending to change all the doors that's locked?

I am doing this. You can send the positions you found that I will go up or the map corrected soon.

 

[EduardoDantas]

Fix here: Fix for the doors not opening. by dudantas · Pull Request #909 · opentibiabr/otservbr-global (https://github.com/opentibiabr/otservbr-global/pull/909)

Now check if there is action on the door, if not, it will open normally.

 

[Joriku]

Fix here: Fix for the doors not opening. by dudantas · Pull Request #909 · opentibiabr/otservbr-global (https://github.com/opentibiabr/otservbr-global/pull/909)

Now check if there is action on the door, if not, it will open normally.

Got it working, just changed the Issavi door id's into normal doors.
Solved, pmed you. Will keep posting issues/bugs I find for you there.

 

[EduardoDantas]

Definitely fixed on the map, here: Definitive fix for the bugs on the keys doors. by dudantas · Pull Request #917 · opentibiabr/otservbr-global (https://github.com/opentibiabr/otservbr-global/pull/917)
All doors have been changed from ids to correct ones. Take the change.

#Edit
This fixes the issavi doors: Fix for the issavi doors. · opentibiabr/otservbr-global@ea37140 (https://github.com/opentibiabr/otservbr-global/commit/ea37140a16daeb519cff6b876f22ae624f2541dc)