Drops item with bless

[vingo]

Im using TFS 1.0, MarkSamman forgottenserver from github, but people are dropping items when dying with bless, why is this?

 

[Techrlz]

Post here your script that put "blessing" in ppl.

 

[vingo]

well, I have automatic bless to level 70,

local freeBlessMaxLevel = 70
function onLogin(cid)
    if(getPlayerLevel(cid) <= freeBlessMaxLevel and not getPlayerBlessing(cid,1)) then
        for b=1, 5 do
            doPlayerAddBlessing(cid, b)
        end
        doCreatureSay(cid, 'You got free bless, because your level is lower than 70', TALKTYPE_ORANGE_1)
        elseif(getPlayerBlessing(cid,1)) then
    doCreatureSay(cid, 'You are bleesed!', TALKTYPE_ORANGE_1)
    else
    doCreatureSay(cid, 'You are not bleesed. type !bless', TALKTYPE_ORANGE_1)
    end
    return true
end

 

[vingo]

Still drops items, I think its in sources


https://github.com/otland/forgottenserver/commit/3987c508bd0f3204262aa9a91dc424c7bec2a1a4

 

[Techrlz]

local freeBlessMaxLevel = 70
function onLogin(cid)
    if(getPlayerLevel(cid) <= freeBlessMaxLevel and not getPlayerBlessing(cid,1)) then
        for b=1, 6 do
            doPlayerAddBlessing(cid, b)
        end
        doCreatureSay(cid, 'You got free bless, because your level is lower than 70', TALKTYPE_ORANGE_1)
        elseif(getPlayerBlessing(cid,1)) then
    doCreatureSay(cid, 'You are bleesed!', TALKTYPE_ORANGE_1)
    else
    doCreatureSay(cid, 'You are not bleesed. type !bless', TALKTYPE_ORANGE_1)
    end
    return true
end

Test and say for me if work.

 

[vingo]

That code crashed my server

 

[Techrlz]

edited main topic.

 

[vingo]

Malformed number near 70function

 

[vingo]

here is talkaction

function onSay(cid, words, param)
    local cost = getBlessingsCost(getPlayerLevel(cid))
    if (isPlayerPzLocked(cid) == FALSE) then
        if (getPlayerBlessing(cid, 1) and getPlayerBlessing(cid, 2) and getPlayerBlessing(cid, 3) and getPlayerBlessing(cid, 4) and getPlayerBlessing(cid, 5)) then
            doPlayerSendCancel(cid,"You have already been blessed by the gods.")
            return false
        end
        if (doPlayerRemoveMoney(cid,cost)) then
            doPlayerAddBlessing(cid, 1)
            doPlayerAddBlessing(cid, 2)
            doPlayerAddBlessing(cid, 3)
            doPlayerAddBlessing(cid, 4)
            doPlayerAddBlessing(cid, 5)
            doSendMagicEffect(getCreaturePosition(cid), CONST_ME_HOLYAREA)
            doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "You have been blessed by the 5 gods!")
        else
            doPlayerSendCancel(cid,"You need "..cost.." gold coins to buy all 5 bless.")
        end
    else
        doPlayerSendCancel(cid,"You can't buy bless, when you are in a battle.")
    end
    return false
end

 

[vingo]

up

 

[Ninja]

Take a look at the blessing column in players table (phpMyAdmin), it should be either 31 or 63 (5 blessings + twist of fate).

 

[vingo]

It says 32

if (!lastHitPlayer || blessings < 32) {

if (lastHitPlayer) {
bitset.reset(5);
blessings = bitset.to_ulong();
} else {
blessings = 32;
}
} else {
blessings = 0;
}

    std::bitset<5> bitset(blessings);
    switch (bitset.count()) {
        case 1:
            dropPercent = 70;
            break;

        case 2:
            dropPercent = 45;
            break;

        case 3:
            dropPercent = 25;
            break;

        case 4:
            dropPercent = 10;
            break;

        case 5:
            dropPercent = 0;
            break;

        default:
            dropPercent = 100;
            break;

 

[vingo]

Ah, They had 31 in phpmyadmin

I changed it so it gives 6 blesses up to level 70 which means they have 100% protection I guess.


But how do i add in !bless command so they get all blessings aswell?

 

[vingo]

I can't get 6 blessings, even If i add "addblessing, 6" code it gives me 31 in blessings value