• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Error return false

Devlinn

Member
Joined
Mar 25, 2015
Messages
295
Reaction score
6
hello i have problems on compiling ots
Code:
iomapotbm.cpp: In member function 'Item* IOMapOTBM::unserializaItemNode(FileLoader*, NODE)':
iomapotbm.cpp:416:32: error: converting 'false' to pointer type 'Item*' [-Werror=conversion-null]
cc1plus: all warnings being treated as errors
make: *** [iomapotbm.o] Error 1
make: *** Waiting for unfinished jobs....

how to fix?
Code:
    Container* container;
        if(container = dynamic_cast<Container*>(item))
        {
            uint32_t type;
            NODE item_node = f->getChildNode(node, type);
            while(item_node)
            {
                if(type == OTBM_ITEM)
                {
                    Item* item = unserializaItemNode(f, item_node);
                    if(item)
                    {
                        container->addItem(item);
                    }
                    else
                    {
                        return false;                   
                    }
                }
                item_node = f->getNextNode(item_node, type);
            }
        }
    }
    else
    {
        return NULL;
    }
    return item;
}
 
Idk, Wouldn't this make more sense?
Code:
    Container* container;
        if(container = dynamic_cast<Container*>(item)){
            unsigned long type;
            NODE item_node = f->getChildNode(node, type);
            while(item_node){
                if(type == OTBM_ITEM){
                    Item* item = unserializaItemNode(f, item_node);
                    if(item){
                        container->addItem(item);
                    }
                }
                item_node = f->getNextNode(item_node, type);
            }
        }
        else {
            delete container;
            delete item;
            return NULL;
        }
   }
    else
    {
        delete item;
        return NULL;
    }
    return item;
 

Similar threads

Back
Top