[EVENT] antiTrash - antiTheft system for houses [TFS 1.x]

Hello,

Well it been a while when i released scripts, so i made this to my server and i thougt about share it aswell. So other could get use of this system. It is self explanatory, meaning that people who is not invited to the house cannot trash the house or people who is just a guest into the house cannot move items.

Go into events/events.xml and enable, by change the 0 to 1:

Code (Text):

1. <event class="Player" method="onMoveItem" enabled="1" />

Then go into events/scripts/player.lua and paste this under the function:

Code (Text):

1. function Player:onMoveItem(item, count, fromPosition, toPosition)

Code (Text):

1.         local antiTrash = true
2.         local antiTheft = true
3.  
4.         if antiTrash then
5.             local tile = Tile(toPosition)
6.             if tile and tile:hasFlag(TILESTATE_HOUSE) then
7.                 local house = tile:getHouse()
8.                 if house then
9.                     local accessList = House.getAccessList
10.                     local playerName = self:getName():lower()
11.  
12.                     if house ~= self:getHouse() and (playerName ~= accessList(house, GUEST_LIST):lower() or playerName ~= accessList(house, SUBOWNER_LIST):lower()) then
13.                         self:sendTextMessage(MESSAGE_STATUS_SMALL, "You cannot throw items into players houses, which you are not invited to.")
14.                         return false
15.                     end
16.                 end
17.             end
18.         end
19.  
20.         if antiTheft then
21.             local tile = Tile(fromPosition)
22.             if tile and tile:hasFlag(TILESTATE_HOUSE) then
23.                 local house = tile:getHouse()
24.                 if house then
25.                     if house ~= self:getHouse() and self:getName():lower() ~= house:getAccessList(SUBOWNER_LIST):lower() then
26.                         self:sendTextMessage(MESSAGE_STATUS_SMALL, "You cannot move items from house, which you are only guest to.")
27.                         return false
28.                     end
29.                 end
30.             end
31.         end

Enjoy!

 

great job This is useful.

 

please tfs 1.0

 

Great

 

Awesome job, thank you sir!

Edit:

Sorry Sir, i tested it and works 50%... (Using last commit of TFS at GitHub)

As we understand..
Guest: Aleta Sio
Sub-Owner: Aleta Som

I invited a secondary account as Guest and tried to move the items (Yes, i can't move them) But i can move into my equipment slots, but the error message is the one of the anti-trash, if i set antitrash to false and try to only use anti-theft, doesn't works

Did i something wrong or this is not able for TFS 1.X of the last commit?

Regards

 

Sounds nice, possible to convert it to 0.4?

 

Either you are installing it wrong or you have the guy invited. For me it works perfectly.

No idea what functions tfs 0.4 got.

 

this will work if you try to equip items?

 

You cannot move the items, if you are not a sub-owner("aleta som") off the house. So no you cannot equip!

 

Oh wait... Now im confused.

So, if i invite anybody, even if its by "aleta sio" as guest, he can take the items? Or he should not be able to?

I'll try to install again, but my first try, i invited other char as guest with "aleta sio" and he can pickup the items...

Thanks for your reply Printer ^^
I like a lot your scripts

 

Ups recopy the code, only aleta som person should be able to move items.

 

Great work man, really.

 

Thanks, I'll test right now ^^


Edit:

Now it works perfect!

Since TFS 1.x already have an anti-trash system for houses and non-invited players can't throw items to houses, i've set it to "false"

Thank you so much for this release
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

This also works for GM, CM or GOD Characters, making it safer to prevent item stealing from house if you've set that charge to someone else

 

@Printer
With browse field every function in the script is dismissed and the player is able to move the item.

I'm using TFS 1.1 though, is it different on TFS 1.2?

 

can't you just copy

Code (Text):

1.  
2. local antiTrash = true
3. local antiTheft = true
4.  
5. if antiTrash then
6. local tile = Tile(toPosition)
7. if tile and tile:hasFlag(TILESTATE_HOUSE) then
8. local house = tile:getHouse()
9. if house then
10. local accessList = House.getAccessList
11. local playerName = self:getName():lower()
12.  
13. if house ~= self:getHouse() and (playerName ~= accessList(house, GUEST_LIST):lower() or playerName ~= accessList(house, SUBOWNER_LIST):lower()) then
14. self:sendTextMessage(MESSAGE_STATUS_SMALL, "You cannot throw items into players houses, which you are not invited to.")
15. return false
16. end
17. end
18. end
19. end
20.  
21. if antiTheft then
22. local tile = Tile(fromPosition)
23. if tile and tile:hasFlag(TILESTATE_HOUSE) then
24. local house = tile:getHouse()
25. if house then
26. if house ~= self:getHouse() and self:getName():lower() ~= house:getAccessList(SUBOWNER_LIST):lower() then
27. self:sendTextMessage(MESSAGE_STATUS_SMALL, "You cannot move items from house, which you are only guest to.")
28. return false
29. end
30. end
31. end
32. end

under onBrowseField in player.lua too?

obv might require some changes since onmove and onbrowse doesn't have all the same values i think but you should be able to get it to work

 

@Ahilphino

Wow, I didn't even realize that onBrowseField was a player event. Thanks!

I guess he can add that to the first page too!

 

=)
the events folder is rly amazing

but yeah you will need to make a few adjustments since browsefield has other values

 

I was also having trouble with a list with multiple names:
For me it was only working with one player on the list and that's because if you print(#accessList) you'll receive the number of characters/spaces in each name.

For examples the 2 names below are on the accessList --> #accessList = 22
jack in the box
godric

To fix that I replaced this line and used string.find:

Code (Text):

1. if house ~= self:getHouse() and self:getName():lower() ~= house:getAccessList(SUBOWNER_LIST):lower() then

with:

Code (Text):

1. if (house ~= self:getHouse() and not string.find(house:getAccessList(SUBOWNER_LIST):lower(), self:getName():lower())) then

You'll have to replace the other line that performs the same function.

 

tfs 0.4? r3884?