Events not teleporting players.

[Zt0ffe]

As topic says, my events just starts, not teleporting the players into the map.. Yes Iv put out the correct pos.

http://pastebin.com/5XbJBfg5 FIREstorm Event

http://pastebin.com/6XgZUHKD RUNevent

http://pastebin.com/ctKUMgMM - ZombieEvent

Im using 0.4 distro for 8.6. Only error message I get in the console is this:

[Warning - Groups::getGroup] Group 0 not found.

Thanks in advance!

 

[imkingran]

Is there any point in even having these lines in there? I haven't seen why they are useful:

doCreatureSetStorage(cid, configRunEvent.storages.group, getPlayerGroupId(cid))
doPlayerSetGroupId(cid, math.max(1, getCreatureStorage(cid, configRunEvent.storages.group)))

I only did a quick scan but I didn't find any place where configRunEvent.storages.group was even used.
Only the value of it was changed on a few lines.

 

[Leo32]

Is there any point in even having these lines in there? I haven't seen why they are useful:

doCreatureSetStorage(cid, configRunEvent.storages.group, getPlayerGroupId(cid))
doPlayerSetGroupId(cid, math.max(1, getCreatureStorage(cid, configRunEvent.storages.group)))

I only did a quick scan but I didn't find any place where configRunEvent.storages.group was even used.
Only the value of it was changed on a few lines.

Looks like the script is doing some dodgey things:

doPlayerSetGroupId(pid, getCreatureStorage(pid, configRunEvent.storages.group))

configRunEvent = {
                storages = {
                    player = '632342', -- set free storage
                    joining = '986541', -- set free storage
                    group = '6764223', -- set free storage
                    exhaust = '2224442', -- set free storage
                    countEvent = '1116667' -- set free storage
                },

 

[Zt0ffe]

Is there any point in even having these lines in there? I haven't seen why they are useful:

doCreatureSetStorage(cid, configRunEvent.storages.group, getPlayerGroupId(cid))
doPlayerSetGroupId(cid, math.max(1, getCreatureStorage(cid, configRunEvent.storages.group)))

I only did a quick scan but I didn't find any place where configRunEvent.storages.group was even used.
Only the value of it was changed on a few lines.

So Sshould I change it or remove it?

 

[Zt0ffe]

Looks like the script is doing some dodgey things:

doPlayerSetGroupId(pid, getCreatureStorage(pid, configRunEvent.storages.group))

configRunEvent = {
                storages = {
                    player = '632342', -- set free storage
                    joining = '986541', -- set free storage
                    group = '6764223', -- set free storage
                    exhaust = '2224442', -- set free storage
                    countEvent = '1116667' -- set free storage
                },

Dodgey things? My storageIds? That other line maybe I should change to something else?

 

[Leo32]

Dodgey things? My storageIds? That other line maybe I should change to something else?

Its setting a Players GroupID to the value returned by configRunEvent.storages.group... which can lead to some really bad things.
Why is the script changing the group value of a player? they should never be anything other than 1.

 

[Zt0ffe]

Its setting a Players GroupID to the value returned by configRunEvent.storages.group... which can lead to some really bad things.
Why is the script changing the group value of a player? they should never be anything other than 1.

Yeah noticed that. But what should I change it too?

 

[PeteZa]

Try changing it to 1 in the config, maybe that'll solve it:

configRunEvent = {
                storages = {
                    player = '632342', -- set free storage
                    joining = '986541', -- set free storage
                    group = '1', -- set free storage
                    exhaust = '2224442', -- set free storage
                    countEvent = '1116667' -- set free storage
                },

 

[Leo32]

Try changing it to 1 in the config, maybe that'll solve it:

configRunEvent = {
                storages = {
                    player = '632342', -- set free storage
                    joining = '986541', -- set free storage
                    group = '1', -- set free storage
                    exhaust = '2224442', -- set free storage
                    countEvent = '1116667' -- set free storage
                },

The storage key itself does not matter, its grabbing the value of that key:

getCreatureStorage(pid, configRunEvent.storages.group)​

so using 1 as an example:

getCreatureStorage(pid, 1)
​

The storage key being queried and the data being returned:

I don't have the love to go through 267 lines of code, but I'm just pointing out that this script from first glance looks dodge-o.

 

[Zt0ffe]

The storage key itself does not matter, its grabbing the value of that key:

getCreatureStorage(pid, configRunEvent.storages.group)​

so using 1 as an example:

getCreatureStorage(pid, 1)
​

The storage key being queried and the data being returned:

I don't have the love to go through 267 lines of code, but I'm just pointing out that this script from first glance looks dodge-o.

Hehe I understand that, but do you have any code in mind instead of getCreatureStorage(pid, configRunEvent.storages.group)? You seem to know some of this stuff!

 

[Zt0ffe]

- bump -