Exp scroll problem

[Xleniz]

Hello I need some help with my exp scroll script, when someone goes from 180 to 220 he gets 2 "Congratulations, level up" messages at same time, and 80 levels instead of 40.

Thx for help.

function onUse(cid, item, fromPosition, itemEx, toPosition)
	if(getPlayerLevel(cid) <= 200) then
	doSendMagicEffect(getPlayerPosition(cid), 30)
	doSendMagicEffect(getPlayerPosition(cid), 29)
	doPlayerAddLevel(cid, 50)
	doRemoveItem(item.uid, 1)
	doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	end
	if(getPlayerLevel(cid) <= 300 and getPlayerLevel(cid) > 200) then
	doSendMagicEffect(getPlayerPosition(cid), 30)
	doSendMagicEffect(getPlayerPosition(cid), 29)
	doPlayerAddLevel(cid, 40)
	doRemoveItem(item.uid, 1)
	doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	end
	if(getPlayerLevel(cid) <= 400 and getPlayerLevel(cid) > 300) then
	doSendMagicEffect(getPlayerPosition(cid), 30)
	doSendMagicEffect(getPlayerPosition(cid), 29)
	doPlayerAddLevel(cid, 30)
	doRemoveItem(item.uid, 1)
	doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	end
	if(getPlayerLevel(cid) <= 500 and getPlayerLevel(cid) > 400) then
	doSendMagicEffect(getPlayerPosition(cid), 30)
	doSendMagicEffect(getPlayerPosition(cid), 29)
	doPlayerAddLevel(cid, 20)
	doRemoveItem(item.uid, 1)
	doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	end
	if(getPlayerLevel(cid) <= 1200 and getPlayerLevel(cid) > 500) then
	doSendMagicEffect(getPlayerPosition(cid), 30)
	doSendMagicEffect(getPlayerPosition(cid), 29)
	doPlayerAddLevel(cid, 20)
	doRemoveItem(item.uid, 1)
	doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	end
	if(getPlayerLevel(cid) > 1200) then
	doSendMagicEffect(getPlayerPosition(cid), 30)
	doSendMagicEffect(getPlayerPosition(cid), 29)
	doPlayerAddLevel(cid, 15)
	doRemoveItem(item.uid, 1)
	doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	end
	return true
end

 

[xavierek]

why u dont use elseif ?

 

[xavierek]

function onUse(cid, item, fromPosition, itemEx, toPosition)
	if(getPlayerLevel(cid) <= 200) then
		doSendMagicEffect(getPlayerPosition(cid), 30)
		doSendMagicEffect(getPlayerPosition(cid), 29)
		doPlayerAddLevel(cid, 50)
		doRemoveItem(item.uid, 1)
		doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	elseif(getPlayerLevel(cid) <= 300 and getPlayerLevel(cid) > 200) then
		doSendMagicEffect(getPlayerPosition(cid), 30)
		doSendMagicEffect(getPlayerPosition(cid), 29)
		doPlayerAddLevel(cid, 40)
		doRemoveItem(item.uid, 1)
		doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	elseif(getPlayerLevel(cid) <= 400 and getPlayerLevel(cid) > 300) then
		doSendMagicEffect(getPlayerPosition(cid), 30)
		doSendMagicEffect(getPlayerPosition(cid), 29)
		doPlayerAddLevel(cid, 30)
		doRemoveItem(item.uid, 1)
		doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	elseif(getPlayerLevel(cid) <= 500 and getPlayerLevel(cid) > 400) then
		doSendMagicEffect(getPlayerPosition(cid), 30)
		doSendMagicEffect(getPlayerPosition(cid), 29)
		doPlayerAddLevel(cid, 20)
		doRemoveItem(item.uid, 1)
		doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	elseif(getPlayerLevel(cid) <= 1200 and getPlayerLevel(cid) > 500) then
		doSendMagicEffect(getPlayerPosition(cid), 30)
		doSendMagicEffect(getPlayerPosition(cid), 29)
		doPlayerAddLevel(cid, 20)
		doRemoveItem(item.uid, 1)
		doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	elseif(getPlayerLevel(cid) > 1200) then
		doSendMagicEffect(getPlayerPosition(cid), 30)
		doSendMagicEffect(getPlayerPosition(cid), 29)
		doPlayerAddLevel(cid, 15)
		doRemoveItem(item.uid, 1)
		doCreatureSay(cid, "Congratulations! Level up!", TALKTYPE_ORANGE_1)
	end
	return true
end

rep++ plx

 

[Xleniz]

ooh XD thanks.

 

[dillon br]

Does it exist with the others skills? Like Magic Shield Sword etc? Thanks! Peace out.

 

[Cykotitan]

change getPlayerLevel to getPlayerMagLevel, and doPlayerAddLevel to doPlayerAddMagLevel ?