TFS 1.X+ fit code

[Jpstafe]

Have updated my server to the latest tfs commits, now i want to add ping for otcv8 but it giving me error, i think i need to adapt part of the code

void ProtocolGame::parseNewPing(NetworkMessage& msg)
{
    uint32_t pingId = msg.get<uint32_t>();
    uint16_t localPing = msg.get<uint16_t>();
    uint16_t fps = msg.get<uint16_t>();

    
    addGameTask(&Game::playerReceiveNewPing, player->getID(), localPing, fps);
    g_dispatcher.addTask(createTask(std::bind(&ProtocolGame::sendNewPing, getThis(), pingId)));
}

can somebody help me?

quests.cpp
1>C:\Users\jpstafe\Documents\GitHub\pro-ot\src\protocolgame.cpp(2423,74): error C2672: 'ProtocolGame::addGameTask': no matching overloaded function found
1>C:\Users\jpstafe\Documents\GitHub\pro-ot\src\protocolgame.h(338,8): message : could be 'void ProtocolGame::addGameTask(Callable &&)' (compiling source file ..\src\protocolgame.cpp)
1>C:\Users\jpstafe\Documents\GitHub\pro-ot\src\protocolgame.cpp(2423,2): message : 'void ProtocolGame::addGameTask(Callable &&)': expects 1 arguments - 4 provided
1>C:\Users\jpstafe\Documents\GitHub\pro-ot\src\protocolgame.h(338): message : see declaration of 'ProtocolGame::addGameTask'
1>raids.cpp
1>rsa.cpp
1>scheduler.cpp

 

[Jpstafe]

up

 

[lursky]

Latest tfs-master uses lambdas instead but your code calls already removed helpers:

        // Helpers so we don't need to bind every time
        template <typename Callable, typename... Args>
        void addGameTask(Callable&& function, Args&&... args) {
            g_dispatcher.addTask(createTask(std::bind(std::forward<Callable>(function), &g_game, std::forward<Args>(args)...)));
        }

        template <typename Callable, typename... Args>
        void addGameTaskTimed(uint32_t delay, Callable&& function, Args&&... args) {
            g_dispatcher.addTask(createTask(delay, std::bind(std::forward<Callable>(function), &g_game, std::forward<Args>(args)...)));
        }

These are 2 main changes you should see:
1. Allow to pass lambdas into addGameTask

Replace std::bind with lambdas (#4017) · otland/forgottenserver@92b35aa

A free and open-source MMORPG server emulator written in C++ - Replace std::bind with lambdas (#4017) · otland/forgottenserver@92b35aa

github.com

2. Replace addGameTask with g_dispatcher.addTask(TaskFunc&& f)

Allow addTask to receive a task function as param (#4184) · otland/forgottenserver@7243e90

A free and open-source MMORPG server emulator written in C++ - Allow addTask to receive a task function as param (#4184) · otland/forgottenserver@7243e90

github.com

 

[Jpstafe]

yeah solved it. but end up dropping it all because outfits mounts and change colors where not working properly in this updated server :/

 

[Jpstafe]

Up i have fixed things but im already trying to convert old code to the new one. also added both commits

addGameTask(&Game::playerReceiveNewPing, player->getID(), localPing, fps);

i did this

([playerID = player->getID()]() { g_game.playerReceiveNewPing(playerID, localPing, fps); });

but still with problem, please help
solved

addGameTask([=, playerID = player->getID()]() { g_game.playerReceiveNewPing(playerID,localPing, fps); });