C++ Fixing roof jump destination

[Tinkz]

Hello, I'm using TFS 1.2 and having an issue with the look destination while jumping up on a roof on the east side.
While going up the character should face west, and while going down he should face east. Imgur: The magic of the Internet

The south side is correct and looks like this. Imgur: The magic of the Internet

 

[BahamutxD]

I'm using TFS 1.2 and dont have this issue or cannot replicate.

 

[Tinkz]

Updating main post because I saw that the gifs were gone.

bump

 

[Linxsis]

You should post this on github or where ever you downloaded the sources from so they are aware of the problem and can update the code.

 

[Okke]

Hello Tinkz,

look for "floorChange" on tile.cpp and check if the Position.x and Position.y are right (++, --).

Kindest Regards,
Okke

 

[tokenzz]

pretty sure i made a pr some time ago fixing this in tfs 1.2.

compare with master
forgottenserver/game.cpp at fa61fbf51f68b8a6d00b919b90d23243256e6594 · otland/forgottenserver · GitHub

 

[president vankk]

pretty sure i made a pr some time ago fixing this in tfs 1.2.

Fix direction when changing floors by t0kenz · Pull Request #2113 · otland/forgottenserver · GitHub

 

[Tinkz]

Fix direction when changing floors by t0kenz · Pull Request #2113 · otland/forgottenserver · GitHub

Thank you all for your help. I tried to change the code to look like yours. But still nothing happend.

This is how my code looks like right now.

ReturnValue Game::internalMoveCreature(Creature* creature, Direction direction, uint32_t flags /*= 0*/)
{
    creature->setLastPosition(creature->getPosition());
    const Position& currentPos = creature->getPosition();
    Position destPos = getNextPosition(direction, currentPos);
    Player* player = creature->getPlayer();
  
    bool diagonalMovement = (direction & DIRECTION_DIAGONAL_MASK) != 0;
    if (player && !diagonalMovement) {
        //try go up
        if (currentPos.z != 8 && creature->getTile()->hasHeight(3)) {
            Tile* tmpTile = map.getTile(currentPos.x, currentPos.y, currentPos.getZ() - 1);
            if (tmpTile == nullptr || (tmpTile->getGround() == nullptr && !tmpTile->hasFlag(TILESTATE_BLOCKSOLID))) {
                tmpTile = map.getTile(destPos.x, destPos.y, destPos.getZ() - 1);
                if (tmpTile && tmpTile->getGround() && !tmpTile->hasFlag(TILESTATE_BLOCKSOLID)) {
                    player->setDirection(direction);
                    destPos.z--;
                    internalCreatureTurn(creature, DIRECTION_NORTH);
                }
            }
        } else {
            //try go down
            Tile* tmpTile = map.getTile(destPos.x, destPos.y, destPos.z);
            if (currentPos.z != 7 && (tmpTile == nullptr || (tmpTile->getGround() == nullptr && !tmpTile->hasFlag(TILESTATE_BLOCKSOLID)))) {
                tmpTile = map.getTile(destPos.x, destPos.y, destPos.z + 1);
                if (tmpTile && tmpTile->hasHeight(3)) {
                    player->setDirection(direction);
                    destPos.z++;
                    internalCreatureTurn(creature, DIRECTION_SOUTH);
                }
            }
        }
    }

 

[Peonso]

Remove lines 18 and 29

 

[Tinkz]

Remove lines 18 and 29

Worked, Thank you!