Forever Aol Doesnt work

[GOD Wille]

Hello otland , this is my forever aol script but it doesnt work.

When a player dies the aol removes.

function onPrepareDeath(cid, lastHitKiller, mostDamageKiller)
        if (getPlayerSlotItem(cid, CONST_SLOT_NECKLACE).itemid == 2138) then 
                doSendMagicEffect(getCreaturePosition(cid), CONST_ME_HOLYAREA)
                doCreatureSay(cid, "Forever Amulet!", TALKTYPE_ORANGE_1)
        end
        return true
        end

<event type="preparedeath" name="Forever Aol" event="script" value="Forever Aol.lua"/>

login.lua

registerCreatureEvent(cid, "Forever Amulet")

Im using tfs 0.4 r3777

 

[Korrex]

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Enchanted Amulet of Loss" version="1.0" author="--" contact="--" enabled="yes">
        <description><![CDATA[
                This will protect your belongings even when you have a black skull!
        ]]></description>

        <item id="2196" article="a" name="Enchanted Amulet of Loss" override="yes"/>

        <event type="login" name="RedSkullAmulet_Login" event="buffer"><![CDATA[
                registerCreatureEvent(cid, "RedSkullAmulet_Login")
        ]]></event>

        <event type="death" name="RedSkullAmulet_Login" event="script"><![CDATA[
                function onDeath(cid, corpse, deathList)
                        if (getPlayerSlotItem(cid, CONST_SLOT_NECKLACE).itemid == 2196) then
                                if (getCreatureSkullType(cid) == SKULL_RED) then
                                        doCreatureSetDropLoot(cid, false)
                                elseif (getCreatureSkullType(cid) == SKULL_BLACK) then
                                        doCreatureSetDropLoot(cid, false)
                                end
                        end
                        return true
                end
        ]]></event>
</mod>

That's my script, tested and works properly in 0.3.6pl1 so it should work on 0.4.

 

[Wymietek]

LOL

if isInarray({SKULL_RED, SKULL_BLACK}, getCreatureSkullType(cid)) then
    doCreatureSetDropLoot(cid, false)
end

not better?

 

[Korrex]

LOL

if isInarray({SKULL_RED, SKULL_BLACK}, getCreatureSkullType(cid)) then
    doCreatureSetDropLoot(cid, false)
end

not better?

well I tried "or" and that didn't work so to save myself errors and the trouble I simply made an 'elseif' argument.

 

[Wymietek]

or will work in that case:

if (getCreatureSkullType(cid) == SKULL_RED) or (getCreatureSkullType(cid) == SKULL_BLACK) then
    doCreatureSetDropLoot(cid, false)
end

but that up is more cute

 

[GOD Wille]

Still not working, i loose aol

i have
<attribute key="charges" value="1" />
<attribute key="preventDrop" value="1" />

 

[Korrex]

Still not working, i loose aol

i have
<attribute key="charges" value="1" />
<attribute key="preventDrop" value="1" />

Obvious problem is obvious. Remove charges perhaps?

 

[GOD Wille]

ok i'll test. even though i think i tested ur script before but didnt work without charges

 

[SpiderOT]

try this

function onPrepareDeath(cid, lastHitKiller, mostDamageKiller)
local amulet = getPlayerSlotItem(cid, CONST_SLOT_NECKLACE)
	if (getPlayerSlotItem(cid, CONST_SLOT_NECKLACE).itemid == 2138) then 
		doSendMagicEffect(getCreaturePosition(cid), CONST_ME_HOLYAREA)
		doCreatureSay(cid, "Forever Amulet!", TALKTYPE_ORANGE_1)
		if amulet.type <= 2 then
		doChangeTypeItem(amulet.uid, amulet.type+1)   
		end
	end
return true
end

 

[induce]

Edit: Supposedly this doesn't work because the limit for xml files is 99, I'll have to test it.

 

[GOD Wille]

no this don't work since max is 99 in xml

Setting the charges to 0 didn't work for me either, just set it ridiculously high. I used "9999999999999" lol. Now it doesn't break and no one is going to die 9 trillion times.

For you lazy people:

<item id="2196" article="a" name="amulet of never-ending loss">
<attribute key="weight" value="420" />
<attribute key="slotType" value="necklace" />
<attribute key="preventDrop" value="1"/>
<attribute key="charges" value="9999999999999"/>
</item>

Rep if this helped please.

 

[Korrex]

no this don't work since max is 99 in xml

Where does it say that? I tried googling XML restrictions without result.

 

[GOD Wille]

everyone have told me that and i think i've tried also

 

[Korrex]

everyone have told me that and i think i've tried also

Oh well, i'll redirect you to this page.
http://otland.net/f16/aol-forever-problem-138169/index3.html#post1331141

 

[Snavy]

Dont work.!!!