Fragsystem is bugged,

[ugurdrahs]

Hi,

my fragsystem is bugged,
people get faster redskull than it have to be.

talkactions -->frags.lua

local config = {
	useFragHandler = getBooleanFromString(getConfigValue('useFragHandler')),
	advancedFragList = getBooleanFromString(getConfigValue('advancedFragList'))
}

function onSay(cid, words, param, channel)
	if(not config.useFragHandler) then
		return false
	end

	local time = os.time()
	local times = {today = (time - 10800), week = (time - (7 * 10800))}

	local contents, result = {day = {}, week = {}, month = {}}, db.getResult("SELECT `pd`.`date`, `pd`.`level`, `p`.`name` FROM `player_killers` pk LEFT JOIN `killers` k ON `pk`.`kill_id` = `k`.`id` LEFT JOIN `player_deaths` pd ON `k`.`death_id` = `pd`.`id` LEFT JOIN `players` p ON `pd`.`player_id` = `p`.`id` WHERE `pk`.`player_id` = " .. getPlayerGUID(cid) .. " AND `k`.`unjustified` = 1 AND `pd`.`date` >= " .. (time - (30 * 86400)) .. " ORDER BY `pd`.`date` DESC")
	if(result:getID() ~= -1) then
		repeat
			local content = {
				name = result:getDataString("name"),
				level = result:getDataInt("level"),
				date = result:getDataInt("date")
			}
			if(content.date > times.today) then
				table.insert(contents.day, content)
			elseif(content.date > times.week) then
				table.insert(contents.week, content)
			else
				table.insert(contents.month, content)
			end
		until not result:next()
		result:free()
	end

	local size = {
		day = table.maxn(contents.day),
		week = table.maxn(contents.week),
		month = table.maxn(contents.month)
	}
	if(config.advancedFragList) then
		local result = "Frags gained today: " .. size.day .. "."
		if(size.day > 0) then
			for _, content in ipairs(contents.day) do
				result = result .. "\n* " .. os.date("%d %B %Y %X at ", content.date) .. content.name .. " on level " .. content.level
			end

			result = result .. "\n"
		end

		result = result .. "\nFrags gained this week: " .. (size.day + size.week) .. "."
		if(size.week > 0) then
			for _, content in ipairs(contents.week) do
				result = result .. "\n* " .. os.date("%d %B %Y %X at ", content.date) .. content.name .. " on level " .. content.level
			end

			result = result .. "\n"
		end

		result = result .. "\nFrags gained this month: " .. (size.day + size.week + size.month) .. "."
		if(size.month > 0) then
			for _, content in ipairs(contents.month) do
				result = result .. "\n* " .. os.date("%d %B %Y %X at ", content.date) .. content.name .. " on level " .. content.level
			end

			result = result .. "\n"
		end

		local skullEnd = getPlayerSkullEnd(cid)
		if(skullEnd > 0) then
			result = result .. "\nYour " .. (getCreatureSkullType(cid) == SKULL_RED and "red" or "black") .. " skull will expire at " .. os.date("%d %B %Y %X", skullEnd)
		end

		doPlayerPopupFYI(cid, result)
	else
		doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, "You currently have " .. size.day .. " frags today, " .. (size.day + size.week) .. " this week and " .. (size.day + size.week + size.month) .. " this month.")
		if(size.day > 0) then
			doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, "Last frag at " .. os.date("%d %B %Y %X", contents.day[1].date) .. " on level " .. contents.day[1].level .. " (" .. contents.day[1].name .. ").")
		end

		local skullEnd = getPlayerSkullEnd(cid)
		if(skullEnd > 0) then
			doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, "Your " .. (getCreatureSkullType(cid) == SKULL_RED and "red" or "black") .. " skull will expire at " .. os.date("%d %B %Y %X", skullEnd))
		end
	end

	return true
end

Any PROBlems with !frags?

 

[ugurdrahs]

someone?

 

[Linken93]

How fast are they getting red skull?

 

[ugurdrahs]

How fast are they getting red skull?

umm lets say,

dailyfragstoRS= 10 frags
weeklyfragstoRS=60 frags
monthlyfragstoRS=130 frags

they already get at 6 frags REDSKull
OR other example; 33 frags at week= redskull

it happend much time

 

[Linken93]

I don't know exactly but this can be found in both frags.lua and player.cpp

local times = {today = (time - 84600), week = (time - (7 * 84600))}

 

[Red]

I don't know exactly but this can be found in both frags.lua and player.cpp

local times = {today = (time - 84600), week = (time - (7 * 84600))}

Linken93, you're correct.
Changing these variables in player.cpp allow you to determine how long a "day" is, and how long a "week" is. Therefore, you'll be able to change how long frags last by doing this.
the .lua file in talkactions is simply a display for players. You should make it match the .cpp file.

Red

 

[ugurdrahs]

Linken93, you're correct.
Changing these variables in player.cpp allow you to determine how long a "day" is, and how long a "week" is. Therefore, you'll be able to change how long frags last by doing this.
the .lua file in talkactions is simply a display for players. You should make it match the .cpp file.

Red

Player.cpp: player.cpp - Pastebin.com


ummm, so I need to change the player.cpp?

what will happen when its changed?
it will work good?

 

[Linken93]

If you are changing this one.

local times = {today = (time - 84600), week = (time - (7 * 84600))}

To this , The frags will disappear after 3 hours and not 23h 30 minutes.

local times = {today = (time - 10800), week = (time - (7 * 10800))}

 

[Cykotitan]

isn't 84600 a typo? i believe it was fixed later

week = (time - (7 * 10800))

and that's 21 hour (for weekly frags to expire).

 

[Linken93]

isn't 84600 a typo? i believe it was fixed later

and that's 21 hour (for weekly frags to expire).

I don't know exactly, Saw this in some threads yesterday so Haven't tested this out myself yet.

 

[AchTung]

Dont even try to help. Again a ethania problem

 

[Lanceq2]

What rev u using ?

 

[ugurdrahs]

What rev u using ?

rev 3858

 

[ugurdrahs]

If you are changing this one.

local times = {today = (time - 84600), week = (time - (7 * 84600))}

To this , The frags will disappear after 3 hours and not 23h 30 minutes.

local times = {today = (time - 10800), week = (time - (7 * 10800))}

do I need to change this on player.cpp?

 

[ugurdrahs]

so I need to use -->local times = {today = (time - 84600), week = (time - (7 * 84600))}


on frags.php /talkactions


and also on player.cpp?

 

[Ninja]

yes

 

[ugurdrahs]

Linken93, you're correct.
Changing these variables in player.cpp allow you to determine how long a "day" is, and how long a "week" is. Therefore, you'll be able to change how long frags last by doing this.
the .lua file in talkactions is simply a display for players. You should make it match the .cpp file.

Red

but where is month ?

 

[ugurdrahs]

someone?