Solved Function onDeath add storagevalue

[Shackal]

Hello guys,

I'm using Dev 0.4
I wonder what's wrong in my script:

local c = {
    storage = 1889,
    storageValueToCheckFor = 31
}

function onDeath(cid, corpse, killer)
    if getPlayerStorageValue(killer, c.storage) == c.storageValueToCheckFor then
        setPlayerStorageValue(killer, c.storage, c.storageValueToCheckFor + 1)
    end
end

In my distro, returns the following error:

[Error - CreatureScript Interface]
data/creaturescripts/inq/ungreez.lua:onDeath
Description:
(luaGetCreatureStorage) Creature not found

But if already I configured an event in monster/Ungreez.lua, why not find?

Thank you in advance!

 

[DestinationSer]

What is your script supposed to do? Is it supposed to work for a specific monster, or for players or what?

 

[Shackal]

The script is to run as follows:
When a player kill Ungreez, your Storage goes from x to y

 

[Shackal]

Storage for your update, requires the player has the X Storage

 

[DestinationSer]

The script is to run as follows:
When a player kill Ungreez, your Storage goes from x to y

Then your script is wrong, it should be a onKill script

function onKill(cid, target, lastHit)
local c = {
storage = 1889,
storageValueToCheckFor = 31
}
local monster = 'ungreez'
    if getCreatureName(target):lower() == monster:lower() then
if getPlayerStorageValue(killer, c.storage) == c.storageValueToCheckFor then
setPlayerStorageValue(killer, c.storage, c.storageValueToCheckFor + 1)
    end
end
    return true
end

Inside creaturescripts.xml and login.lua make sure ungreez is spelled the same way as the monster is.

 

[Shackal]

now returns this error:

[Warning - Monster::Monster] Unknown event name - UngreezDead

 

[DestinationSer]

now returns this error:

[Warning - Monster::Monster] Unknown event name - UngreezDead

Post your creaturescripts.xml line

This is how it should be
<event type="kill" name="ungreez" event="script" value="ungreez.lua"/>


Login lua
registerCreatureEvent(cid, "ungreez")

 

[Shackal]

friend, no error but does not work:
Recalling that use the dev version 0.4


-- monster/ungreez.xml

<script>
                <event name="ungreez"/>
</script>

-- login.lua

registerCreatureEvent(cid, "ungreez")

-- creaturescript.xml

<event type="kill" name="ungreez" event="script" value="ungreez.lua"/>

-- creaturescript/scripts/inq/ungreez.lua

function onKill(cid, target, lastHit)
      local c = {
            storage = 1889,
            storageValueToCheckFor = 31
}
      local monster = 'ungreez'
            if getCreatureName(target):lower() == monster:lower() then
                     if getPlayerStorageValue(killer, c.storage) == c.storageValueToCheckFor then
                              setPlayerStorageValue(killer, c.storage, c.storageValueToCheckFor + 1)
                     end
            end
    return true
end

 

[DestinationSer]

Restart your server and try.

 

[Shackal]

i try and:

 

[DestinationSer]

Change getPlayerStorageValue to getCreatureStorage

 

[Shackal]

function onKill(cid, target, lastHit)
local c = {
storage = 1889,
storageValueToCheckFor = 19
}
local monster = 'ungreez'
    if getCreatureName(target):lower() == monster:lower() then
        if getCreatureStorageValue(killer, c.storage) == c.storageValueToCheckFor then
            setPlayerStorageValue(killer, c.storage, c.storageValueToCheckFor + 1)
        end
    end
    return true
end

This bug now:

and distro:

 

[Ahilphino]

replace killer with cid

 

[Shadowsong]

Try this:

function onKill(cid, target, lastHit)
local c = {
storage = 1889,
storageValueToCheckFor = 19
}
local monster = "ungreez"
if string.lower(getCreatureName(target)) == string.lower(monster) then
if getPlayerStorageValue(cid, c.storage) == c.storageValueToCheckFor then
setPlayerStorageValue(cid, c.storage, c.storageValueToCheckFor + 1)
end
end
return true
end

 

[Shackal]

Nothing

 

[owned]

Nothing

function onKill(cid, target)
    if string.lower(getCreatureName(target) == string.lower("ungreez") then
        if getCreatureStorage(cid, 1889) == 19 then
            doCreatureSetStorage(cid, 1889, 20)
        end
    end
return true
end

There's zero reason this should not work. If it does not, that means you either haven't registered things correctly, or you just need to restart your server.

 

[WibbenZ]

How many ppl does it take to write a simple script lol?

Since you diden't write what tfs you are using I suppose its 1.0?

local monsters = {
    ["demon"] = 23522
}

function onKill(creature, target)
    local targetMonster = target:getMonster()
    if(not targetMonster) then
        return true
    end
   
    local monster = monsters[targetMonster:getName():lower()]
    if(not monster) then
        return true
    end
   
    for pid, _ in pairs(targetMonster:getDamageMap()) do
        local attackerPlayer = Player(pid)
        if(attackerPlayer) then
            if(attackerPlayer:getStorageValue(monster) == 31) then
                attackerPlayer:setStorageValue(monster, attackerPlayer:getStorageValue(monster) + 1)
            end
        end
    end
end

 

[Shackal]

Tfs 0.4 bro..
im will try ur code

 

[owned]

How many ppl does it take to write a simple script lol?

Since you diden't write what tfs you are using I suppose its 1.0?

local monsters = {
    ["demon"] = 23522
}

function onKill(creature, target)
    local targetMonster = target:getMonster()
    if(not targetMonster) then
        return true
    end
  
    local monster = monsters[targetMonster:getName():lower()]
    if(not monster) then
        return true
    end
  
    for pid, _ in pairs(targetMonster:getDamageMap()) do
        local attackerPlayer = Player(pid)
        if(attackerPlayer) then
            if(attackerPlayer:getStorageValue(monster) == 31) then
                attackerPlayer:setStorageValue(monster, attackerPlayer:getStorageValue(monster) + 1)
            end
        end
    end
end

He stated the that the version was 0.4 and I solved his problem.

 

[Ahilphino]

How many ppl does it take to write a simple script lol?

Since you diden't write what tfs you are using I suppose its 1.0?

local monsters = {
    ["demon"] = 23522
}

function onKill(creature, target)
    local targetMonster = target:getMonster()
    if(not targetMonster) then
        return true
    end
  
    local monster = monsters[targetMonster:getName():lower()]
    if(not monster) then
        return true
    end
  
    for pid, _ in pairs(targetMonster:getDamageMap()) do
        local attackerPlayer = Player(pid)
        if(attackerPlayer) then
            if(attackerPlayer:getStorageValue(monster) == 31) then
                attackerPlayer:setStorageValue(monster, attackerPlayer:getStorageValue(monster) + 1)
            end
        end
    end
end

nice u wrote this? xD https://github.com/PrinterLUA/FORGO...scripts/quests/bigfoot burden/WarzoneKill.lua

also by looking at his script you can clearly see it's for 0.4