Get Killer

[bomba]

How to get the killer?
Look the script:

function onDeath(cid, corpse, deathList)
    local drop, nDrop = doCreatureSetDropLoot(cid, true), doCreatureSetDropLoot(cid, false)
    local killer = ?????????
    if getPlayerLevel(cid) <= 50 then
        if isMonster(killer) == true then
            nDrop
        else
            drop
        end
    else
        local item_amuletOfLoss, slot = 2173, getPlayerSlotItem(cid, CONST_SLOT_NECKLACE)
        if slot == item_amuletOfLoss.itemid then
            doPlayerRemoveItem(cid, slot, 1)
            nDrop
        else
            drop
        end
    end
    return true
end

 

[LordVissie]

You mean just get if the killer is a player?

You should include server version tho.

 

[Codex NG]

deathList is a table the hint is in the word list

 

[bomba]

Like this?

if isMonster(getKillerType(deathList)) == true then

 

[Codex NG]

You have to iterate over the table.

 

[Roddet]

F.e

-- this will check the entire list
for _, list in pairs (deathList) do
   if isMonster(list) then
      nDrop
   end
end

-- this will check only the last hit
   if isMonster(deathList[1]) then
      nDrop
   end

 

[StreamSide]

you can always use print to check what u want

 

[bomba]

function onDeath(cid, corpse, deathList)
    local drop, nDrop = doCreatureSetDropLoot(cid, true), doCreatureSetDropLoot(cid, false)
    if getPlayerLevel(cid) <= 50 then
        for _, list in pairs (deathList) do
            if isMonster(list) then
                nDrop
            end
        end
    else
        local item_amuletOfLoss, slot = 2173, getPlayerSlotItem(cid, CONST_SLOT_NECKLACE)
        if slot == item_amuletOfLoss.itemid then
            doPlayerRemoveItem(cid, slot.itemid, 1)
            nDrop
        else
            drop
        end
    end
    return true
end

 

[Codex NG]

Basic rules of most languages, the thing on the right is always assigned to the thing on the left.

Also you can't assign something a value and then place in a script, you need to do something with it, drop and nDrop are just variables, they aren't functions.

The solution is staring at you right in your face.

 

[Mkalo]

function onDeath(cid, corpse, deathList)
    local drop, nDrop = doCreatureSetDropLoot(cid, true), doCreatureSetDropLoot(cid, false)
    if getPlayerLevel(cid) <= 50 then
        for _, list in pairs (deathList) do
            if isMonster(list) then
                nDrop
            end
        end
    else
        local item_amuletOfLoss, slot = 2173, getPlayerSlotItem(cid, CONST_SLOT_NECKLACE)
        if slot == item_amuletOfLoss.itemid then
            doPlayerRemoveItem(cid, slot.itemid, 1)
            nDrop
        else
            drop
        end
    end
    return true
end

If you really that to look like this:

function onDeath(cid, corpse, deathList)
    local drop, nDrop = function() doCreatureSetDropLoot(cid, true) end, function() doCreatureSetDropLoot(cid, false) end
    if getPlayerLevel(cid) <= 50 then
        for _, list in pairs (deathList) do
            if isMonster(list) then
                nDrop()
            end
        end
    else
        local item_amuletOfLoss, slot = 2173, getPlayerSlotItem(cid, CONST_SLOT_NECKLACE)
        if slot == item_amuletOfLoss.itemid then
            doPlayerRemoveItem(cid, slot.itemid, 1)
            nDrop()
        else
            drop()
        end
    end
    return true
end

But that is shitty just change the functions to doCreatureSetDropLoot(cid, true/false), false where you have nDrop and true where you have drop.

 

[bomba]

Solved!