getStorageValue inside setStorageValue dosent work

[OTAmator]

Hi, why if i use getStorageValue inside setStorageValue then it dosent work correcly. In database like 4294967295 (in console it just returns -1)

dosent work:

player:setStorageValue(player:getStorageValue(taskSys.storages.currentTask), taskSys.status.completed)

this code works properly:

local playerCurrentTaskStorage = player:getStorageValue(taskSys.storages.currentTask)
local playerActiveTask = taskSys:getPlayerActiveTaskDataByHisCurrentTaskStorage(playerCurrentTaskStorage)
player:setStorageValue(playerActiveTask.storage, taskSys.status.completed)

 

[StreamSide]

0xFFFFFFFF
seems like you using the max int32 value, try with 4294967294

 

[OTAmator]

@StreamSide I dont undersand u

Im wondering why this "player:getStorageValue(taskSys.storages.currentTask)" returns "-1" (in db "4294967295") if i see this storage in db has value "17524"

 

[StreamSide]

? I just said it, try with 4294967294.

 

[OTAmator]

@StreamSide
Value "4294967295" is not mine i didnt set it. It is from memory or idk

 

[StreamSide]

ohhh now I understand
can you add some debug stuff like printing player storage value of taskSys.storages.currentTask

 

[OTAmator]

@StreamSide
currentTask = 176601 - storage key in database and storage value is 17524

 

[StreamSide]

seems like player:getStorageValue(taskSys.storages.currentTask) is returning -1

 

[River KA]

Hi, why if i use getStorageValue inside setStorageValue then it dosent work correcly. In database like 4294967295 (in console it just returns -1)

dosent work:

player:setStorageValue(player:getStorageValue(taskSys.storages.currentTask), taskSys.status.completed)

View attachment 80463

this code works properly:

local playerCurrentTaskStorage = player:getStorageValue(taskSys.storages.currentTask)
local playerActiveTask = taskSys:getPlayerActiveTaskDataByHisCurrentTaskStorage(playerCurrentTaskStorage)
player:setStorageValue(playerActiveTask.storage, taskSys.status.completed)

View attachment 80464

Wrong:

player:setStorageValue(player:getStorageValue(taskSys.storages.currentTask), taskSys.status.completed)

Correct:

player:setStorageValue(taskSys.storages.currentTask, taskSys.status.completed)

First parameter of setStorageValue after player is the storage id, not value.

 

[Fjorda]

Hi, why if i use getStorageValue inside setStorageValue then it dosent work correcly. In database like 4294967295 (in console it just returns -1)

dosent work:

player:setStorageValue(player:getStorageValue(taskSys.storages.currentTask), taskSys.status.completed)

View attachment 80463

this code works properly:

local playerCurrentTaskStorage = player:getStorageValue(taskSys.storages.currentTask)
local playerActiveTask = taskSys:getPlayerActiveTaskDataByHisCurrentTaskStorage(playerCurrentTaskStorage)
player:setStorageValue(playerActiveTask.storage, taskSys.status.completed)

View attachment 80464

You shouldn't really store a storage key as a value of another key.

It just becomes confusing when someone else comes across your code.
You should store all of your keys somewhere for reference.
In TFS, this is usually, lib/miscellaneous/051-storages.lua

 

[OTAmator]

@Fjorda
I have this thing where each task has its own unique storage value. Additionally, the storage holds the storage value for the task that the player is currently doing. I probably shouldn't keep information about the storage value of the task that the player is currently doing in the lib.

 

[Fjorda]

@Fjorda
I have this thing where each task has its own unique storage value. Additionally, the storage holds the storage value for the task that the player is currently doing. I probably shouldn't keep information about the storage value of the task that the player is currently doing in the lib.

What you should have done is to use a base storage value. For example, lets say 25000.

Each task is then incremented, so the first task would be 25001, and then 25002 so on.... To store the current task, you could use storage key 24999, and a value that holds the task index. i.e a value of 25, would be task storage 25000 + 25.