Lua getThingFromPos - a joke.

[sestorme]

local combat = createCombatObject()

function onTargetTile(cid, pos)
local target = getThingFromPos({x=pos.x, y=pos.y, z=pos.z, stackpos=254})
local dur = 0.25 + ((0.25 * getPlayerStorageValue(cid, 1002)) * getCreatureStorage(target.uid, 2000))
doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, "".. dur .."")
end

setCombatCallback(combat, CALLBACK_PARAM_TARGETTILE, "onTargetTile")

function onCastSpell(cid, var)
return doCombat(cid, combat, var)
end

Simply:

[27/01/2013 18:06:17] [Error - Spell Interface]
[27/01/2013 18:06:17] In a callback: data/spells/scripts/attack/stone shower.luanTargetTile
[27/01/2013 18:06:17] (Unknown script file)
[27/01/2013 18:06:17] Description:
[27/01/2013 18:06:17] (luaGetCreatureStorage) Creature not found

[27/01/2013 18:06:17] [Error - Spell Interface]
[27/01/2013 18:06:17] In a callback: data/spells/scripts/attack/stone shower.luanTargetTile
[27/01/2013 18:06:17] (Unknown script file)
[27/01/2013 18:06:17] Description:
[27/01/2013 18:06:17] data/spells/scripts/attack/stone shower.lua:21: attempt to perform arithmetic on a boolean value
[27/01/2013 18:06:17] stack traceback:
[27/01/2013 18:06:17] data/spells/scripts/attack/stone shower.lua:21: in function <data/spells/scripts/attack/stone shower.lua:18>
[27/01/2013 18:06:17] [C]: in function 'doCombat'
[27/01/2013 18:06:17] data/spells/scripts/attack/stone shower.lua:28: in function <data/spells/scripts/attack/stone shower.lua:27>

It's a rune that requires target, so apparently it is there, but for some reason script can't return it. What's wrong?

 

[Programmer]

Is that the script? It seems like it wants to go to line 27 and 28 but.. there's only 13 lines in that script.

 

[Cornex]

It cant be the whole script ;o

 

[sestorme]

There's something on the top of it which is not associated. If there's something wrong it's overhere.

 

[Cronox]

made by is why have "" ...dur... "" <- i remember only are " not ""
try

local combat = createCombatObject()

function onTargetTile(cid, pos)
local target = getThingFromPos({x=pos.x, y=pos.y, z=pos.z, stackpos=254})
local dur = 0.25 + ((0.25 * getPlayerStorageValue(cid, 1002)) * getCreatureStorage(target.uid, 2000))
doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, " .. dur .. ")

end

setCombatCallback(combat, CALLBACK_PARAM_TARGETTILE, "onTargetTile")

function onCastSpell(cid, var)
return doCombat(cid, combat, var)
end

 

[Darkhaos]

local combat = createCombatObject()
 
function onTargetTile(cid, pos)
local target = getThingFromPos({x=pos.x, y=pos.y, z=pos.z, stackpos=254})
local dur = 0.25 + ((0.25 * getPlayerStorageValue(cid, 1002)) * getCreatureStorage(target.uid, 2000))
doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, dur)
 
end
 
setCombatCallback(combat, CALLBACK_PARAM_TARGETTILE, "onTargetTile")
 
function onCastSpell(cid, var)
return doCombat(cid, combat, var)
end

 

[Summ]

This is exactly what you should prevent in scripting.
You cannot expect a creature to be existing at a certain position and create the script just like it is a given fact that it is there.

When you get the thing from stackpos 254 there might be nothing, so make sure to check whether target.uid > 0 and isCreature(target.uid) first before you proceed.

 

[sestorme]

But it's a rune that needs target, for that reason creature is right there. Thanks. Sorted.

 

[Summ]

If it is a stone shower rune it has an area and onTargetTile will be executed for every tile..

 

[sestorme]

It's a custom spell and it was quite crucial for me to detect the exact location and exact target of such spell.

 

[Summ]

stackpos 253 should be creature