/Ghost be seen by party

[Swiftxd]

hello, have some way to who uses /ghost talkaction can be seen by party members too ?
i think its in player.cpp in this function: bool Player::canSeeCreature(const Creature* creature) const, but i failed to create. the closest i got is this :

bool Player::canSeeCreature(const Creature* creature) const
{
if(creature == this)
return true;
if(const Player* player = creature->getPlayer())
return !player->isGhost() || (getAccess() > 2 && getGhostAccess() >= player->getGhostAccess());
return !creature->isInvisible() || canSeeInvisibility();
if(party)
party->isPlayerMember(const Player*)
return !creature->isInvisible() || canSeeInvisibility();
}

if someone could help me ,i'll be glad

 

[Marcelo Druida]

it isnt tfs 1.x?
i'd help so

 

[Swiftxd]

https://github.com/mattyx14/otxserver/tree/otxserv2/path_10_x

so, yes !

 

[Jano]

it sounds like you are using ghost twice, ghost -> invisible then ghost -> visible, I don't see another way to reproduce that behaviour using ghost only once, am I right? If that the case is easy fix, now if you are sure it happens only with using ghost once (to become invisible) then it needs a deeper look to find the bug.
Anyway party members number should make no difference.

 

[Swiftxd]

@Jano thanks for your help till now. Yes dude, i'm using twice, one to become stealth, other to become visible. And the prob is only in "disappear", when you use ghost->invisible. My guess is the problem is on talkaction, that send the "disappear", ill keep studying it

 

[Marcelo Druida]

post your

int LuaScriptInterface::luaPlayerSetGhostMode(lua_State* L)

the bug is there

 

[Swiftxd]

@Marcelo Druida but i dont have it on my luascript files. I just have

static int32_t luaGetPlayerGhostAccess(lua_State* L);

what made the player become inv is this :

void Game::internalCreatureChangeVisible(Creature* creature, Visible_t visible)

 

[Marcelo Druida]

if you dont have a lua function so you cant have a talkaction function.
show us your talkaction

 

[Swiftxd]

talkaction.cpp

    else if(m_functionName == "ghost")
        m_function = ghost;

bool TalkAction::ghost(Creature* creature, const std::string&, const std::string&)
{
    Player* player = creature->getPlayer();
    if(!player)
        return false;

    if(player->hasFlag(PlayerFlag_CannotBeSeen))
    {
        player->sendTextMessage(MSG_STATUS_CONSOLE_BLUE, "Command disabled for players with special, invisibility flag.");
        return true;
    }

    SpectatorVec::iterator it;
    SpectatorVec list = g_game.getSpectators(player->getPosition());
    Player* tmpPlayer = NULL;

    Condition* condition = NULL;
    if((condition = player->getCondition(CONDITION_GAMEMASTER, CONDITIONID_DEFAULT, GAMEMASTER_INVISIBLE)))
    {
        player->sendTextMessage(MSG_INFO_DESCR, "You are visible again.");
        for(AutoList<Player>::iterator pit = Player::autoList.begin(); pit != Player::autoList.end(); ++pit)
        {

        }

        for(it = list.begin(); it != list.end(); ++it)
        {
            if((tmpPlayer = (*it)->getPlayer()) && !tmpPlayer->canSeeCreature(player))
                tmpPlayer->sendMagicEffect(player->getPosition(), MAGIC_EFFECT_TELEPORT);
        }

        player->removeCondition(condition);
        g_game.internalCreatureChangeVisible(creature, VISIBLE_GHOST_APPEAR);
    }
    else if((condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_GAMEMASTER, -1, 0, false, GAMEMASTER_INVISIBLE)))
    {
        player->addCondition(condition);
        g_game.internalCreatureChangeVisible(creature, VISIBLE_GHOST_DISAPPEAR);
        for(it = list.begin(); it != list.end(); ++it)
        {
            if((tmpPlayer = (*it)->getPlayer()) && !tmpPlayer->canSeeCreature(player))
                tmpPlayer->sendMagicEffect(player->getPosition(), MAGIC_EFFECT_POFF);
        }

        for(AutoList<Player>::iterator pit = Player::autoList.begin(); pit != Player::autoList.end(); ++pit)
        {
        }

        if(player->isTrading())
            g_game.internalCloseTrade(player);

        player->sendTextMessage(MSG_INFO_DESCR, "You are now invisible.");
    }

    return true;
}

 

[Marcelo Druida]

Ok. So reset to default all modifications that you made before.

go to player.h and replace:

void sendCreatureChangeVisible(const Creature* creature, bool visible) {
...
}

to
http://hastebin.com/epokudilac.coffee

 

[Swiftxd]

it gives a LOT of errors to compile. I looked around, and i think we can do it easly here:

void Player::sendCreatureChangeVisible(const Creature* creature, Visible_t visible)

am i right ?

{
if(!client)
return;
const Player* player = creature->getPlayer();
if(player == this || (player && (visible < VISIBLE_GHOST_APPEAR || (getAccess() > 2 && getGhostAccess() >= player->getGhostAccess() || isPartner(player))))
|| (!player && canSeeInvisibility()))
sendCreatureChangeOutfit(creature, creature->getCurrentOutfit());

i didnt tested yet, but ispartner here could fix ?

 

[Marcelo Druida]

as I said... since its not tfs 1.x I'm not willing to give you much support
that being said I wont compile any codes, so I cant say that it works as i couldnt sent you a working code.
i would ask you for all these errors. In my point of view changing my previous code to

http://hastebin.com/hinumoneva.coffee

could works