!!!!H3LP!!!!! ;o

[Mozax]

Sup guyz!! i just started
to learn some stuff about scripts <_<
but im having a problem :blink:

Im trying to do a "fishing up monster script"
but i dont even know where to start
there is one already on the furum
but it doesnt work

everytime that i try to run the server i get this error

""[Error - LuaScriptInterface::loadFile] data/actions/scripts/tools/fishing.lua:41: 'end' expected (to close 'function' at line 1) near '<eof>'
[Warning - Event::loadScript] Cannot load script (data/actions/scripts/tools/fishing.lua)
data/actions/scripts/tools/fishing.lua:41: 'end' expected (to close 'function' at line 1) near '<eof>' ""

So if anyone could help me by giving me a script or trying to solve the problem i would appreciate....
:thumbup:

CHEERS PCE

 

[Xampy]

Post here the script please.

 

[Mozax]

function onUse(cid, item, fromPosition, itemEx, toPosition)
local config = {
waterIds = {493, 4608, 4609, 4610, 4611, 4612, 4613, 4614, 4615, 4616, 4617, 4618, 4619, 4620, 4621, 4622, 4623, 4624, 4625},
rateSkill = getConfigValue("rateSkill"),
allowFromPz = false,
useWorms = true
}

local monsters = {'Quara Hydromancer', 'Quara Constrictor', 'Quara Mantassin', 'Quara Pincher', 'Quara Predator', 'Serpent Spawn', 'Wyrm', 'Sea Serpent', 'Titan Goddess of Water'}

function onUse(cid, item, fromPosition, itemEx, toPosition)
if(not isInArray(config.waterIds, itemEx.itemid)) then
return false
end

if((config.allowFromPz or not getTileInfo(getCreaturePosition(cid)).protection) and itemEx.itemid ~= 493 and math.random(1, (100 + (getPlayerSkill(cid, SKILL_FISHING) / 10))) < getPlayerSkill(cid, SKILL_FISHING) and (not config.useWorms or (getPlayerItemCount(cid, ITEM_WORM) > 0 and doPlayerRemoveItem(cid, ITEM_WORM, 1)))) then
if getPlayerLevel(cid) >= 5000 and getPlayerSkillLevel(cid, SKILL_FISHING) >= 100 then
randsummon = math.random(0,9)
elseif getPlayerLevel(cid) >= 5000 then
randsummon = math.random(0,8)
elseif getPlayerLevel(cid) >= 3000 then
randsummon = math.random(0,6)
elseif getPlayerLevel(cid) >= 1500 then
randsummon = math.random(0,4)
elseif getPlayerLevel(cid) >= 500 then
randsummon = math.random(0,2)
else
doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
end

if randsummon == 0 then
doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
else
doSummonMonster(monsters[randsummon], getCreaturePosition(cid))
doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
end
end

doSendMagicEffect(toPosition, CONST_ME_LOSEENERGY)
return true
end

;///

 

[Niskafase]

function onUse(cid, item, fromPosition, itemEx, toPosition)
	local config = {
			waterIds = {493, 4608, 4609, 4610, 4611, 4612, 4613, 4614, 4615, 4616, 4617, 4618, 4619, 4620, 4621, 4622, 4623, 4624, 4625},
			rateSkill = getConfigValue("rateSkill"),
			allowFromPz = false,
			useWorms = true
			}

	local monsters = {'Quara Hydromancer', 'Quara Constrictor', 'Quara Mantassin', 'Quara Pincher', 'Quara Predator', 'Serpent Spawn', 'Wyrm', 'Sea Serpent', 'Titan Goddess of Water'}

	if(not isInArray(config.waterIds, itemEx.itemid)) then
		return false
	end

	if((config.allowFromPz or not getTileInfo(getCreaturePosition(cid)).protection) and itemEx.itemid ~= 493 and math.random(1, (100 + (getPlayerSkill(cid, SKILL_FISHING) / 10))) < getPlayerSkill(cid, SKILL_FISHING) and (not config.useWorms or (getPlayerItemCount(cid, ITEM_WORM) > 0 and doPlayerRemoveItem(cid, ITEM_WORM, 1)))) then
		if getPlayerLevel(cid) >= 5000 and getPlayerSkillLevel(cid, SKILL_FISHING) >= 100 then
			randsummon = math.random(0,9)
		elseif getPlayerLevel(cid) >= 5000 then
			randsummon = math.random(0,8)
		elseif getPlayerLevel(cid) >= 3000 then
			randsummon = math.random(0,6)
		elseif getPlayerLevel(cid) >= 1500 then
			randsummon = math.random(0,4)
		elseif getPlayerLevel(cid) >= 500 then
			randsummon = math.random(0,2)
		else
			doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
		end

		if randsummon == 0 then
			doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
		else
			doSummonMonster(monsters[randsummon], getCreaturePosition(cid))
			doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
		end
	end

doSendMagicEffect(toPosition, CONST_ME_LOSEENERGY)
return true
end

 

[Mozax]

dude thx no erros in the console but
lets say its too hard to catch one how would i make it easier
thx bro helped alot xD
i know i dont know much but if u need me just tell me xDDD

 

[Mozax]

damn
i just found this error ;/
[17/01/2010 16:06:14] [Error - Action Interface]
[17/01/2010 16:06:14] data/actions/scripts/tools/fishing.luanUse
[17/01/2010 16:06:14] Description:
[17/01/2010 16:06:14] (luaDoSummonMonster) Creature not found
help again ? ;/

 

[Xampy]

Because you don't have some of these monsters:

{'Quara Hydromancer', 'Quara Constrictor', 'Quara Mantassin', 'Quara Pincher', 'Quara Predator', 'Serpent Spawn', 'Wyrm', 'Sea Serpent', 'Titan Goddess of Water'}

Maybe you don't have the called monster Titan Goddess of Water.

 

[Mozax]

like i have done a new monster called Leviathan
and i have puted him in data/monster/laviathan.xml
but i still get the same error
it says it cannot found the monster

function onUse(cid, item, fromPosition, itemEx, toPosition)
local config = {
waterIds = {493, 4608, 4609, 4610, 4611, 4612, 4613, 4614, 4615, 4616, 4617, 4618, 4619, 4620, 4621, 4622, 4623, 4624, 4625},
rateSkill = getConfigValue("rateSkill"),
allowFromPz = false,
useWorms = true
}

local monsters = {'Leviathan'}

if(not isInArray(config.waterIds, itemEx.itemid)) then
return false
end

if((config.allowFromPz or not getTileInfo(getCreaturePosition(cid)).protection) and itemEx.itemid ~= 493 and math.random(1, (100 + (getPlayerSkill(cid, SKILL_FISHING) / 10))) < getPlayerSkill(cid, SKILL_FISHING) and (not config.useWorms or (getPlayerItemCount(cid, ITEM_WORM) > 0 and doPlayerRemoveItem(cid, ITEM_WORM, 1)))) then
if getPlayerLevel(cid) >= 5000 and getPlayerSkillLevel(cid, SKILL_FISHING) >= 100 then
randsummon = math.random(0,9)
elseif getPlayerLevel(cid) >= 5000 then
randsummon = math.random(0,8)
elseif getPlayerLevel(cid) >= 3000 then
randsummon = math.random(0,6)
elseif getPlayerLevel(cid) >= 1500 then
randsummon = math.random(0,4)
elseif getPlayerLevel(cid) >= 500 then
randsummon = math.random(0,2)
else
doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
end

if randsummon == 0 then
doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
else
doSummonMonster(monsters[randsummon], getCreaturePosition(cid))
doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
end
end

doSendMagicEffect(toPosition, CONST_ME_LOSEENERGY)
return true
end

and the monster works fine as a respaw and summoned by a god

 

[Darkhaos]

This should work:

function onUse(cid, item, fromPosition, itemEx, toPosition)

local config = {
	waterIds = {493, 4608, 4609, 4610, 4611, 4612, 4613, 4614, 4615, 4616, 4617, 4618, 4619, 4620, 4621, 4622, 4623, 4624, 4625},
	rateSkill = getConfigValue("rateSkill"),
	allowFromPz = false,
	useWorms = true
}

local monsters = {'Quara Hydromancer', 'Quara Constrictor', 'Quara Mantassin', 'Quara Pincher', 'Quara Predator', 'Serpent Spawn', 'Wyrm', 'Sea Serpent', 'Titan Goddess of Water'}

	if(not isInArray(config.waterIds, itemEx.itemid)) then
		return false
	end

	if((config.allowFromPz or not getTileInfo(getCreaturePosition(cid)).protection) and itemEx.itemid ~= 493 and math.random(1, (100 + (getPlayerSkill(cid, SKILL_FISHING) / 10))) < getPlayerSkill(cid, SKILL_FISHING) and (not config.useWorms or (getPlayerItemCount(cid, ITEM_WORM) > 0 and doPlayerRemoveItem(cid, ITEM_WORM, 1)))) then
		
		local randsummon = nil
		if getPlayerLevel(cid) >= 5000 and getPlayerSkillLevel(cid, SKILL_FISHING) >= 100 then
			randsummon = math.random(0, table.maxn(monsters))
		elseif getPlayerLevel(cid) >= 5000 then
			randsummon = math.random(0, 8)
		elseif getPlayerLevel(cid) >= 3000 then
			randsummon = math.random(0, 6)
		elseif getPlayerLevel(cid) >= 1500 then
			randsummon = math.random(0, 4)
		elseif getPlayerLevel(cid) >= 500 then
			randsummon = math.random(0, 2)
		else
			doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
		end

		if randsummon == 0 then
			doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
		else
			doSummonMonster(monsters[randsummon], getCreaturePosition(cid))
			doPlayerAddSkillTry(cid, SKILL_FISHING, config.rateSkill)
		end
	end

	doSendMagicEffect(toPosition, CONST_ME_LOSEENERGY)
	return true
end

 

[Mozax]

[18/01/2010 16:20:09] [Error - Action Interface]
[18/01/2010 16:20:09] data/actions/scripts/tools/fishing.luanUse
[18/01/2010 16:20:09] Description:
[18/01/2010 16:20:09] (luaDoSummonMonster) Creature not found
what do i do?