Help in globalevent

[Dileck]

This is a script that every 24 hrs removes 1 unit from X storage value but i cant get it to work, it makes it go from 30 to -2, 21:25 You have -2 vip days left.

-- Credits StreamSide and Empty
function onThink(cid, item, fromPosition, toPosition)

	for _, name in ipairs(getOnlinePlayers()) do
		local player = getPlayerByName(name)
		if getPlayerStorageValue(player,11551) >= 1 then
			setPlayerStorageValue(player,11551,getPlayerStorageValue(player) - 1)
		end
	end
end

i get this error on the console

[11/03/2009 21:16:37] Lua Script Error: [GlobalEvent Interface] 
[11/03/2009 21:16:37] data/globalevents/scripts/removevipdays.lua:onThink

[11/03/2009 21:16:37] luaGetPlayerStorageValue(). Player not found

[11/03/2009 21:16:37] Lua Script Error: [GlobalEvent Interface] 
[11/03/2009 21:16:37] data/globalevents/scripts/removevipdays.lua:onThink

[11/03/2009 21:16:37] luaGetPlayerStorageValue(). Player not found
[11/03/2009 21:16:37] [Error - GlobalEvents::onThink] Couldn't execute event: checkvip
[11/03/2009 21:16:46] [Error - GlobalEvents::onThink] Couldn't execute event: checkvip
[11/03/2009 21:16:55] [Error - GlobalEvents::onThink] Couldn't execute event: checkvip

Thanks in adavance.

 

[Pitufo™]

return TRUE:

-- Credits StreamSide and Empty
function onThink(cid, item, fromPosition, toPosition)

	for _, name in ipairs(getOnlinePlayers()) do
		local player = getPlayerByName(name)
		if getPlayerStorageValue(player,11551) >= 1 then
			setPlayerStorageValue(player,11551,getPlayerStorageValue(player) - 1)
		end
	end
return TRUE
end

 

[Dileck]

Nvm, the error is still there


[12/03/2009 16:52:25] Lua Script Error: [GlobalEvent Interface]
[12/03/2009 16:52:25] data/globalevents/scripts/removevipdays.luanThink

[12/03/2009 16:52:25] luaGetPlayerStorageValue(). Player not found

Edit:
Well i found the bug was this line

setPlayerStorageValue(player,11551,getPlayerStorageValue(player,11551) - 1)

 

[Zonet]

Well kinda easy -.- player to cid

 

[Keraxel]

Well kinda easy -.- player to cid

Noob :/

function onThink(interval, lastExecution)

    for _, player in ipairs(getPlayersOnline()) do
        if getPlayerStorageValue(player,11551) >= 1 then 
            setPlayerStorageValue(player,11551,getPlayerStorageValue(player, 11551) - 1) 
        end 
    end 
return TRUE 
end

Check it.

 

[Zonet]

setPlayerStorageValue(player, ?) wtf? shouldn't it be cid?

 

[Keraxel]

Shouldn't.

 

[Zonet]

And why?
explainszor?

 

[slaw]

Because there is no where cid declared / returned. If you use onUse then there is returned cid, item, fromPosition, toPosition, but this is GLOBALEVENT, and in this script you're doing loop over all players, and as you see:
local player = getPlayerByName(name)
so player == cid, because getPlayerByName return cid to this player
its same

Anyway script was wrong, because used function from 0.2 as Keraxel noticed (getPlayersOnline()) instead getOnlinePlayers())

 

[Darkhaos]

And why?
explainszor?

Because function "onThink" don't have parameter "cid"