Help regarding quest door

[Michael Orsino]

Hey there, can't work out how to make a quest door work. Deleted my script in anger, maybe you can help? I'll outline it below.

item id 1255
uid 9876
if storage 9876 = 1
then let the player pass
else cancel

Thanks a lot

 

[josejunior23]

function onUse(cid, item, frompos, item2, topos)
   	if item.uid == 9876 then
   		queststatus = getPlayerStorageValue(cid, 9876)
   		if queststatus == 1 then

			pos = getPlayerPosition(cid)

			if pos.x == topos.x then
				if pos.y < topos.y then
					pos.y = topos.y + 1
				else
					pos.y = topos.y - 1
				end
			elseif pos.y == topos.y then
				if pos.x < topos.x then
					pos.x = topos.x + 1
				else
					pos.x = topos.x - 1
				end
			else
				doPlayerSendTextMessage(cid,22,'Stand in front of the door.')
				return TRUE
			end

			doTeleportThing(cid,pos)
			doSendMagicEffect(topos,12)
		else
			doPlayerSendTextMessage(cid,22,'You need to complete a quest, then you can pass.')
		end
		return TRUE
	else
		return FALSE
	end
end

 

[Michael Orsino]

Thank you so much again
While I was waiting I got a script out that did the job, but oh my GOD it was dodge.
Would have been embarrassing to use.
Thank you