Lua Help to implement old rope 7.4

[Jhon_]

Can anyone here help me to change this script to work like the 7.4 rope? Can't use it if there is a monster/player/items over the spot where you use the rope?

function onUseRope(player, item, fromPosition, target, toPosition)
    local tile = Tile(toPosition)
    if not tile then
        return false
    end
    
    local itemType = ItemType(target.itemid)
    if itemType and itemType:getGroup() == ITEM_GROUP_SPLASH then
        target = tile:getGround()
    end

    if table.contains(ropeSpots, target.itemid) then
        tile = Tile(toPosition:moveUpstairs())
        if not tile then
            return false
        end

        if tile:hasFlag(TILESTATE_PROTECTIONZONE) and player:isPzLocked() then
            player:sendCancelMessage(RETURNVALUE_PLAYERISPZLOCKED)
            return true
        end

        player:teleportTo(toPosition, false)
        return true
    end

    if table.contains(holeId, target.itemid) then
        toPosition.z = toPosition.z + 1
        tile = Tile(toPosition)
        if not tile then
            return false
        end

        local thing = tile:getBottomCreature() or tile:getTopDownItem()
        if not thing then
            return true
        end

        if thing:isCreature() then
            return thing:teleportTo(toPosition:moveUpstairs(), false)
        elseif thing:isItem() and thing:getType():isMovable() then
            return thing:moveTo(toPosition:moveUpstairs())
        end

        return true
    end

    return false
end

 

[Xikini]

Can anyone here help me to change this script to work like the 7.4 rope? Can't use it if there is a monster/player/items over the spot where you use the rope?

function onUseRope(player, item, fromPosition, target, toPosition)
    local tile = Tile(toPosition)
    if not tile then
        return false
    end
   
    local itemType = ItemType(target.itemid)
    if itemType and itemType:getGroup() == ITEM_GROUP_SPLASH then
        target = tile:getGround()
    end

    if table.contains(ropeSpots, target.itemid) then
        tile = Tile(toPosition:moveUpstairs())
        if not tile then
            return false
        end

        if tile:hasFlag(TILESTATE_PROTECTIONZONE) and player:isPzLocked() then
            player:sendCancelMessage(RETURNVALUE_PLAYERISPZLOCKED)
            return true
        end

        player:teleportTo(toPosition, false)
        return true
    end

    if table.contains(holeId, target.itemid) then
        toPosition.z = toPosition.z + 1
        tile = Tile(toPosition)
        if not tile then
            return false
        end

        local thing = tile:getBottomCreature() or tile:getTopDownItem()
        if not thing then
            return true
        end

        if thing:isCreature() then
            return thing:teleportTo(toPosition:moveUpstairs(), false)
        elseif thing:isItem() and thing:getType():isMovable() then
            return thing:moveTo(toPosition:moveUpstairs())
        end

        return true
    end

    return false
end

function onUseRope(player, item, fromPosition, target, toPosition)
    local tile = Tile(toPosition)
    if not tile then
        return false
    end
    
    if target and target:isCreature() then
        return false
    end
    
    local itemType = ItemType(target.itemid)
    if itemType and itemType:getGroup() == ITEM_GROUP_SPLASH then
        target = tile:getGround()
    end
    
    if table.contains(ropeSpots, target.itemid) then
        tile = Tile(toPosition:moveUpstairs())
        if not tile then
            return false
        end
    
        if tile:hasFlag(TILESTATE_PROTECTIONZONE) and player:isPzLocked() then
            player:sendCancelMessage(RETURNVALUE_PLAYERISPZLOCKED)
            return true
        end
    
        player:teleportTo(toPosition, false)
        return true
    end
    
    if table.contains(holeId, target.itemid) then
        toPosition.z = toPosition.z + 1
        tile = Tile(toPosition)
        if not tile then
            return false
        end
    
        local thing = tile:getBottomCreature() or tile:getTopDownItem()
        if not thing then
            return true
        end
    
        if thing:isCreature() then
            return thing:teleportTo(toPosition:moveUpstairs(), false)
        elseif thing:isItem() and thing:getType():isMovable() then
            return thing:moveTo(toPosition:moveUpstairs())
        end
    
        return true
    end
    
    return false
end

 

[Jhon_]

For some reason, only players and monsters are blocking use for rope, not items

 

[Xikini]

For some reason, only players and monsters are blocking use for rope, not items

I can't see an issue in the code.
Can you show us a screenshot or short video of what's happening in game?

Post automatically merged: Oct 12, 2024

Ah well, here's some prints that might shed some light on the issue.

function onUseRope(player, item, fromPosition, target, toPosition)
    print("rope triggered..")
    local tile = Tile(toPosition)
    if not tile then
        return false
    end
    
    if target and target:isCreature() then
        return false
    end
    
    local itemType = ItemType(target.itemid)
    if itemType and itemType:getGroup() == ITEM_GROUP_SPLASH then
        print("splash detected (itemid " .. target.itemid .. "), new target is ground..")
        target = tile:getGround()
    end
    
    if table.contains(ropeSpots, target.itemid) then
        tile = Tile(toPosition:moveUpstairs())
        if not tile then
            return false
        end
    
        if tile:hasFlag(TILESTATE_PROTECTIONZONE) and player:isPzLocked() then
            player:sendCancelMessage(RETURNVALUE_PLAYERISPZLOCKED)
            return true
        end
    
        player:teleportTo(toPosition, false)
        print("rope used successfully on itemid " .. target.itemid)
        return true
    end
    
    if table.contains(holeId, target.itemid) then
        toPosition.z = toPosition.z + 1
        tile = Tile(toPosition)
        if not tile then
            return false
        end
    
        local thing = tile:getBottomCreature() or tile:getTopDownItem()
        if not thing then
            return true
        end
    
        if thing:isCreature() then
            return thing:teleportTo(toPosition:moveUpstairs(), false)
        elseif thing:isItem() and thing:getType():isMovable() then
            return thing:moveTo(toPosition:moveUpstairs())
        end
    
        return true
    end
    
    return false
end