Solved Help with corpse (onDeath) TFS 1.0

[eduardbean]

function onDeath(player, corpse, killer, mostDamageKiller, unjustified, mostDamageUnjustified)
print(getContainerSize(corpse))
return true
end

Why does this always returns 0 ?, how i can return corpse from game ? to check size and get itens from corpse ?
​

 

[Limos]

The items are created later in the corpse, so at the moment you check the amount of items it's 0.
You can do something like this, after 100 milliseconds the items are already added in the corpse.

local function getCorpseSize(pos)
     print(Tile(pos):getTopVisibleThing():getSize())
end

addEvent(getCorpseSize, 100, player:getPosition())

 

[eduardbean]

This is My Code
​

function onDeath(player, corpse, killer, mostDamageKiller, unjustified, mostDamageUnjustified)
        local loot = {}
        local pos = player:getPosition()
        local text = ""

        tile = Tile(pos):getTopVisibleThing()

        for i = 0, tile:getSize() do
            loot[i] = getContainerItem(tile.uid, i)
        end
        for i, v in pairs(loot) do
            if text == "" then
                text = "Loot from "..player:getName()..": "..getItemName(v)
            else
                text = text..", "..getItemName(v)
            end
        end
       print(text)
    return true
end

and this is my error

I Just want to return loot itens, for give it to player, and remove from corpse like a autoLoot.​

 

[Limos]

Add it in a new Lua made function and execute this function with addEvent like I posted.

 

[Ninja]

You should check whether the thing is an item (and container) or not before you proceed with getSize().

    local thing = Tile(position):getTopVisibleThing()
    if thing
            and thing:isItem()
            and thing:isContainer()
            and thing:getType():isCorpse() then
        -- something
    end

 

[eduardbean]

Oh Right, Very Thx man, Solved.
​

 

[Itutorial]

I have this same problem. I have tried using addEvent as well. Nothing seems to be working. I can not get items out of a corpse for the life of me. What do I need to do???

This is my code. line 32 prints 0
line 33/34 do not print at all

local RarityDrops = CreatureEvent("rarity_drops")

function recursiveContainers(container)
    local containerItems = container:getItems(true)

    local items = {}
    for i = 1, #containerItems do
        local cItem = containerItems[i]
        if cItem:isContainer() then
            local newItems = recursiveContainers(cItem)
            
            if #newItems > 0 then
                for x = 1, #newItems do
                    local newItem = newItems[i]
                    items[#items + 1] = newItem
                end
            end
        else
            items[#items + 1] = newItem
        end
    end

    return items
end

function checkCorpse(corpsePosition)
    local corpse = Tile(corpsePosition):getTopVisibleThing()
    if not corpse or not corpse:isContainer() then return true end
    
    local containerItems = recursiveContainers(corpse)
    print(#containerItems)
    for i, v in pairs(containerItems) do
        print(i)
        print(v)
    end
end

function RarityDrops.onDeath(creature, corpse, killer, mostDamageKiller, lastHitUnjustified, mostDamageUnjustified)
    local monster = Monster(creature)
    if not monster then return true end
    
    addEvent(checkCorpse, 100, corpse:getPosition())
    return true
end

RarityDrops:register()

 

[Xikini]

I have this same problem. I have tried using addEvent as well. Nothing seems to be working. I can not get items out of a corpse for the life of me. What do I need to do???

This is my code. line 32 prints 0
line 33/34 do not print at all

local RarityDrops = CreatureEvent("rarity_drops")

function recursiveContainers(container)
    local containerItems = container:getItems(true)

    local items = {}
    for i = 1, #containerItems do
        local cItem = containerItems[i]
        if cItem:isContainer() then
            local newItems = recursiveContainers(cItem)
         
            if #newItems > 0 then
                for x = 1, #newItems do
                    local newItem = newItems[i]
                    items[#items + 1] = newItem
                end
            end
        else
            items[#items + 1] = newItem
        end
    end

    return items
end

function checkCorpse(corpsePosition)
    local corpse = Tile(corpsePosition):getTopVisibleThing()
    if not corpse or not corpse:isContainer() then return true end
 
    local containerItems = recursiveContainers(corpse)
    print(#containerItems)
    for i, v in pairs(containerItems) do
        print(i)
        print(v)
    end
end

function RarityDrops.onDeath(creature, corpse, killer, mostDamageKiller, lastHitUnjustified, mostDamageUnjustified)
    local monster = Monster(creature)
    if not monster then return true end
 
    addEvent(checkCorpse, 100, corpse:getPosition())
    return true
end

RarityDrops:register()

Problem appears to be in your custom function.

function recursiveContainers(container)
    local containerItems = container:getItems(true)

    local items = {}
    for i = 1, #containerItems do
        local cItem = containerItems[i]
        if cItem:isContainer() then
            local newItems = recursiveContainers(cItem)
          
            if #newItems > 0 then
                for x = 1, #newItems do
                    local newItem = newItems[x]  -- Use 'x' instead of 'i'
                    items[#items + 1] = newItem
                end
            end
        else
            items[#items + 1] = cItem  -- Use 'cItem' for non-container items
        end
    end

    return items
end

Some issues here beyond that tho..

local containerItems = container:getItems(true) -- true here means it checks recursively..
.
.
local newItems = recursiveContainers(cItem) -- which means this is going to cause duplicate items to be found

But, that entire function is not required, since we already have the ability to recursively find all the items in a container..
So it can be simplified to this..

local RarityDrops = CreatureEvent("rarity_drops")

local function checkCorpse(corpsePosition, corpseNumber)
    local corpse = Tile(corpsePosition):getTopVisibleThing()
    if not corpse or not corpse:isContainer() then
        print("Unable to find corpse, or corpse is not a container.")
        return true
    end
  
    local containerItems = corpse:getItems(true)
    print(#containerItems)
    for i, v in pairs(containerItems) do
        print(i)
        print(v)
    end
end

function RarityDrops.onDeath(creature, corpse, killer, mostDamageKiller, lastHitUnjustified, mostDamageUnjustified)
    local monster = Monster(creature)
    if not monster or not corpse then
        return true
    end
  
    addEvent(checkCorpse, 100, corpse:getPosition())
    return true
end

RarityDrops:register()

but I'd suggest adding some kind of marker to the corpse you're trying to check, so that it's grabbing the correct item.
(custom attribute, CORPSE_IDENTIFIER -> add from 1-10000, then loop? and when finding the corpse, loop through all the items on the tile, until you find the CORPSE_IDENTIFIER..)
After typing this all out.. I might as well actually script it lmao.

Alright here we go.

local corpseCounter = 0

local function checkCorpse(corpsePosition, corpseNumber)
    local corpse = false
    local tileItems = Tile(corpsePosition):getItems()
  
    for _, item in pairs(tileItems) do
        local identifier = item:getCustomAttribute("CORPSE_IDENTIFIER")
        if identifier and identifier == corpseNumber then
            corpse = item
            corpse:removeCustomAttribute("CORPSE_IDENTIFIER")
            break
        end
    end
  
    if not corpse or not corpse:isContainer() then
        print("Unable to find corpse, or corpse is not a container.")
        return true
    end
  
    local containerItems = corpse:getItems(true)
    print(#containerItems)
  
    for i, v in pairs(containerItems) do
        print(i)
        print(v)
    end
end

local RarityDrops = CreatureEvent("rarity_drops")

function RarityDrops.onDeath(creature, corpse, killer, mostDamageKiller, lastHitUnjustified, mostDamageUnjustified)
    local monster = Monster(creature)
    if not monster or not corpse then
        return true
    end
  
    corpseCounter = corpseCounter == 10000 and 1 or corpseCounter + 1
    corpse:setCustomAttribute("CORPSE_IDENTIFIER", corpseCounter)
    addEvent(checkCorpse, 100, corpse:getPosition(), corpseCounter)
    return true
end

RarityDrops:register()

 

[Itutorial]

Problem appears to be in your custom function.

function recursiveContainers(container)
    local containerItems = container:getItems(true)

    local items = {}
    for i = 1, #containerItems do
        local cItem = containerItems[i]
        if cItem:isContainer() then
            local newItems = recursiveContainers(cItem)
       
            if #newItems > 0 then
                for x = 1, #newItems do
                    local newItem = newItems[x]  -- Use 'x' instead of 'i'
                    items[#items + 1] = newItem
                end
            end
        else
            items[#items + 1] = cItem  -- Use 'cItem' for non-container items
        end
    end

    return items
end

Some issues here beyond that tho..

local containerItems = container:getItems(true) -- true here means it checks recursively..
.
.
local newItems = recursiveContainers(cItem) -- which means this is going to cause duplicate items to be found

But, that entire function is not required, since we already have the ability to recursively find all the items in a container..
So it can be simplified to this..

local RarityDrops = CreatureEvent("rarity_drops")

local function checkCorpse(corpsePosition, corpseNumber)
    local corpse = Tile(corpsePosition):getTopVisibleThing()
    if not corpse or not corpse:isContainer() then
        print("Unable to find corpse, or corpse is not a container.")
        return true
    end
 
    local containerItems = corpse:getItems(true)
    print(#containerItems)
    for i, v in pairs(containerItems) do
        print(i)
        print(v)
    end
end

function RarityDrops.onDeath(creature, corpse, killer, mostDamageKiller, lastHitUnjustified, mostDamageUnjustified)
    local monster = Monster(creature)
    if not monster or not corpse then
        return true
    end
 
    addEvent(checkCorpse, 100, corpse:getPosition())
    return true
end

RarityDrops:register()

but I'd suggest adding some kind of marker to the corpse you're trying to check, so that it's grabbing the correct item.
(custom attribute, CORPSE_IDENTIFIER -> add from 1-10000, then loop? and when finding the corpse, loop through all the items on the tile, until you find the CORPSE_IDENTIFIER..)
After typing this all out.. I might as well actually script it lmao.

Alright here we go.

local corpseCounter = 0

local function checkCorpse(corpsePosition, corpseNumber)
    local corpse = false
    local tileItems = Tile(corpsePosition):getItems()
 
    for _, item in pairs(tileItems) do
        local identifier = item:getCustomAttribute("CORPSE_IDENTIFIER")
        if identifier and identifier == corpseNumber then
            corpse = item
            corpse:removeCustomAttribute("CORPSE_IDENTIFIER")
            break
        end
    end
 
    if not corpse or not corpse:isContainer() then
        print("Unable to find corpse, or corpse is not a container.")
        return true
    end
 
    local containerItems = corpse:getItems(true)
    print(#containerItems)
 
    for i, v in pairs(containerItems) do
        print(i)
        print(v)
    end
end

local RarityDrops = CreatureEvent("rarity_drops")

function RarityDrops.onDeath(creature, corpse, killer, mostDamageKiller, lastHitUnjustified, mostDamageUnjustified)
    local monster = Monster(creature)
    if not monster or not corpse then
        return true
    end
 
    corpseCounter = corpseCounter == 10000 and 1 or corpseCounter + 1
    corpse:setCustomAttribute("CORPSE_IDENTIFIER", corpseCounter)
    addEvent(checkCorpse, 100, corpse:getPosition(), corpseCounter)
    return true
end

RarityDrops:register()

Thank you for taking the time to write all this out.. I did find out though that I can just use the default onDropLoot monster event in the data/scripts/events/monster folder. Makes it a lot easier to work with. In this case I needed to modify all monsters drops so this works for me. If I ever need to be more specific about which monster I may utilize the onDeath. Shouldn't congest all drops with something only one monster should do.