help with Drowning condition

[robertorb12]

the drowning effect never disappears, need to log out to remove
im using tfs 1.3

i use this script: Drowning.lua in movements

local condition = Condition(CONDITION_DROWN)
condition:setParameter(CONDITION_PARAM_PERIODICDAMAGE, -20)
condition:setParameter(CONDITION_PARAM_TICKS, -1)
condition:setParameter(CONDITION_PARAM_TICKINTERVAL, 2000)

function onStepIn(creature, item, position, fromPosition)
    if creature:isPlayer() then
        if math.random(1, 10) == 1 then
            position:sendMagicEffect(CONST_ME_BUBBLES)
        end
        creature:addCondition(condition)
    end
    return true
end

function onStepOut(creature, item, position, fromPosition)
    if not creature:isPlayer() then
        creature:removeCondition(CONDITION_DROWN)
    end
    return true
end

please help

 

[Evil Puncker]

maybe you are leaving the underwater in a way that is not executing the stepOut event

 

[Addams]

Post how its added in your data\movements\movements.xml

 

[robertorb12]

    <!-- Swimming -->
    <movevent event="StepIn" fromid="4620" toid="4625" script="others/swimming.lua" />
    <movevent event="StepOut" fromid="4620" toid="4625" script="others/swimming.lua" />
    <movevent event="StepIn" fromid="5406" toid="5410" script="others/drowning.lua"/>
    <movevent event="StepOut" fromid="5406" toid="5410" script="others/drowning.lua"/>
    <movevent event="StepIn" fromid="5743" toid="5744" script="others/drowning.lua"/>
    <movevent event="StepOut" fromid="5743" toid="5744" script="others/drowning.lua"/>
     <movevent event="StepIn" itemid="5764" script="others/drowning.lua"/>
    <movevent event="StepOut" itemid="5764" script="others/drowning.lua"/>
    <movevent event="StepIn" fromid="9671" toid="9673" script="others/drowning.lua"/>
    <movevent event="StepOut" fromid="9671" toid="9673" script="others/drowning.lua"/>
    <movevent event="StepIn" itemid="10019" script="others/drowning.lua"/>
    <movevent event="StepOut" itemid="10019" script="others/drowning.lua"/>

Post automatically merged: Feb 19, 2020

tfs 1.3 or OTBR?

tfs 1.3 based on otbr

Post automatically merged: Feb 19, 2020

Post how its added in your data\movements\movements.xml

    <!-- Swimming -->
    <movevent event="StepIn" fromid="4620" toid="4625" script="others/swimming.lua" />
    <movevent event="StepOut" fromid="4620" toid="4625" script="others/swimming.lua" />
    <movevent event="StepIn" fromid="5406" toid="5410" script="others/drowning.lua"/>
    <movevent event="StepOut" fromid="5406" toid="5410" script="others/drowning.lua"/>
    <movevent event="StepIn" fromid="5743" toid="5744" script="others/drowning.lua"/>
    <movevent event="StepOut" fromid="5743" toid="5744" script="others/drowning.lua"/>
     <movevent event="StepIn" itemid="5764" script="others/drowning.lua"/>
    <movevent event="StepOut" itemid="5764" script="others/drowning.lua"/>
    <movevent event="StepIn" fromid="9671" toid="9673" script="others/drowning.lua"/>
    <movevent event="StepOut" fromid="9671" toid="9673" script="others/drowning.lua"/>
    <movevent event="StepIn" itemid="10019" script="others/drowning.lua"/>
    <movevent event="StepOut" itemid="10019" script="others/drowning.lua"/>

 

[Addams]

If its otservbr then replace your script with this one and retry.

https://raw.githubusercontent.com/opentibiabr/otservbr-global/develop/data/movements/scripts/others/drowning.lua

 

[robertorb12]

If its otservbr then replace your script with this one and retry.

https://raw.githubusercontent.com/opentibiabr/otservbr-global/develop/data/movements/scripts/others/drowning.lua

still same

Post automatically merged: Feb 19, 2020

maybe you are leaving the underwater in a way that is not executing the stepOut event

how could i solve that ?

 

[Addams]

Try this one

local condition = Condition(CONDITION_DROWN)
condition:setParameter(CONDITION_PARAM_PERIODICDAMAGE, -20)
condition:setParameter(CONDITION_PARAM_TICKS, -1)
condition:setParameter(CONDITION_PARAM_TICKINTERVAL, 2000)

function onStepIn(creature, item, position, fromPosition)
    if creature:isPlayer() then
        if math.random(1, 10) == 1 then
            position:sendMagicEffect(CONST_ME_BUBBLES)
        end
        creature:addCondition(condition)
    end
    return true
end

function onStepOut(creature, item, position, fromPosition)
    if creature:isPlayer() then
        creature:removeCondition(CONDITION_DROWN)
    end
    return true
end

 

[robertorb12]

Try this one

local condition = Condition(CONDITION_DROWN)
condition:setParameter(CONDITION_PARAM_PERIODICDAMAGE, -20)
condition:setParameter(CONDITION_PARAM_TICKS, -1)
condition:setParameter(CONDITION_PARAM_TICKINTERVAL, 2000)

function onStepIn(creature, item, position, fromPosition)
    if creature:isPlayer() then
        if math.random(1, 10) == 1 then
            position:sendMagicEffect(CONST_ME_BUBBLES)
        end
        creature:addCondition(condition)
    end
    return true
end

function onStepOut(creature, item, position, fromPosition)
    if creature:isPlayer() then
        creature:removeCondition(CONDITION_DROWN)
    end
    return true
end

still the same, when leaving the water continues with the drowning effect

 

[Addams]

Edited it try now and check if you get any console errors on Stepout.

 

[robertorb12]

Edited it try now and check if you get any console errors on Stepout.

Lua Script Error: [MoveEvents Interface]
data/movements/scripts/others/drowning.lua:onStepOut
data/movements/scripts/others/drowning.lua:17: attempt to index global 'player' (a nil value)
stack traceback:
        [C]: in function '__index'
        data/movements/scripts/others/drowning.lua:17: in function <data/movements/scripts/others/drowning.lua:16>

I got that error in console

 

[robertorb12]

Edited it try now and check if you get any console errors on Stepout.

What I can do?

Post automatically merged: Feb 20, 2020

BUMP

 

[Addams]

What is your ground id for drowning? it is supposed to work I edited it retry.

 

[robertorb12]

What is your ground id for drowning? it is supposed to work I edited it retry.

nope dont work grounds id for drowning are: 5407 to 5409

 

[ots49]

Did you manage to fix this? I too can't get stepout function to work :/ character keeps on drowning until player relogs