TFS 1.X+ Help with recent memory commit logs

[ralke]

Hi there! I'm seeking with @Itutorial if someone can provide logs of recent fixes for memory leaks on theforgottenserver. I forked my own server from nekiro's achieved repository (TFS 1.5 downgrades) and started from that point. So I missed the most of recent TFS optimizations. We have noticed some differences on our engines, where mine has more memory usage than his newer engine (10.98 with newest sources)

I'm aware that this two should be applied.
Cleanup & organize includes and PCH (#4019) · otland/forgottenserver@c359649 (https://github.com/otland/forgottenserver/commit/c3596491a3e4887872cb2d74e4d76dea7160b5c7)
Move all system & boost headers to PCH (#4022) · otland/forgottenserver@f80456e (https://github.com/otland/forgottenserver/commit/f80456ea113634f58313d2e3b8705fb12999a58b)
It is possible it fixed some loops in includes and stuff which could cause more memory usage.

Which other commits should I look for?
Also need to mention that I still use old vcpkg to compile (boost 143), that corresponds to the latest nekiro's build.

Regards, and thanks in advance!

 

[Marko999x]

after adding this my npcs are not able to walk anymore they stand still how to fix?

Then its something with your source
Its working for me

 

[johnsamir]

Then its something with your source
Its working for me

Gotta review, thanks

 

[Forkz]

I'll try to do it the easier as possible. Do the following to merge (some commits will tell you to do this... and then revert that... just don't delete & go, sometimes use // to comment code in case you probably have to add it later):

The following commit logs must be applied from achieved nekiro downgrade repository (8.6, 8.0, whatever).

1. Gigastar A* pathfinding Gigastar A* Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@45f9793 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/45f9793faa63201db903bc79d724bae80c9b6f46)
2. Gigastar pathfinding call Gigastar Pathfinding Call · ralke23/Greed-TFS-1.5-Downgrades@eb642bf (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/eb642bf87f76c600479abdc16201af816183dead)
3. Method set master position Method setMasterPosition · ralke23/Greed-TFS-1.5-Downgrades@8f2d82a (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/8f2d82ad839cde1612cc8ac6dc9c8f0ecbc855d6)
4. Update follow path Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/3077e8f539a216cbbbaa2d056c35427057aea482)
5. PLAYER_SEARCHDIST PLAYER_SEARCHDIST · ralke23/Greed-TFS-1.5-Downgrades@b73d122 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/b73d122ab47035e0cc7e6c126a6db463f42c7555)
6. getPathTo (position to pos) getPathTo (position to pos) · ralke23/Greed-TFS-1.5-Downgrades@9a440f3 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/9a440f39610b684fefc1ca8c1b1f16ab410093e1)
7. Add follow position to follow creature Add followPosition to followCreature · ralke23/Greed-TFS-1.5-Downgrades@044299d (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/044299d305d2e744d294c8799c2a86630903b24d)
8. Summon keepDistance, isInRange, distance check Summon keepDistance, isInRange, distance check. · ralke23/Greed-TFS-1.5-Downgrades@50d9f7b (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/50d9f7bc8c311c487cf840123808e7f7dc7aaeaa)
9. Corrections Corrections · ralke23/Greed-TFS-1.5-Downgrades@d105eb0 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d105eb0d917f2814ec9408f3c8bbe2710d7b9eba)
10. 9 players stackpos bug 9 players stackpos bug · ralke23/Greed-TFS-1.5-Downgrades@4473d68 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/4473d6806ea7420bc78cf58b1fea28e991acf67d)
11. Fir3lement 0.4 goToFollowCreature Fir3lement 0.4 goToFollowCreature · ralke23/Greed-TFS-1.5-Downgrades@404c478 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/404c478dd10811a9a2275bce9e0b94c18df0923c)
12. NRH-AA Pathfinding NRH-AA Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@570c4d7 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/570c4d7b3aef10166ae8ab52f87ffa167ab70415)
13. First adjustments on NRH-A Pathfinding First adjustments on NRH-A Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@d5670ec (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d5670ec78becd3ec9fa6eb60b4304628381ad78c)
14. Optimize pathfinding by NRH-AA Optimize pathfinding by NRH-AA · ralke23/Greed-TFS-1.5-Downgrades@efdd636 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/efdd636193d4a50df88733811631cf0afa161c92)
15. Path viewport check, fix to blocked sight of monsters (needs review, it causes lag and memory increase) Path viewport check, fix to blocked sight of monsters (needs review, … · ralke23/Greed-TFS-1.5-Downgrades@d001657 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d0016579d68c06570487444e62e29137bf3c5eed)
16. NRA-AA fixing memory leaks NRA-AA fixing memory leaks · ralke23/Greed-TFS-1.5-Downgrades@4fc0dfa (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/4fc0dfa394249ca212690d0e62d456fa6433adb6)
17. NRH-AA latest changes NRH-AA latest changes · ralke23/Greed-TFS-1.5-Downgrades@81f7784 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/81f7784fccd6ebd074e4b22b6f72488c5eda6123)

Can't be more easy to follow than this. Remember. You need to use achieved Nekiro distribution.
Regards!

I made all the monster pathfinding commits, it went from 17% CPU usage to 70%, so I don't recommend making these changes to the nekiro src.

 

[ForgottenNot]

I made all the monster pathfinding commits, it went from 17% CPU usage to 70%, so I don't recommend making these changes to the nekiro src.

you have to add previous commits menthioned here to fix that like fix npc memory leak and many others

 

[Forkz]

you have to add previous commits menthioned here to fix that like fix npc memory leak and many others

Yes, I made the changes

 

[ForgottenNot]

0.9 of use here global map 8.6

 

[Marko999x]

0.9 of use here global map 8.6

0.9.what
Cpu?

 

[Forkz]

0.9 of use here global map 8.6

mine is 2~3%

 

[ralke]

I made all the monster pathfinding commits, it went from 17% CPU usage to 70%, so I don't recommend making these changes to the nekiro src.

Hi, how many players you had when you tried the changes? Also want to know if you just downloaded the nekiro source and then merged the code? Because I haven't noticed any increment on CPU, but, I still need to try it with more players logged in. Send me a message on discord and we can see it; creatures behave much better, it is not just a CPU optimization.

 

[Codinablack]

mine is 2~3%

I made all the monster pathfinding commits, it went from 17% CPU usage to 70%, so I don't recommend making these changes to the nekiro src.

Which is it?

2-3 percent or 70?

 

[Forkz]

Which is it?

2-3 percent or 70?

my server has between 2~3% CPU usage, with the test I did it goes to 17%~ and I did the same test with the updates it went from 17% to 70%.