C++ How to avoid people using items as a event? (Tfs 1.5)

[Marko999x]

Hi,
Im trying to avoid people using a item with a new event function but it seems like I did something wrong

events.cpp

void Events::eventPlayerOnUseItem(Player* player, Item* item)
{
    // Player:onUseItem(item)
    if (info.playerOnUseItem == -1) {
        return;
    }

    if (!scriptInterface.reserveScriptEnv()) {
        std::cout << "[Error - Events::eventPlayerOnUseItem] Call stack overflow" << std::endl;
        return;
    }

    ScriptEnvironment* env = scriptInterface.getScriptEnv();
    env->setScriptId(info.playerOnUseItem, &scriptInterface);

    lua_State* L = scriptInterface.getLuaState();
    scriptInterface.pushFunction(info.playerOnUseItem);

    LuaScriptInterface::pushUserdata<Player>(L, player);
    LuaScriptInterface::setMetatable(L, -1, "Player");

    LuaScriptInterface::pushUserdata<Item>(L, item);
    LuaScriptInterface::setItemMetatable(L, -1, item);

    scriptInterface.callFunction(2);
}

and

            } else if (methodName == "onUseItem") {
                info.playerOnUseItem = event;

events.h

int32_t playerOnUseItem = -1;

and

void eventPlayerOnUseItem(Player* player, Item* item);

and in game.cpp under playerUseItem and playerUseItemEx function

g_events->eventPlayerOnUseItem(player, item);

like that:


lua:

local ec = EventCallback

ec.onUseItem = function(player, item)
    if player:getStorageValue(200) == 1 then
        player:sendCancelMessage('Not Possible.')
        return false
    end
    return true
end

ec:register()

The script detects an onUse action, but I can still use the item
And yes I registed everything on events.xml, player.lua, eventscallback etc.
A experienced c++ prob can see the problem alredy xD

 

[Gesior.pl]

The script detects an onUse action, but I can still use the item

You do not return value returned from Lua in C++ eventPlayerOnUseItem function and do not check if it's true in game.cpp.

In events.h:

void eventPlayerOnUseItem(Player* player, Item* item);

replace with:

bool eventPlayerOnUseItem(Player* player, Item* item);

In events.cpp:

void Events::eventPlayerOnUseItem(Player* player, Item* item)

replace with:

bool Events::eventPlayerOnUseItem(Player* player, Item* item)

and

scriptInterface.callFunction(2);

replace with:

return scriptInterface.callFunction(2);

In game.cpp:

g_events->eventPlayerOnUseItem(player, item);

replace with:

if (!g_events->eventPlayerOnUseItem(player, item)) {
    return;
}

then if your Lua callback returns false, it will block item usage.

 

[Marko999x]

You do not return value returned from Lua in C++ eventPlayerOnUseItem function and do not check if it's true in game.cpp.

In events.h:

void eventPlayerOnUseItem(Player* player, Item* item);

replace with:

bool eventPlayerOnUseItem(Player* player, Item* item);

In events.cpp:

void Events::eventPlayerOnUseItem(Player* player, Item* item)

replace with:

bool Events::eventPlayerOnUseItem(Player* player, Item* item)

and

scriptInterface.callFunction(2);

replace with:

return scriptInterface.callFunction(2);

In game.cpp:

g_events->eventPlayerOnUseItem(player, item);

replace with:

if (!g_events->eventPlayerOnUseItem(player, item)) {
    return;
}

then if your Lua callback returns false, it will block item usage.

Yeah that was the problem!
Appreciate it thanks you mate