TFS 1.X+ How to have attack speed scalling with skill level?

[Tofame]

Hi,
I've found this thread:

Fast Attack depends FirstSkill TFS 1.x

I want make fast attack depends from First Skill. In TFS 0.3.7 have this code. But i want change in TFS 1.2 uint32_t Player::getAttackSpeed() const { int32_t SpeedAttack; SpeedAttack = vocation->getAttackSpeed() - (getSkill(SKILL_FIST, SKILL_LEVEL) * 10); if (SpeedAttack < 500) {...

otland.net

I changed:

uint32_t getAttackSpeed() const;

for

uint32_t getAttackSpeed() const {
            int32_t SpeedAttack;
            SpeedAttack = vocation->getAttackSpeed() - (getSkill(SKILL_FIST, SKILL_LEVEL) * 10);

            if (SpeedAttack < 500) {
                return 500;
            } else {
                return (uint32_t) SpeedAttack;
            }
        }

My tfs is 1.4.2 and I got errors during compilation:

Any solution?

 

[Perwers]

getSkill(SKILL_FIST, SKILL_LEVEL)
to
getSkillLevel(SKILL_FIST)

 

[Tofame]

getSkill(SKILL_FIST, SKILL_LEVEL)
to
getSkillLevel(SKILL_FIST)

another error :/

 

[Roddet]

Compiler is saying that getAttackSpeed() already has a body, so we can assume that func is being declared on player.cpp in this case

Leave player.h untouched, go to player.cpp and replace the whole function

uint32_t Player::getAttackSpeed() const
{
    uint32_t extraSpeed = getSkillLevel(SKILL_FIST) * 10;
    const Item* weapon = getWeapon(true);

    if (!weapon || weapon->getAttackSpeed() == 0) {
        return (vocation->getAttackSpeed() - extraSpeed);
    }

    return (weapon->getAttackSpeed() - extraSpeed);
}

 

[Tofame]

Compiler is saying that getAttackSpeed() already has a body, so we can assume that func is being declared on player.cpp in this case

Leave player.h untouched, go to player.cpp and replace the whole function

uint32_t Player::getAttackSpeed() const
{
    uint32_t extraSpeed = getSkillLevel(SKILL_FIST) * 10;
    const Item* weapon = getWeapon(true);

    if (!weapon || weapon->getAttackSpeed() == 0) {
        return (vocation->getAttackSpeed() - extraSpeed);
    }

    return (weapon->getAttackSpeed() - extraSpeed);
}

Thank you very much, I compiled and it works.
edited:
Could you tell me that if I wanted to limit speed would this be okay?

uint32_t Player::getAttackSpeed() const
{
    uint32_t extraSpeed = getSkillLevel(SKILL_FIST) * 10;
    const Item* weapon = getWeapon(true);
    
    if (extraSpeed > 1400) {
        extraSpeed = 1400;
    }

    if (!weapon || weapon->getAttackSpeed() == 0) {
        return (vocation->getAttackSpeed() - extraSpeed);
    }

    return (weapon->getAttackSpeed() - extraSpeed);
}

 

[Roddet]

Thank you very much, I compiled and it works.
edited:
Could you tell me that if I wanted to limit speed would this be okay?

uint32_t Player::getAttackSpeed() const
{
    uint32_t extraSpeed = getSkillLevel(SKILL_FIST) * 10;
    const Item* weapon = getWeapon(true);
 
    if (extraSpeed > 1400) {
        extraSpeed = 1400;
    }

    if (!weapon || weapon->getAttackSpeed() == 0) {
        return (vocation->getAttackSpeed() - extraSpeed);
    }

    return (weapon->getAttackSpeed() - extraSpeed);
}

If you are only seeking to limit AttackS value coming from fist skill, then yes its totally fine

 

[Michcol94]

HANKS