• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

TFS 1.X+ How to make NPC say something in greetCallback(cid)

guiismiti

guiismiti

Well-Known Member
Joined
May 19, 2014
Messages
315
Solutions
3
Reaction score
68
Hello!
I am using a modal window on greet for ship travelling.

If the player is pz locked or doesn't have enough gold, the NPC needs to say it.
Problem - if I use selfSay or npcHandler:say inside the greet function, a random NPC will say those messages, and not the NPC the player is talking to.
Lua: 
local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)

function onCreatureAppear(cid)            npcHandler:onCreatureAppear(cid)            end
function onCreatureDisappear(cid)        npcHandler:onCreatureDisappear(cid)            end
function onCreatureSay(cid, type, msg)        npcHandler:onCreatureSay(cid, type, msg)        end
function onThink()        npcHandler:onThink()        end

local shipDestinations = {
    ["Ab'dendriel (130gp)"] = {
        price = 130,
        destinyPos = Position(32734, 31668, 6)
    },
    ["Carlin (110gp)"] = {
        price = 110,
        destinyPos = Position(32387, 31820, 6)
    },
    ["Thais (40gp)"] = {
        price = 40,
        destinyPos = Position(32310, 32210, 6)
    },
    ["Venore (170gp)"] = {
        price = 170,
        destinyPos = Position(32954, 32022, 6)
    }
}

local function greetCallback(cid)
    local player = Player(cid)
   
    if player:isPzLocked() then
        npcHandler:say("You cannot travel in this condition.", cid)
       
        return true
    end
   
    local window = ModalWindow{title = "Destinations", message = "Select a destination"}
   
    for k, v in pairs(shipDestinations) do
        window:addChoice(k)
    end
   
    window:addButton("Select", function(button, choice)
        local chosenDestiny = shipDestinations[choice.text]
       
        if not player:removeMoneyNpc(chosenDestiny.price) then
            npcHandler:say("You don't have enough gold.", cid)
           
            return true
        else
            player:getPosition():sendMagicEffect(CONST_ME_TELEPORT)
            player:teleportTo(chosenDestiny.destinyPos)
            chosenDestiny.destinyPos:sendMagicEffect(CONST_ME_TELEPORT)
        end
    end)
   
    window:setDefaultEnterButton("Select")
    window:addButton("Cancel")
    window:setDefaultEscapeButton("Cancel")
    window:sendToPlayer(player)
   
    return true
end

npcHandler:setCallback(CALLBACK_GREET, greetCallback)
npcHandler:setMessage(MESSAGE_GREET, "Welcome on board, Sir |PLAYERNAME|.")
npcHandler:setMessage(MESSAGE_FAREWELL, "Good bye. Recommend us if you were satisfied with our service.")
npcHandler:setMessage(MESSAGE_WALKAWAY, "Good bye then.")

npcHandler:addModule(FocusModule:new())

Can anybody help, please?
 
Sort by date Sort by votes
Lua: 
local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)

function onCreatureAppear(cid)            npcHandler:onCreatureAppear(cid)            end
function onCreatureDisappear(cid)        npcHandler:onCreatureDisappear(cid)            end
function onCreatureSay(cid, type, msg)        npcHandler:onCreatureSay(cid, type, msg)        end
function onThink()        npcHandler:onThink()        end

local shipDestinations = {
    ["Ab'dendriel (130gp)"] = {
        price = 130,
        destinyPos = Position(32734, 31668, 6)
    },
    ["Carlin (110gp)"] = {
        price = 110,
        destinyPos = Position(32387, 31820, 6)
    },
    ["Thais (40gp)"] = {
        price = 40,
        destinyPos = Position(32310, 32210, 6)
    },
    ["Venore (170gp)"] = {
        price = 170,
        destinyPos = Position(32954, 32022, 6)
    }
}

local function greetCallback(cid)
     local player = Player(cid)
  
    if player:isPzLocked()
        npcHandler:setMessage(MESSAGE_GREET, "You cannot travel in this condition.")
        return true
    end
  
    local window = ModalWindow{title = "Destinations", message = "Select a destination"}
  
    for k, v in pairs(shipDestinations) do
        window:addChoice(k)
    end
  
    window:addButton("Select", function(button, choice)
        local chosenDestiny = shipDestinations[choice.text]
      
        if not player:removeMoneyNpc(chosenDestiny.price) then
            npcHandler:setMessage(MESSAGE_GREET, "You don't have enough gold.")   
            return true
        else
            player:getPosition():sendMagicEffect(CONST_ME_TELEPORT)
            player:teleportTo(chosenDestiny.destinyPos)
            chosenDestiny.destinyPos:sendMagicEffect(CONST_ME_TELEPORT)
        end
    end)
  
    window:setDefaultEnterButton("Select")
    window:addButton("Cancel")
    window:setDefaultEscapeButton("Cancel")
    window:sendToPlayer(player)
  
    return true
end

npcHandler:setCallback(CALLBACK_GREET, greetCallback)
npcHandler:setMessage(MESSAGE_GREET, "Welcome on board, Sir |PLAYERNAME|.")
npcHandler:setMessage(MESSAGE_FAREWELL, "Good bye. Recommend us if you were satisfied with our service.")
npcHandler:setMessage(MESSAGE_WALKAWAY, "Good bye then.")

npcHandler:addModule(FocusModule:new())

try this
 
Upvote 0 Downvote
Sparkles said:
try this
Click to expand...
I just tried it, still got "Welcome on board, Sir |PLAYERNAME|." as greet message, when I said 'hi'.

I also tried removing, from the last lines of the code:
Code: 
npcHandler:setMessage(MESSAGE_GREET, "Welcome on board, Sir |PLAYERNAME|.")
But then it just used the default greet message when I said 'hi', which is defined in npc/lib/npcsystem/npchandler.lua:
Code: 
        messages = {
            -- These are the default replies of all npcs. They can/should be changed individually for each npc.
            [MESSAGE_GREET] = "Greetings, |PLAYERNAME|.",
 
Upvote 0 Downvote
guiismiti said:
I just tried it, still got "Welcome on board, Sir |PLAYERNAME|." as greet message, when I said 'hi'.

I also tried removing, from the last lines of the code:
Code: 
npcHandler:setMessage(MESSAGE_GREET, "Welcome on board, Sir |PLAYERNAME|.")
But then it just used the default greet message when I said 'hi', which is defined in npc/lib/npcsystem/npchandler.lua:
Code: 
        messages = {
            -- These are the default replies of all npcs. They can/should be changed individually for each npc.
            [MESSAGE_GREET] = "Greetings, |PLAYERNAME|.",
Click to expand...
Lua: 
local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)

function onCreatureAppear(cid)            npcHandler:onCreatureAppear(cid)            end
function onCreatureDisappear(cid)        npcHandler:onCreatureDisappear(cid)            end
function onCreatureSay(cid, type, msg)        npcHandler:onCreatureSay(cid, type, msg)        end
function onThink()        npcHandler:onThink()        end

local shipDestinations = {
    ["Ab'dendriel (130gp)"] = {
        price = 130,
        destinyPos = Position(32734, 31668, 6)
    },
    ["Carlin (110gp)"] = {
        price = 110,
        destinyPos = Position(32387, 31820, 6)
    },
    ["Thais (40gp)"] = {
        price = 40,
        destinyPos = Position(32310, 32210, 6)
    },
    ["Venore (170gp)"] = {
        price = 170,
        destinyPos = Position(32954, 32022, 6)
    }
}

local function greetCallback(cid)
     local player = Player(cid)

    if player:isPzLocked() then
        npcHandler:setMessage(MESSAGE_GREET, "You cannot travel in this condition.")
        return true
    else
        npcHandler:setMessage(MESSAGE_GREET, "Welcome on board, Sir |PLAYERNAME|.")
    end
    local window = ModalWindow{title = "Destinations", message = "Select a destination"}

    for k, v in pairs(shipDestinations) do
        window:addChoice(k)
    end

    window:addButton("Select", function(button, choice)
        local chosenDestiny = shipDestinations[choice.text]
   
        if not player:removeMoneyNpc(chosenDestiny.price) then
            npcHandler:setMessage(MESSAGE_GREET, "You don't have enough gold.")
            return true
        else
            player:getPosition():sendMagicEffect(CONST_ME_TELEPORT)
            player:teleportTo(chosenDestiny.destinyPos)
            chosenDestiny.destinyPos:sendMagicEffect(CONST_ME_TELEPORT)
        end
    end)

    window:setDefaultEnterButton("Select")
    window:addButton("Cancel")
    window:setDefaultEscapeButton("Cancel")
    window:sendToPlayer(player)

    return true
end

npcHandler:setCallback(CALLBACK_ONADDFOCUS, onAddFocus)
npcHandler:setCallback(CALLBACK_ONRELEASEFOCUS, onReleaseFocus)
npcHandler:setMessage(MESSAGE_FAREWELL, "Good bye. Recommend us if you were satisfied with our service.")
npcHandler:setMessage(MESSAGE_WALKAWAY, "Good bye then.")

npcHandler:setCallback(CALLBACK_GREET, greetCallback)
npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
npcHandler:addModule(FocusModule:new())

Im not sure about the You don't have enough gold line though.

I feel like you should use creaturesaycallback for this, and not greetcallback for the script.
Maybe you have to use npcHandler:say("", cid) there instead of setMessage, you're gonna have to try it ig.
ex. I know this would work. Because I use a similar type in my npc's
Lua: 
local function greetCallback(cid)
    local player = Player(cid)
    local pz = player:isPzLocked()
    if pz then
        npcHandler:setMessage(MESSAGE_GREET, "You have PZ")
    else
        npcHandler:setMessage(MESSAGE_GREET, "Shit is working, |PLAYERNAME|.")
    end
    return true
end
 
Upvote 0 Downvote
Sparkles said:
Maybe you have to use npcHandler:say("", cid)
Click to expand...
That is the first thing I tried - and a random NPC from anywhere will tell me I have no enough gold.

The problem is the modal window - the pz lock test is working, setting the greet message.
NPCs can't wait for a modal window response to set the greet message.

If I use creaturesaycallback, can I open this window just by saying 'hi'?
Or will this function run only when I say something after 'hi'?
 
Upvote 0 Downvote
guiismiti said:
That is the first thing I tried - and a random NPC from anywhere will tell me I have no enough gold.

The problem is the modal window - the pz lock test is working, setting the greet message.
NPCs can't wait for a modal window response to set the greet message.

If I use creaturesaycallback, can I open this window just by saying 'hi'?
Or will this function run only when I say something after 'hi'?
Click to expand...
creaturesaycallback will react only if the player is in focus, so yeah, after saying hi.

You could do it like, hi and after they say sail. And in the greet you can say like Greetings |PLAYERNAME|, where do you want to {sail}?, and they say sail to get the modalwindow.
 
Upvote 0 Downvote
Sparkles said:
You could do it like, hi and after they say sail.
Click to expand...
Yea, I know... still I think I prefer to use the greet function for the modal window and send a cancel message instead of NPC talk.
It is more practical for players, and the cancel message is not a big loss for the server.
 
Upvote 0 Downvote

Similar threads

bpm91
  • Solved
Lua npc no answer
Replies
4
Views
229
bpm91
bpm91
V
  • Question
npc travel
Replies
2
Views
317
vitorelias1
V
LeOnArd0
  • Question
NPC not talking
Replies
14
Views
527
Fjorda
F
F
  • Question
script npc modification
Replies
5
Views
356
Mateus Robeerto
Mateus Robeerto
H
  • Question
TFS 1.X+ data/npc/lib/npcsystem/modules items[itemid] == nil error
Replies
6
Views
334
Mateus Robeerto
Mateus Robeerto
bpm91
  • Question
TFS 1.X+ addTravelKeyword with storage
2
Replies
20
Views
813
bpm91
bpm91
Lbtg
  • Question
TFS 1.X+ Npc glitches
Replies
5
Views
618
Lbtg
Lbtg
X
  • Question
Lua Trying to do stuff on my own but having an issue with quest
Replies
2
Views
270
XiolenceOT
X
X
  • Question
Lua Trying to get the greeting right for NPC
Replies
2
Views
315
XiolenceOT
X
Jpstafe
  • Question
error npc boats
Replies
0
Views
93
Jpstafe
Jpstafe
Back
Top