TFS 0.X How to make that only one vocation can use DUALWIELD?

caquinha · Dec 14, 2020

How to make that only one vocation can use DUALWIELD?

My source already have DUALWIELD:

Build software better, together

GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 420 million projects.

github.com

But for all vocation...

How to block to all vocation and allow only to vocation 15 and 16?

caquinha · Dec 16, 2020

is it can be done on lua scripts?

Evil Puncker · Dec 16, 2020

yes is it can

just make an movement OnEquip script that check if player vocation is 15 or 16 and make an array with the dualwield items

caquinha · Dec 17, 2020

Evil Puncker said:
yes is it can

just make an movement OnEquip script that check if player vocation is 15 or 16 and make an array with the dualwield items

I did change

3777/items.cpp at 2a3447b6be9930c45340e9df726a66d686a225a3 · Fir3element/3777

Contribute to Fir3element/3777 development by creating an account on GitHub.

github.com

dualWield default to true

so every one hand weapon is dualWield

should i add each weapon in itemid?
<movevent type="Equip" itemid="XXX" slot="???" event="script" value="script.lua"/>

caquinha · Dec 21, 2020

can we check slot hands with onmove like this script?

Lua - Destroy item on move

Im tryng use this function to delete item on move! But dont work, when i start the server dont give me erros on console, when i move itens dont give erros on console I think the problem is here: if item.itemid == 2596 then Or here: doRemoveItem(item.uid, 1) SCRIPTS \/...

otland.net

VictorOtInfinit · Dec 22, 2020

I guess the easy way to do that is putting every weapon that is dual usable only for the class that u want, if all the one handed swords can be dual then this means that everyone who can equip this swords is dual.

caquinha · Dec 22, 2020

VictorOtInfinit said:
I guess the easy way to do that is putting every weapon that is dual usable only for the class that u want, if all the one handed swords can be dual then this means that everyone who can equip this swords is dual.

but that is what i ask for
every one hand is already dual usable
because of dualWield default to true i told before

the only problem now is make it able only for two vocations

Itutorial · Dec 22, 2020

I think you can use dualwield=false in vocation.xml

caquinha · Dec 23, 2020

Itutorial said:
I think you can use dualwield=false in vocation.xml

like this?

Code:

gainsoulticks="5" fromvoc="1" dualwield="false">

i tried but didn't work

Itutorial · Dec 23, 2020

Try with a capital W just to make sure.

caquinha · Dec 26, 2020

Itutorial said:
Try with a capital W just to make sure.

don't work, every vocation are able to equip the weapon

looking for dualWield on sources i found this:

Build software better, together

GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 420 million projects.

github.com

but idk what to do with this :/

Itutorial · Dec 26, 2020

Post your player.cpp

caquinha · Dec 29, 2020

Itutorial said:
Post your player.cpp

3777/player.cpp at master · Fir3element/3777

Contribute to Fir3element/3777 development by creating an account on GitHub.

github.com

Shadowsong · Dec 29, 2020

Vocation.h, give Vocation class new attribute "dualwielding"

bool dualwielding= false; // Nobody can dual-wield by default.

And add new public setter/getter for it:

C++:

        bool canDualWield() const {return dualwielding;}
        void setCanDualWield(bool v) {dualwielding= v;}

In vocations.cpp in parseVocationNode add

C++:

    if(readXMLString(p, "candualwield", strValue))
        voc->setCanDualWield(booleanString(strValue));

Now we use the new Vocation method in player.cpp in Player::__queryAdd func to add a new check when equipping item into hand slot whether the player's vocation can dualwield it:

C++:

else if(!leftItem->isWeapon() || !item->isWeapon() ||
                        leftType == WEAPON_AMMO || type == WEAPON_AMMO ||
                        leftType == WEAPON_SHIELD || type == WEAPON_SHIELD ||
                        (leftItem->isDualWield() && item->isDualWield() && player->getVocation()->canDualWield() ))
                        ret = RET_NOERROR;

And you can set in vocations.xml attribute "candualwield" now to vocs you want to enable this feature for.

EDIT: Changed name of variable one variable, was confusing and same as the name of a function.

EDIT2: I missed it, you also have to do the above edit for the Right hand too here.

caquinha · Dec 29, 2020

Shadowsong said:
Vocation.h, give Vocation class new attribute "dualwielding"

bool dualwielding= false; // Nobody can dual-wield by default.

And add new public setter/getter for it:

C++:

bool canDualWield() const {return dualwielding;} void setCanDualWield(bool v) {dualwielding= v;}

In vocations.cpp in parseVocationNode add

C++:

if(readXMLString(p, "candualwield", strValue)) voc->setCanDualWield(booleanString(strValue));

Now we use the new Vocation method in player.cpp in Player::__queryAdd func to add a new check when equipping item into hand slot whether the player's vocation can dualwield it:

C++:

else if(!leftItem->isWeapon() || !item->isWeapon() || leftType == WEAPON_AMMO || type == WEAPON_AMMO || leftType == WEAPON_SHIELD || type == WEAPON_SHIELD || (leftItem->isDualWield() && item->isDualWield() && player->getVocation()->canDualWield() )) ret = RET_NOERROR;

And you can set in vocations.xml attribute "candualwield" now to vocs you want to enable this feature for.

EDIT: Changed name of variable one variable, was confusing and same as the name of a function.

EDIT2: I missed it, you also have to do the above edit for the Right hand too here.

Code:

In file included from player.h:30:0,
                 from player.cpp:20:
vocation.h:125:23: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
   bool dualwielding = false; // Nobody can dual-wield by default.
                       ^~~~~
player.cpp: In member function ‘virtual bool Player::canSeeCreature(const Creature*) const’:
player.cpp:889:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  if(const Player* player = creature->getPlayer())
  ^~
player.cpp:891:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
   return !creature->isInvisible() || canSeeInvisibility();
   ^~~~~~
player.cpp: In member function ‘virtual ReturnValue Player::__queryAdd(int32_t, const Thing*, uint32_t, uint32_t) const’:
player.cpp:2730:29: error: ‘creature’ was not declared in this scope
      const Player* player = creature->getPlayer();
                             ^~~~~~~~
Makefile:33: recipe for target 'player.o' failed
make: *** [player.o] Error 1

did i've done something wrong in player.cpp?

Code:

                else if(inventory[SLOT_LEFT])
                {
                    const Item* leftItem = inventory[SLOT_LEFT];
                    WeaponType_t type = item->getWeaponType(), leftType = leftItem->getWeaponType();
                    
                    // only some vocation can dual wield 1
                    const Player* player = creature->getPlayer();

                    if(leftItem->getSlotPosition() & SLOTP_TWO_HAND)
                        ret = RET_DROPTWOHANDEDITEM;
                    else if(item == leftItem && item->getItemCount() == count)
                        ret = RET_NOERROR;
                    else if(leftType == WEAPON_SHIELD && type == WEAPON_SHIELD)
                        ret = RET_CANONLYUSEONESHIELD;
                    // only some vocation can dual wield 2
                    else if(!leftItem->isWeapon() || !item->isWeapon() ||
                        leftType == WEAPON_AMMO || type == WEAPON_AMMO ||
                        leftType == WEAPON_SHIELD || type == WEAPON_SHIELD ||
                        (leftItem->isDualWield() && item->isDualWield() && player->getVocation()->canDualWield() ))
                        ret = RET_NOERROR;
                    else
                        ret = RET_CANONLYUSEONEWEAPON;
                }

Shadowsong · Dec 30, 2020

caquinha said:

Code:

In file included from player.h:30:0,
                 from player.cpp:20:
vocation.h:125:23: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
   bool dualwielding = false; // Nobody can dual-wield by default.
                       ^~~~~
player.cpp: In member function ‘virtual bool Player::canSeeCreature(const Creature*) const’:
player.cpp:889:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  if(const Player* player = creature->getPlayer())
  ^~
player.cpp:891:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
   return !creature->isInvisible() || canSeeInvisibility();
   ^~~~~~
player.cpp: In member function ‘virtual ReturnValue Player::__queryAdd(int32_t, const Thing*, uint32_t, uint32_t) const’:
player.cpp:2730:29: error: ‘creature’ was not declared in this scope
      const Player* player = creature->getPlayer();
                             ^~~~~~~~
Makefile:33: recipe for target 'player.o' failed
make: *** [player.o] Error 1

did i've done something wrong in player.cpp?

Code:

                else if(inventory[SLOT_LEFT])
                {
                    const Item* leftItem = inventory[SLOT_LEFT];
                    WeaponType_t type = item->getWeaponType(), leftType = leftItem->getWeaponType();
                  
                    // only some vocation can dual wield 1
                    const Player* player = creature->getPlayer();

                    if(leftItem->getSlotPosition() & SLOTP_TWO_HAND)
                        ret = RET_DROPTWOHANDEDITEM;
                    else if(item == leftItem && item->getItemCount() == count)
                        ret = RET_NOERROR;
                    else if(leftType == WEAPON_SHIELD && type == WEAPON_SHIELD)
                        ret = RET_CANONLYUSEONESHIELD;
                    // only some vocation can dual wield 2
                    else if(!leftItem->isWeapon() || !item->isWeapon() ||
                        leftType == WEAPON_AMMO || type == WEAPON_AMMO ||
                        leftType == WEAPON_SHIELD || type == WEAPON_SHIELD ||
                        (leftItem->isDualWield() && item->isDualWield() && player->getVocation()->canDualWield() ))
                        ret = RET_NOERROR;
                    else
                        ret = RET_CANONLYUSEONEWEAPON;
                }

Yeah my bad, since this is already this player's object, we should be able to get his vocation with just accessing member vocation, so replace `player->getVocation()->canDualWeild()) with vocation->canDualWield(). Delete this other thing you added.

(Alternatively, you could access it through public getter, which might be more appropriate getVocation()->canDualWield()) or even grab vocation object by utilizing the ID of the voc only: Vocation* voc = Vocations::getInstance()->getVocation(vocationId); and then voc->canDualWield(). I see it was used several times in player.cpp code but this seems redundant to me since getVocation() already exists

)

Make sure to do this in both left hand and right hand code.

Then in vocation.h change
bool dualwielding= false;
To just
bool dualwielding;

Seems like you are using older c++ version where this is not allowed.
Instead, now we will have to initialize value to this member elsewhere.
Even though XML parser is giving it value after reading it, we still want to have a guarantee that there will be a default value for this attribute.

In vocation.cpp in void Vocation::reset() add:
dualwielding = false;

caquinha · Dec 31, 2020

Shadowsong said:
Yeah my bad, since this is already this player's object, we should be able to get his vocation with just accessing member vocation, so replace `player->getVocation()->canDualWeild()) with vocation->canDualWield(). Delete this other thing you added.

(Alternatively, you could access it through public getter, which might be more appropriate getVocation()->canDualWield()) or even grab vocation object by utilizing the ID of the voc only: Vocation* voc = Vocations::getInstance()->getVocation(vocationId); and then voc->canDualWield(). I see it was used several times in player.cpp code but this seems redundant to me since getVocation() already exists )

Make sure to do this in both left hand and right hand code.

Then in vocation.h change
bool dualwielding= false;
To just
bool dualwielding;

Seems like you are using older c++ version where this is not allowed.
Instead, now we will have to initialize value to this member elsewhere.
Even though XML parser is giving it value after reading it, we still want to have a guarantee that there will be a default value for this attribute.

In vocation.cpp in void Vocation::reset() add:
dualwielding = false;

everything works!!!
thank you so much!

TFS 0.X How to make that only one vocation can use DUALWIELD?

Member

Member

Evil Puncker

Guest

Member

Member

Member

Member

Legendary OT User

Member

Legendary OT User

Member

Legendary OT User

Member

Game Developer & Graphic Designer

Member

Game Developer & Graphic Designer

Member

Similar threads