Improved sudden death damage (ring)

[Darqneez]

Hello, I tried to do a ring that improves sd damage by 100%, but i doesn't work :\
Improved damage works only if ring is in player's ring slot. It's id is in script
Here's code

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TARGETCASTERORTOPMOST, true)
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_DEATHDAMAGE)
setCombatParam(combat, COMBAT_PARAM_EFFECT, CONST_ME_MORTAREA)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, CONST_ANI_SUDDENDEATH)
setCombatFormula(combat, COMBAT_FORMULA_LEVELMAGIC, -1, -60, -1, -60, 5, 5, 9, 12)

local improvedcombat = createCombatObject()
setCombatParam(improvedcombat, COMBAT_PARAM_TARGETCASTERORTOPMOST, true)
setCombatParam(improvedcombat, COMBAT_PARAM_TYPE, COMBAT_DEATHDAMAGE)
setCombatParam(improvedcombat, COMBAT_PARAM_EFFECT, CONST_ME_MORTAREA)
setCombatParam(improvedcombat, COMBAT_PARAM_DISTANCEEFFECT, CONST_ANI_SUDDENDEATH)
setCombatFormula(improvedcombat, COMBAT_FORMULA_LEVELMAGIC, -1, -60, -1, -60, 5, 5, 18, 24)

function onCastSpell(cid, var, item)
    if getPlayerSlotItem(cid, ring) == 7967 then
    return doCombat(cid,improvedcombat,var)
    else
	return doCombat(cid, combat, var)
	end
end

I'll Rep++ for help

 

[Doggynub]

just remove get player slot item, and type

if getPlayerItemCount(cid, itemid) >= 1 then

 

[Darqneez]

But now players can hold this ring in bp and still get its benefits, they can wear other ring in ring slot aswell.

 

[Doggynub]

I thought you want that lol, or what you need?

if getPlayerSlotItem(cid, 9).itemid == 7967 then

It should be liek that if you want it to be in ring slot

 

[JDB]

I just put it all together for you.

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TARGETCASTERORTOPMOST, true)
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_DEATHDAMAGE)
setCombatParam(combat, COMBAT_PARAM_EFFECT, CONST_ME_MORTAREA)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, CONST_ANI_SUDDENDEATH)
setCombatFormula(combat, COMBAT_FORMULA_LEVELMAGIC, -1, -60, -1, -60, 5, 5, 9, 12)
 
local combat2 = createCombatObject()
setCombatParam(combat2, COMBAT_PARAM_TARGETCASTERORTOPMOST, true)
setCombatParam(combat2, COMBAT_PARAM_TYPE, COMBAT_DEATHDAMAGE)
setCombatParam(combat2, COMBAT_PARAM_EFFECT, CONST_ME_MORTAREA)
setCombatParam(combat2, COMBAT_PARAM_DISTANCEEFFECT, CONST_ANI_SUDDENDEATH)
setCombatFormula(combat2, COMBAT_FORMULA_LEVELMAGIC, -1, -60, -1, -60, 5, 5, 18, 24)

function onCastSpell(cid, var, item)
	if getPlayerSlotItem(cid, CONST_SLOT_RING).itemid == 7967 then
		return doCombat(cid, combat2, var)
	else
		return doCombat(cid, combat, var)
	end
end

 

[Darqneez]

Thanks guys I gave JDB rep points, I wanted to give it to damadger too but

You must spread some Reputation around before giving it to Damadger again.

I will be very happy if you take a look at my other problem that hasn't been solved for some days :\ Here (Scroll down a little bit)