TFS 1.X+ Increased loot with rate at 1?

[Unknown Soldier]

Hi,

so I am having that problem since I moved from TFS 1.2 to TFS 1.3. Sometimes creatures drop much more loot than it is specified in xml file, like 6 pieces of something, instead of max 3 that is specified (for stackable items), or two identical items in two separate corpse slots, instead of 1, which is in xml. They are not doubled in xml, neither rateLoot in config isn't, it is at 1. I've searched through files in data folder looking for something suspicious, but no result.

What could be causing this problem?

TFS 1.3 from AppVeyor (Compiled on Dec 14 2020 21:45:15 for platform x64)

An example, take a look at knight armor(s), platinum coins, silver tokens, great spirit potion, red piece of cloth and so on...

And xml looks like this:

    <loot>
        <item name="platinum coin" countmax="22" chance="100000" />
        <item name="silver token" countmax="1" chance="25000" />
        <item name="death toll" countmax="3" chance="80000" />
        <item name="green gem" countmax="1" chance="15000" />
        <item name="violet gem" countmax="1" chance="5000" />
        <item name="white gem" countmax="1" chance="15000" />
        <item name="red crystal fragment" countmax="1" chance="40000" />
        <item name="cyan crystal fragment" countmax="2" chance="41000" />
        <item name="small ruby" countmax="4" chance="42000" />
        <item name="great mana potion" countmax="4" chance="75000" />
        <item name="great spirit potion" countmax="2" chance="75000" />
        <item name="great health potion" countmax="1" chance="66000" />
        <item name="yellow piece of cloth" countmax="2" chance="40000" />
        <item name="white piece of cloth" countmax="2" chance="28000" />
        <item name="red piece of cloth" countmax="2" chance="28000" />
        <item name="focus cape" chance="8000" />
        <item name="knight armor" chance="19000" />
        <item name="fur armor" chance="10000" />
        <item name="warrior's axe" chance="8000" />
        <item id="26187" chance="9000" />         <!-- ring of green plasma -->
        <item id="26199" chance="8000" />         <!-- collar of green plasma -->
        <item name="hailstorm rod" chance="18000" />
    </loot>

 

[Unknown Soldier]

bump!

 

[Nekiro]

Fix use of math.randomseed() and getLootRandom() (#2637) · otland/forgottenserver@f3f5165 (github.com)

 

[Unknown Soldier]

Fix use of math.randomseed() and getLootRandom() (#2637) · otland/forgottenserver@f3f5165 (github.com)

Checked both files, the lines are already there

 

[Evil Puncker]

Checked both files, the lines are already there

they shouldn't be, red means removed, green means added

 

[Unknown Soldier]

they shouldn't be, red means removed, green means added

Ye, I know that, but I did nothing and here's how those parts of files I have look like:

global.lua

math.randomseed(os.time())
dofile('data/lib/lib.lua')

STORAGEVALUE_PROMOTION = 30018

ropeSpots = {384, 418, 8278, 8592, 13189, 14435, 14436, 14857, 15635, 19518, 24621, 24622, 24623, 24624, 26019, 27014, 31640}

function getLootRandom()
    return math.random(0, MAX_LOOTCHANCE) / configManager.getNumber(configKeys.RATE_LOOT)
end

startup.lua

function onStartup()

    db.query("TRUNCATE TABLE `players_online`")
    db.asyncQuery("DELETE FROM `guild_wars` WHERE `status` = 0")

No other part of the code has red lines.

And I've noticed, that probably this problem does not occur always, as if it only happened once in a while, maybe one in several TFS launches (or maybe after /reload all command?). It looks a bit like the function adding loot was launched twice. But that's just my guess. I will be checking this...

@edit
So my suspicion was correct. The problem occurs after /reload all command, it must be executing "default_onDropLoot.lua" too many times (in data\scripts\eventcallbacks\monster\). So after using /reload all 10 times, it will generate much more loot than using it 1 time, so it will run the script 1+10=11 times, giving insane loot.

 

[Evil Hero]

In Talkactions => reload.lua change if param:lower() == "scripts" then to if param:lower() == "scripts" or param:lower() == "all" then
Would be kind if you could open an issue at github aswell, so I can link a pr to it aswell

 

[Unknown Soldier]

In Talkactions => reload.lua change if param:lower() == "scripts" then to if param:lower() == "scripts" or param:lower() == "all" then
Would be kind if you could open an issue at github aswell, so I can link a pr to it aswell

Thanks! I've tested this, seems to be solved.
Issue on github opened.

 

[Evil Hero]

Thanks for reporting ^^