Solved isSorcerer(cid) not working correctly

[whitevo]

Working Code

local spells = {
["Barrier"] = {
actionID = 1102,
vocation = function(cid) return isSorcerer(cid) end,
vocation2 = "sorcerer",
minL = 2
}


}


function onUse(cid, item)
local itemID = item.actionid
local L = getPlayerLevel(cid)
local player = Player(cid)

    for k, v in pairs(spells) do
        if itemID == spells[k].actionID then
          if spells[k].vocation(player) then
                if L >= spells[k].minL then  
                    if  getPlayerLearnedInstantSpell(cid, k) == false then
                        playerLearnInstantSpell(cid, k)
                        player:sendTextMessage(MESSAGE_INFO_DESCR, "you learned " ..k.. " spell")
                        --possibly different text color than default green
                        doRemoveItem(item.uid, 1)
                        return true
                    else player:sendTextMessage(MESSAGE_INFO_DESCR, "You already know this spell")
                        return true
                    end
                else player:sendTextMessage(MESSAGE_INFO_DESCR, "Need level " ..spells[k].minL.. ", to learn this spell")
                    return true
                end  
            else player:sendTextMessage(MESSAGE_INFO_DESCR, "This is "..spells[k].vocation2.." spell")
                --possibly different text color than default green  
            end
        end
    end
end

 

[Evan]

http://otland.net/threads/possible-to-store-functions-in-an-array.227738/#post-2194065

 

[whitevo]

its cool that we can pull functions from tables, but i don't really know what function is isSorcerer using
I tried this(and few others), but its not working

vocation = function(cid) isSorcerer(cid) end,

 

[Evan]

I don't think there's such function similar to isSorcerer() provided by default in 1.0+.
You can easily add them into compat.lua though.

function isSorcerer(cid) return Player(cid):getVocation():getId() == 1 end

Or something similar

 

[Ahilphino]

isSorcerer(player)

works for me in latest tfs gajs, ur script is fuckd up

 

[Evan]

isSorcerer(player)

works for me in latest tfs gajs, ur script is fuckd up

Oh, you're right. It's already in global.lua, I checked compat.
And you're not wrong with the script, it's pretty lousy.

@whitevo
Can you explain exactly what you're trying to do so we can change up the script in its entirety?

 

[whitevo]

if spells[k].vocation then
with this line i want it to take a spell from table and check if requirement vocation == vocation you are.
if not, it should say: what vocation can learn this spell.

 

[Ninja]

vocation = function(cid) return isSorcerer(cid) end,

if spells[k].vocation(player) then

 

[whitevo]

vocation = function(cid) return isSorcerer(cid) end,

if spells[k].vocation(player) then

this is perfect

I don't think there's such function similar to isSorcerer() provided by default in 1.0+.
You can easily add them into compat.lua though.

function isSorcerer(cid) return Player(cid):getVocation():getId() == 1 end

Or something similar

This also works if i put vocation id to table and the getVocation method to function

 

[Codinablack]

vocation = function(cid) return isSorcerer(cid) end,

if spells[k].vocation(player) then

Just like a ninja

 

[whitevo]

Just like a ninja

he came. used 77 characters. left

 

[Jotran]

local spells = {
    ["Barrier"] = {
        AID = 1102,
        vocation = 1, -- 0: none, 1: sorcerer, 2: druid, 3: paladin, 4: knight
        vocation2 = "sorcerer",
        min = 2 -- min level
    }
}


local player = {
    level = 0,
    vocation = 0
}

function onUse(cid, item, fromPosition, itemEx, toPosition)
    local p = Player(cid)
    player.vocation = p:getVocation():getId()
    player.level = p:getLevel()

    for spellname, v in pairs(spells) do
        if item.actionid == spells[spellname].AID and spells[spellname].vocation == player.vocation then
            if player.level >= spells[spellname].min then
                if not p:hasLearnedSpell(spellname) then 
                    p:learnSpell(spellname)
                    --possibly different text color than default green
                    p:sendTextMessage(MESSAGE_INFO_DESCR, "Congratulations "..p:getName().."!!, you have just learned the " ..spellname.. " spell.. :)")
                    Item(item.uid):remove(1)
                else
                    p:sendTextMessage(MESSAGE_INFO_DESCR, p:getName()..", you already know this spell.")
                    return false
                end
            else
                p:sendTextMessage(MESSAGE_INFO_DESCR, p:getName().." you need to be at least level " ..spells[spellname].min.. ", to learn this spell.")
                return false
            end 
        else
            --possibly different text color than default green
            p:sendTextMessage(MESSAGE_INFO_DESCR, "Sorry "..p:getName()..", "..spellname.." is a spell for a "..spells[spellname].vocation2..". :(")
            return false
        end
    end
    return true
end