Item that deals 5% more

[Lopaskurwa]

Hello,
how to make that ring deals 5% more COMBAT_ENERGYDAMAGE
TFS 1.2

 

[Lopaskurwa]

So if you do this

function Creature:onTargetCombat(target)
    if self and target and target:isCreature() then
        self:say(self:getName(), TALKTYPE_MONSTER_SAY)
        target:say(target:getName(), TALKTYPE_MONSTER_SAY)
    end
    return true
end

I also changed isMonster to isCreature (because we want monsters and players, or nay?)

If i do this my name appears on me and creature name appears on creature. Yes we want monster and player

 

[StreamSide]

If i do this my name appears on me and creature name appears on creature. Yes we want monster and player

so add the register event below those say functions and make sure you testing with a energy spell (exori vis) and using the ring (I used wedding,
{2121} --- wedding ring)

 

[Lopaskurwa]

so add the register event below those say functions and make sure you testing with a energy spell (exori vis) and using the ring (I used wedding,
{2121} --- wedding ring)

added and still same

function Creature:onTargetCombat(target)
    if self and target and target:isCreature() then
    self:say(self:getName(), TALKTYPE_MONSTER_SAY)
    target:say(target:getName(), TALKTYPE_MONSTER_SAY)
    target:registerEvent("ringDamage")
    end
    return true
end

yes im using energy spell, and i created exact copy of wedding ring just with different id.

 

[StreamSide]

added and still same

function Creature:onTargetCombat(target)
    if self and target and target:isCreature() then
    self:say(self:getName(), TALKTYPE_MONSTER_SAY)
    target:say(target:getName(), TALKTYPE_MONSTER_SAY)
    target:registerEvent("ringDamage")
    end
    return true
end

yes im using energy spell, and i created exact copy of wedding ring just with different id.

so you added that new id to the table, dont you?

specialRings = {2121, newIdHere},

 

[Lopaskurwa]

so you added that new id to the table, dont you?

specialRings = {2121, newIdHere},

yes tried
specialRings = {2121, 1526},
and
specialRings = {1526},
nothing changed

 

[StreamSide]

Well I dont know, it is working here, maybe try adding some prints to the damageRing script

 

[Lopaskurwa]

Well I dont know, it is working here, maybe try adding some prints to the damageRing script

Like what type of prints? print dmg or what?
Its weird because this one

local specialRings = {2123, 2124}

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
  if not attacker then return true end
  local ring = attacker:getSlotItem(CONST_SLOT_RING)
  if creature then
    if primaryType == COMBAT_ENERGYDAMAGE then
      if table.contains(specialRings, ring.itemid) then
        primaryDamage = primaryDamage * 1.05
        print("> Dealing extra damage")
      end
    end
  end
  return primaryDamage, primaryType, secondaryDamage, secondaryType
end

increased dmg but gave errors, this one where we use fixed all errors but now it doesnt multiply dmg. Mind fuck

 

[StreamSide]

Like what type of prints? print dmg or what?
Its weird because this one

local specialRings = {2123, 2124}

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
  if not attacker then return true end
  local ring = attacker:getSlotItem(CONST_SLOT_RING)
  if creature then
    if primaryType == COMBAT_ENERGYDAMAGE then
      if table.contains(specialRings, ring.itemid) then
        primaryDamage = primaryDamage * 1.05
        print("> Dealing extra damage")
      end
    end
  end
  return primaryDamage, primaryType, secondaryDamage, secondaryType
end

increased dmg but gave errors, this one where we use fixed all errors but now it doesnt multiply dmg. Mind fuck

the last one I modified, just add some prints like everywhere (lmao) and see where its crashing.

 

[Westwol]

This should work, if you want the bonus damage to be applied in monsters you will have to register an event aswell.

local specialRings = {2123, 2124}

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
  if creature and attacker then
    if attacker:isPlayer() then
      local ring = attacker:getSlotItem(CONST_SLOT_RING)
      if ring and primaryType == COMBAT_ENERGYDAMAGE then
        if table.contains(specialRings, ring.itemid) then
          local tmpDamage = primaryDamage
          primaryDamage = primaryDamage * 1.05
          print("> Dealing extra damage | initialDamage: " .. tmpDamage .. " - finalDamage: " .. primaryDamage)
        end
      end
    end
  end
  return primaryDamage, primaryType, secondaryDamage, secondaryType
end

 

[Lopaskurwa]

This should work, if you want the bonus damage to be applied in monsters you will have to register an event aswell.

local specialRings = {2123, 2124}

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
  if creature and attacker then
    if attacker:isPlayer() then
      local ring = attacker:getSlotItem(CONST_SLOT_RING)
      if ring and primaryType == COMBAT_ENERGYDAMAGE then
        if table.contains(specialRings, ring.itemid) then
          local tmpDamage = primaryDamage
          primaryDamage = primaryDamage * 1.05
          print("> Dealing extra damage | initialDamage: " .. tmpDamage .. " - finalDamage: " .. primaryDamage)
        end
      end
    end
  end
  return primaryDamage, primaryType, secondaryDamage, secondaryType
end

Works, thanks.

 

[Itutorial]

Umm also make sure you are checking that it is only applying when damage from a player is happening otherwise even when someone is healing the code will execute. You want to narrow it down perfect for less lag.

nvm just saw the line.....
if ring and primaryType == COMBAT_ENERGYDAMAGE then

 

[sharinn]

Hello, I have a similar script as Mr. Westwol but unfortunately lifeleach/manaleach, stops working through this script (every single moster got this creaturescripts), without this script all work fine