Item upgrade system for TFS 1.3

[Azakelis]

Installation:
1. data/lib/lib.lua add:

-- Item upgrade system
dofile('data/lib/item_upgrade_system/init.lua')

2. data/creaturescripts/creaturescripts.xml add:

    <event type="login" name="UpgradeSystemLogin" event="script" script="item_upgrade_system/onLogin.lua" />
    <event type="kill" name="UpgradeSystemKill" event="script" script="item_upgrade_system/onKill.lua" />
    <event type="healthchange" name="UpgradeSystemHealthChange" event="script" script="item_upgrade_system/onHealthChange.lua" />
    <event type="logout" name="UpgradeSystemLogout" script="item_upgrade_system/onLogout.lua" />

3. data/actions/actions.xml add (you can change item ids, default ones are some unused runes):

    <action itemid="2284" script="item_upgrade_system/upgrade.lua"/>
    <action itemid="2276" script="item_upgrade_system/add_enchant.lua"/>
    <action itemid="2270" script="item_upgrade_system/remove_enchant.lua"/>
    <action itemid="2298" script="item_upgrade_system/remove_enchants.lua"/>
    <action itemid="2272" script="item_upgrade_system/reroll_enchant.lua"/>
    <action itemid="2296" script="item_upgrade_system/reroll_enchants.lua"/>
    <action itemid="2312" script="item_upgrade_system/reroll_tier.lua"/>

4. data/events/events.xml make sure those are enabled:

    <event class="Creature" method="onTargetCombat" enabled="1" />
    <event class="Player" method="onLook" enabled="1" />
    <event class="Monster" method="onDropLoot" enabled="1" />
    <event class="Player" method="onItemMoved" enabled="1" />
    <event class="Player" method="onGainExperience" enabled="1" />

5. data/events/scripts/player.lua:

below:

function Player:onItemMoved(item, count, fromPosition, toPosition, fromCylinder, toCylinder)

add:

self:onItemMovedUpgradeSystem(item, count, fromPosition, toPosition, fromCylinder, toCylinder)

below:

    -- Apply experience stage multiplier
    exp = exp * Game.getExperienceStage(self:getLevel())

add:

    exp = self:onGainExperienceUpgradeSystem(source, exp, rawExp)

6. data/scripts/eventcallbacks/monster/default_onDropLoot.lua:
change:

        for i = 1, #monsterLoot do
            local item = corpse:createLootItem(monsterLoot[i])
            if not item then
                print('[Warning] DropLoot:', 'Could not add loot item to corpse.')
            end
        end

to:

        for i = 1, #monsterLoot do
            local item = corpse:createLootItem(monsterLoot[i])
            if item ~= nil and item:getType():isUpgradable() then
                local randomItemLevel = getRandomItemLevel(mType:getHealth(), mType:getExperience())
                item:setItemLevel(randomItemLevel)
                item:rollItemTier(true)
            end
        end

below:

        if player then

add:

            local itemLevel = calculateItemLevel(mType:getHealth(), mType:getExperience())
            local additionalLoot = getAdditionalLoot(player:getLevel(), itemLevel)
            if additionalLoot ~= nil then
                corpse:addItem(additionalLoot, 1)
            end

7. data/scripts/eventcallbacks/player/deafult_onLook.lua:
below:

local description = "You see " .. thing:getDescription(distance)

add:

    if thing:isPlayer() then
        description = thing:onLookUpgradeSystem(description)
    end

8. data/lib/core/container.lua:
change whole function:

function Container.createLootItem(self, item)

to:

function Container.createLootItem(self, item)
    if self:getEmptySlots() == 0 then
        return nil
    end

    local itemCount = 0
    local randvalue = getLootRandom()
    if randvalue < item.chance then
        if ItemType(item.itemId):isStackable() then
            itemCount = randvalue % item.maxCount + 1
        else
            itemCount = 1
        end
    end

    if itemCount > 0 then
        local tmpItem = self:addItem(item.itemId, math.min(itemCount, 100))
        if not tmpItem then
            return nil
        end

        if tmpItem:isContainer() then
            for i = 1, #item.childLoot do
                if not tmpItem:createLootItem(item.childLoot[i]) then
                    tmpItem:remove()
                    return nil
                end
            end
        end

        if item.subType ~= -1 then
            tmpItem:setAttribute(ITEM_ATTRIBUTE_CHARGES, item.subType)
        end

        if item.actionId ~= -1 then
            tmpItem:setActionId(item.actionId)
        end

        if item.text and item.text ~= "" then
            tmpItem:setText(item.text)
        end
        return tmpItem
    end
    return nil
end

9. data/events/scripts/creature.lua:
below:

function Creature:onTargetCombat(target)

add:

    Creature:onTargetCombatUpgradeSystem(target)

10. unpack scripts from item_upgrade_system.zip to correct folders (same as in zip)

11 buy my onlyfans

 

[Przemyslaw1101]

All works well, great script <3
I recommend this man, he's very helpful

 

[oen432]

I'm sorry but what the fu...? Did you just copy my script and say it's your work?

@Edit
Just got on PC, downloaded, checked and... I really don't want this to be called "remaster of my script". Such mess, such poor quality.

 

[Awesomedudei]

What the actual hekk?

This is @oen432 code.

If you want to copy someones work and change it but keeping 60+% of the code then MAAAAAAAAYBE you should give credit to the one who made almost all of it ?

 

[Azakelis]

If you would like to point out which line of code is stolen I'd be happy to remove it.

 

[oen432]

If you would like to point which line of code is stolen I'd be happy to remove it.

You can't steal from open source unlicensed code.

This is @oen432 code.

Not much of it is left. The thing that bothers me the most is the fact that he advertises this script as "rework of older upgrade system", which is the one I made.

 

[ralke]

@Azakelis I'll try to see how it works, btw, if I use OTX 3.8 and dont have onItemMoved/onDropLoot functions on events, is enough if I take this functions from TFS 1.3 repo and register them on the corresponding file (player.lua, and monster.lua) or I need to change sources?

function Player:onItemMoved(item, count, fromPosition, toPosition, fromCylinder, toCylinder)
    if hasEventCallback(EVENT_CALLBACK_ONITEMMOVED) then
        EventCallback(EVENT_CALLBACK_ONITEMMOVED, self, item, count, fromPosition, toPosition, fromCylinder, toCylinder)
    end
end

function Monster:onDropLoot(corpse)
    if hasEventCallback(EVENT_CALLBACK_ONDROPLOOT) then
        EventCallback(EVENT_CALLBACK_ONDROPLOOT, self, corpse)
    end
end

Then add the changes?
Edit:
Well I can't find where EVENT_CALLBACKS are located on this distribution

GitHub - Fablow77/otx3.8rebirth: [OTX 3.8 - 8.60] OTX Server with REBIRTH, LOOT/TASK CHANNEL, AUTOLOOT, & DAILY TASKS.

[OTX 3.8 - 8.60] OTX Server with REBIRTH, LOOT/TASK CHANNEL, AUTOLOOT, & DAILY TASKS. - Fablow77/otx3.8rebirth

github.com

Guess that the functions I posted won't work, still not able to testing right now, Ik should do the tests before, but I would like to resolve the question anyways ;p

 

[Azakelis]

@Azakelis I'll try to see how it works, btw, if I use OTX 3.8 and dont have onItemMoved/onDropLoot functions on events, is enough if I take this functions from TFS 1.3 repo and register them on the corresponding file (player.lua, and monster.lua) or I need to change sources?

function Player:onItemMoved(item, count, fromPosition, toPosition, fromCylinder, toCylinder)
    if hasEventCallback(EVENT_CALLBACK_ONITEMMOVED) then
        EventCallback(EVENT_CALLBACK_ONITEMMOVED, self, item, count, fromPosition, toPosition, fromCylinder, toCylinder)
    end
end

function Monster:onDropLoot(corpse)
    if hasEventCallback(EVENT_CALLBACK_ONDROPLOOT) then
        EventCallback(EVENT_CALLBACK_ONDROPLOOT, self, corpse)
    end
end

Then add the changes?
Edit:
Well I can't find where EVENT_CALLBACKS are located on this distribution

GitHub - Fablow77/otx3.8rebirth: [OTX 3.8 - 8.60] OTX Server with REBIRTH, LOOT/TASK CHANNEL, AUTOLOOT, & DAILY TASKS.

[OTX 3.8 - 8.60] OTX Server with REBIRTH, LOOT/TASK CHANNEL, AUTOLOOT, & DAILY TASKS. - Fablow77/otx3.8rebirth

github.com

Guess that the functions I posted won't work, still not able to testing right now, Ik should do the tests before, but I would like to resolve the question anyways ;p

Source edit is needed if you don't have these.

 

[ralke]

No chance to do this with a lib? Or maybe just add this without EVENT CALLBACKS

function Player:onItemMoved(item, count, fromPosition, toPosition, fromCylinder, toCylinder)
self:onItemMovedUpgradeSystem(item, count, fromPosition, toPosition, fromCylinder, toCylinder)
end

The lines you mentioned to change on step #6 and #7 are writen on players.lua and monsters.lua instead of scripts/eventscallback folder.
Example (this appears on the mentioned .lua files):

local description = "You see " .. thing:getDescription(distance)

And this can be applied to monsters.lua (I don't see functions that does not belong to sources):

        for i = 1, #monsterLoot do
            local item = corpse:createLootItem(monsterLoot[i])
            if not item then
                print('[Warning] DropLoot:', 'Could not add loot item to corpse.')
            end
        end

Sorry for asking without testing, again. Anyways if this not worth trying, which changes should I do to sources?
Edit:
Well I think this responds all. Thx

 

[Sarah Wesker]

You should include a description of what is new in the system
Because the truth is I have no idea what your code is about, it only refers to what improves the items, but what does it improve?, because if you have things other than the @oen432 system, it would be good to know , otherwise just bumb to the thread of oen would be enough