TFS 1.X+ Item with actionID unpickupable to slots or container

[Tibia Demon]

How can I make an item with actionID unpickupable to both slot and container?

 

[zbizu]

return false on event player:onMoveItem (data/events/player.lua) when item:getActionId() == yourActionId

same has to be applied to trading

 

[Tibia Demon]

I have added it like this but I still can pick it to container and slot.

        if (item:getActionId() == 8979) then
            self:sendCancelMessage(RETURNVALUE_NOTPOSSIBLE)
            return false
        end

 

[zbizu]

data/events/events.xml set enabled to 1

or try returning true instead

 

[Tibia Demon]

Working I only had to move it under the function.
I had it in bottom of the function.

 

[Xikini]

Working I only had to move it under the function.
I had it in bottom of the function.

Additionally, make sure the player can't trade the item with another player.

and if the item has a 'use with' option, make sure that the player can't 'use with' something in the distance, that forces the player to walk over to the item, have the server pick it up into their inventory, then walk to whatever distant location to attempt to use the item.

 

[zbizu]

Additionally, make sure the player can't trade the item with another player.

and if the item has a 'use with' option, make sure that the player can't 'use with' something in the distance, that forces the player to walk over to the item, have the server pick it up into their inventory, then walk to whatever distant location to attempt to use the item.

if I remember correctly, it was patched already, though testing that won't hurt

 

[Xikini]

if I remember correctly, it was patched already, though testing that won't hurt

ah nice. xP

 

[Tibia Demon]

Additionally, make sure the player can't trade the item with another player.

and if the item has a 'use with' option, make sure that the player can't 'use with' something in the distance, that forces the player to walk over to the item, have the server pick it up into their inventory, then walk to whatever distant location to attempt to use the item.

if I remember correctly, it was patched already, though testing that won't hurt

I had to add it to PlayernTradeRequest to avoid players trading item [I tested without adding it and players were able to trade and take the item with actionID]
Where should I add it to avoid [use with]? I have just tested it with rune and players can use it.

 

[zbizu]

Move events fix by nekiro · Pull Request #2834 · otland/forgottenserver

Fix #2447

github.com

 

[Tibia Demon]

What this commits supposed to do? If its to avoid trading items with actionID then it doesn't work
Because I can trade items that has actionID without any restrictions unless I added this to player.lua

function Player:onTradeRequest(target, item)
    if item:getActionId() == BLOCK_ITEM_WITH_ACTION then
        self:sendCancelMessage(RETURNVALUE_NOTPOSSIBLE)
        return false
end

 

[kamilcioo]

What this commits supposed to do? If its to avoid trading items with actionID then it doesn't work
Because I can trade items that has actionID without any restrictions unless I added this to player.lua

function Player:onTradeRequest(target, item)
    if item:getActionId() == BLOCK_ITEM_WITH_ACTION then
        self:sendCancelMessage(RETURNVALUE_NOTPOSSIBLE)
        return false
end

Its to block items with specified aid.

 

[zbizu]

What this commits supposed to do?

When item is on the ground and player clicks use with on some far tile, it fixes the bug that allowed the player to pick that item up despite the item being blocked with a script