[Lua] Script Problem

Lava Titan · Nov 16, 2009

Sup guys.
I'm using this script:

LUA:

local cost = 1000000
local newItem = {7388, 1}

function onUse(cid, item, fromPosition, itemEx, toPosition)
        if doPlayerRemoveMoney(cid, cost) == FALSE then
                doPlayerSendTextMessage(cid, 26, "You need "..cost.." gold coins for "..newItem[2].."x "..getItemNameById(newItem[1])..".")
                doSendMagicEffect(getCreaturePosition(cid), 2)
                return TRUE
        end
       
        if item.itemid == 1945 then
                doTransformItem(item.uid, 1946)
        else
                doTransformItem(item.uid, 1945)
        end

        doPlayerAddItem(cid, newItem[1], newItem[2])
        doPlayerSendTextMessage(cid, 22, "You bought "..newItem[2].."x "..getItemNameById(newItem[1]).." for "..cost..".")
        return TRUE
end

for shop levers but the problem is even if the player doesnt have money to buy the item he will get the item anyway ...

Example: You dont got money and you still get the item without paying.

Can some1 help me fixing it?

Thanks for every1 that helps
Rep++ for every1 that helps to.

Regards
Lava Titan

zakius · Nov 16, 2009

LUA:

local cost = 1000000
local newItem = {7388, 1}

function onUse(cid, item, fromPosition, itemEx, toPosition)
        if doPlayerRemoveMoney(cid, cost) == FALSE then
                doPlayerSendTextMessage(cid, 26, "You need "..cost.." gold coins for "..newItem[2].."x "..getItemNameById(newItem[1])..".")
                doSendMagicEffect(getCreaturePosition(cid), 2)
	else        
		doPlayerAddItem(cid, newItem[1], newItem[2])
		doPlayerSendTextMessage(cid, 22, "You bought "..newItem[2].."x "..getItemNameById(newItem[1]).." for "..cost..".")
        end
       
        if item.itemid == 1945 then
                doTransformItem(item.uid, 1946)
        else
                doTransformItem(item.uid, 1945)
        end
        return TRUE
end

Should work, but its not tested
Honestly I would do sth like that kind of

Code:

if doPlayerRemoveMoney(cid, cost) == TRUE
add item
else
show error communicate

but this one should work too

Cykotitan · Nov 17, 2009

TFS version?

Lava Titan · Nov 17, 2009

@Zakius

doesnt work =/
it keeps giving the item even if the player doesnt have money

@Cykotitan

0.3.5pl1

Lava Titan · Nov 17, 2009

I tested another scripts to, like "Buy bp of pot and when i buy the bp there are noting inside...

LUA:

function onUse(cid, item, frompos, item2, topos)

container = doPlayerAddItem(cid, 5926, 1)

if item.itemid == 1945 and doPlayerRemoveMoney(cid,4000) == 1 then
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doTransformItem(item.uid,item.itemid+1)

elseif item.itemid == 1946 and doPlayerRemoveMoney(cid,4000) == 1 then
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doAddContainerItem(container, 8473, 7)
doTransformItem(item.uid,item.itemid-1)

else
doPlayerSendCancel(cid,"Sorry, you don't have enough money!")
end
return 1
end

Lava Titan · Nov 18, 2009

bumpzor

Cykotitan · Nov 18, 2009

Code:

local config = {
	price = 4000,
	backpack = 5926,
	itemid = 8473,
	subtype = 1
}
function onUse(cid, item, fromPosition, itemEx, toPosition)
	if(getPlayerMoney(cid) >= config.price) then
		local container = doCreateItemEx(config.backpack, 1)
		for i = 1, getContainerCapById(config.backpack) do
			doAddContainerItem(container, config.itemid, config.subtype)
		end
		if(doPlayerAddItemEx(cid, container, false) ~= RETURNVALUE_NOERROR) then
			doPlayerSendCancel(cid, getPlayerFreeCap(cid) < getItemWeight(container) and "You don't have enough capacity." or "You don't have enough room to take it.")
		else
			doPlayerRemoveMoney(cid, config.price)
			doTransformItem(item.uid, item.itemid == 1945 and 1946 or 1945)
		end
	else
		doPlayerSendCancel(cid, "You don't have enough money.")
	end
	return TRUE
end

Lava Titan · Nov 18, 2009

now i get the backpack but theres notin inside =/

Cykotitan · Nov 18, 2009

Lava Titan said:
now i get the backpack but theres notin inside =/

Updated

Lava Titan · Nov 18, 2009

works perfectly rep++ but can you help me fixing this one to?

LUA:

  local cost = 1000000
local newItem = {7388, 1}

function onUse(cid, item, fromPosition, itemEx, toPosition)
        if doPlayerRemoveMoney(cid, cost) == FALSE then
                doPlayerSendTextMessage(cid, 26, "You need "..cost.." gold coins for "..newItem[2].."x "..getItemNameById(newItem[1])..".")
                doSendMagicEffect(getCreaturePosition(cid), 2)
                return TRUE
        end
       
        if item.itemid == 1945 then
                doTransformItem(item.uid, 1946)
        else
                doTransformItem(item.uid, 1945)
        end

        doPlayerAddItem(cid, newItem[1], newItem[2])
        doPlayerSendTextMessage(cid, 22, "You bought "..newItem[2].."x "..getItemNameById(newItem[1]).." for "..cost..".")
        return TRUE
end

On this one i get the item without paying.
But only 1 item without backpacks

Cykotitan · Nov 18, 2009

Code:

local config = {
	cost = 1000000,
	newItem = {7388, 1}
}
function onUse(cid, item, fromPosition, itemEx, toPosition)
	if(not(doPlayerRemoveMoney(cid, config.cost))) then
		doPlayerSendTextMessage(cid, 26, "You need "..config.cost.." gold coins for "..config.newItem[2].."x "..getItemNameById(config.newItem[1])..".")
		doSendMagicEffect(getCreaturePosition(cid), 2)
		return true
	end
	doTransformItem(item.uid, item.itemid == 1945 and 1946 or 1945)
	doPlayerAddItem(cid, config.newItem[1], config.newItem[2])
	doPlayerSendTextMessage(cid, 22, "You bought "..config.newItem[2].."x "..getItemNameById(config.newItem[1]).." for "..config.cost.." gold coins.")
	return true
end

Erikas Kontenis · Nov 18, 2009

@up not tested but should work

LUA:

function onUse(cid, item, fromPosition, itemEx, toPosition)
        if item.uid == xxxx then -- unique id of switch
                doPlayerSendTextMessage(cid, 26, "You need 1000000 gold coins for Vile axe.")
				doPlayerAddItem(cid,7388,1)
                doSendMagicEffect(getCreaturePosition(cid), 2)
				doPlayerRemoveMoney(cid,1000000)
                return TRUE
        end
       
        if item.itemid == 1945 then
                doTransformItem(item.uid, 1946)
        else
                doTransformItem(item.uid, 1945)
        end

        doPlayerAddItem(cid, newItem[1], newItem[2])
        doPlayerSendTextMessage(cid, 22, "You bought Vile axe for 1000000 gold coins.")
        return TRUE
end

Erikas Kontenis · Nov 18, 2009

@Cykotian

Damn Too late

@@lava titan, can you test mine script too

im learning lua

Cykotitan · Nov 18, 2009

apsivaflines said:
@Cykotian

Damn Too late

@@lava titan, can you test mine script too im learning lua

Your script wouldn't work correctly. It seems you still have much to learn.
Also, please use

Code:

[/B] tags instead of [B][code=lua][/B]

Erikas Kontenis · Nov 18, 2009

Cykotitan said:
Your script wouldn't work correctly. It seems you still have much to learn.
Also, please use

Code:

[/B] tags instead of [B][code=lua][/B][/QUOTE] Wanna Tell me why you using this way? [code]local config = { cost = 1000000, newItem = {7388, 1} }

Cykotitan · Nov 18, 2009

apsivaflines said:
Wanna Tell me why you using this way?

Code:

local config = { cost = 1000000, newItem = {7388, 1} }

Because it preserves tabbing.

Lava Titan · Nov 18, 2009

Code:

local config = {
	cost = 1000000,
	newItem = {7388, 1}
}
function onUse(cid, item, fromPosition, itemEx, toPosition)
	if(not(doPlayerRemoveMoney(cid, config.cost))) then
		doPlayerSendTextMessage(cid, 26, "You need "..config.cost.." gold coins for "..config.newItem[2].."x "..getItemNameById(config.newItem[1])..".")
		doSendMagicEffect(getCreaturePosition(cid), 2)
		return true
	end
	doTransformItem(item.uid, item.itemid == 1945 and 1946 or 1945)
	doPlayerAddItem(cid, config.newItem[1], config.newItem[2])
	doPlayerSendTextMessage(cid, 22, "You bought "..config.newItem[2].."x "..getItemNameById(config.newItem[1]).." for "..config.cost.." gold coins.")
	return true
end

works fine!
but last requirement =p
buying this item not for money but for another item
i made a new type of coins but that can only be used for special armors
id of coin 9970

Lava Titan · Nov 18, 2009

Code:

local config = {
	oldItem = {9970, 2}
	newItem = {7388, 1}
}

would this work?

Erikas Kontenis · Nov 18, 2009

Lava Titan said:
Code:

local config = { oldItem = {9970, 2} newItem = {7388, 1} }

would this work?

ofc it must work

i wanna try

Erikas Kontenis · Nov 18, 2009

please test it and say me where problems

or mayby no problems

Code:

local config = {
	oldItem = {9970, 2}
	newItem = {7388, 1}
}
function onUse(cid, item, fromPosition, itemEx, toPosition)
	if(not(doPlayerRemoveItem(cid, config.oldItem))) then
		doPlayerSendTextMessage(cid, 26, "You need "..config.oldItem.." for "..config.newItem[2].."x "..getItemNameById(config.newItem[1])..".")
		doSendMagicEffect(getCreaturePosition(cid), 2)
		return true
	end
	doTransformItem(item.uid, item.itemid == 1945 and 1946 or 1945)
	doPlayerAddItem(cid, config.newItem[1], config.newItem[2])
	doPlayerSendTextMessage(cid, 22, "You bought "..config.newItem[2].."x "..getItemNameById(config.newItem[1]).." for "..config.oldItem..".")
	return true
end

[Lua] Script Problem

Developer

Enter the Ninja!

Experienced G'

Developer

Developer

Developer

Experienced G'

Developer

Experienced G'

Developer

Experienced G'

Excellent OT User

Excellent OT User

Experienced G'

Excellent OT User

Experienced G'

Developer

Developer

Excellent OT User

Excellent OT User