Solved MAGIC WALL REMOVE WHEN DOWN STAIRS

[Izaack]

Good evening, how are you, could someone help me solve this error that I have with the magic wall rune, when you go down a ladder I need it to be eliminated. I am using Nekiro tfs 1.5

.​

 

[Izaack]

Any?

 

[Dakos]

U can check in movement(onStepIn) event if you stepdown from stairs it return the magic wall id, if yes, then you can just simply use item:remove(), if not you have to dig in source

 

[Rodogd]

How did you solve this?

 

[Felipe93]

How did you solve this?

there you go Remove MAGIC WALL and WILD GROWTH when step in (https://otland.net/threads/remove-magic-wall-and-wild-growth-when-step-in.264279/)

 

[Rodogd]

Thanks!

I figured it out before your response by adding:

// remove magic walls/wild growth
    if (id == ITEM_MAGICWALL_SAFE || id == ITEM_WILDGROWTH_SAFE || isBlocking()) {
        if (!creature->isInGhostMode()) {
            g_game.internalRemoveItem(this, 1);
        }

        return;
    }

At the beginning of this method in combat.cpp

void MagicField::onStepInField(Creature* creature)

The comment you referenced seems more suitable for a non-PVP server, mine is PVP, but I still appreciate your help.

 

[Felipe93]

Thanks!

I figured it out before your response by adding:

In

void MagicField::onStepInField(Creature* creature)

// remove magic walls/wild growth
    if (id == ITEM_MAGICWALL_SAFE || id == ITEM_WILDGROWTH_SAFE || isBlocking()) {
        if (!creature->isInGhostMode()) {
            g_game.internalRemoveItem(this, 1);
        }

        return;
    }

In combat.cpp

The comment you referenced seems more suitable for a non-PVP server, mine is PVP, but I still appreciate your help.

its works for all servers not just in non pvp, glad to know you solved it by yourself although

 

[VitoxMaster]

I will leave it here if someone doesn't need handling PVP events and doesn't want to change C++ sources:

function onStepIn(creature, item, position, fromPosition)
    if not creature:isPlayer() then
        return false
    end
    if(position.z == fromPosition.z) then
        return false
    end
    position:sendMagicEffect(CONST_ME_EXPLOSIONAREA)
    item:remove()
    return true
end

And changing movements.xml

<movevent event="StepIn" itemid="1497" script="magic_wall.lua" />

Sharing because I don't see floor conditions in previous solutions.

 

[3alola1]

Thanks!

I figured it out before your response by adding:

In

void MagicField::onStepInField(Creature* creature)

// remove magic walls/wild growth
    if (id == ITEM_MAGICWALL_SAFE || id == ITEM_WILDGROWTH_SAFE || isBlocking()) {
        if (!creature->isInGhostMode()) {
            g_game.internalRemoveItem(this, 1);
        }

        return;
    }

In combat.cpp

The comment you referenced seems more suitable for a non-PVP server, mine is PVP, but I still appreciate your help.

Idk why he manged to remove this line from the original tfs but yeah this is absolutly the solution

 

[Rodogd]

Somehow it was not included in the TFS 1.5 Downgrade by Nekiro 8.60

TFS-1.5-Downgrades/src/combat.cpp at fc9157b919405ecde6f30e471255be4e2746884e · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com