dfs1
Member
- Joined
- Aug 27, 2011
- Messages
- 82
- Solutions
- 1
- Reaction score
- 8
There were many bugs in otservbr market/gamestore that let people clone items/money/TC. otservbr owners should be prepared.I really don't know how to solve that, that's why I ask for help but I don't want everyone to know this because it would be chaos for the servers that are already open.
Im not so familiar with TFS code, but running the code inside theTested on 1.4, 1.4.1, master branch and my fork.
Tfs: Not bugged.
Canary: probably not bugged (looking at the code)
old otbr engine: probably bugged (looking at the code)
The bugged instruction:
https://github.com/opentibiabr/otse...e5a1acd9480733338f065/src/game/game.cpp#L7470 (note: this is outdated, otservbr-global uses canary now afaik)
The situation that isn't handled in the code above:
tl;dr fix: copy the "if" block with "return" statement from the second link to your server and compile
Ye. That's a problem. Big OTS owners know these bugs, but do not tell anyone. They use them to destroy servers of competitors.plus most otadmins didn't knew how to replicate. A couple of servers were not affected as they bought the fix without ever telling us about it
I've been there, but luckily for me I'm only here for learning and hobby and I usually turn down clients that don't care about sharing crashes with the open source community. We need ASAP to convince those people to migrate to a "bounty" format because this is starting to bite otadmins in the back already.Ye. That's a problem. Big OTS owners know these bugs, but do not tell anyone. They use them to destroy servers of competitors.
I would not care about publishing bugs like that with reason "what would happen to big otses". THEY do not care about open source community. We should not care about them.
Sometimes I work for big 12+ OTSes. They are ready to pay up to 10 times more, if I do not publish fixes on github.
Is there a solution for this?