TFS 1.X+ market system debug otclient

[johnsamir]

My server is tfs 1.5 - 8.6

i have enable market susccesfullly, but when i want to choose an item from the itemmarket list i get the client crashed

in terminal i can see this

ERROR: Unable to send extended opcode 201, extended opcodes are not enabled on this server.
ERROR: ProtocolGame parse message exception (50 bytes, 27 unread, last opcode is 0x00 (0), prev opcode is 0xf6 (246)): InputMessage eof reached
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 860)

in the otclient log i get the same error too

ERROR: Unable to send extended opcode 201, extended opcodes are not enabled on this server.
ERROR: ProtocolGame parse message exception (50 bytes, 27 unread, last opcode is 0x00 (0), prev opcode is 0xf6 (246)): InputMessage eof reached
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 860)

 

[highsanta]

can you show me the commits that you have made?

particularly this:

// OTCv8
void ProtocolGame::sendFeatures()  // << THIS WHOLE FUNCTION missing?
{
    if (!otclientV8)
        return;

    std::map<GameFeature, bool> features;
    // place for non-standard OTCv8 features
    features[GameExtendedOpcode] = true;
    features[GameExtendedClientPing] = true;
    features[GameWingsAndAura] = true;
    features[GameOutfitShaders] = true;
    features[GamePlayerMarket] = true;  // << THIS IS IMPORTANT
    if (features.empty())
        return;

    NetworkMessage msg;
    msg.addByte(0x43);
    msg.add<uint16_t>(features.size());
    for (auto& feature : features) {
        msg.addByte((uint8_t)feature.first);
        msg.addByte(feature.second ? 1 : 0);
    }
    writeToOutputBuffer(msg);
}

 

[johnsamir]

i've made multiple commits the repository is private i might show you them via anydesk or teamviewer hit me up with a msg if you can help me with this

// OTCv8
void ProtocolGame::sendFeatures()
{
    if(!otclientV8)
        return;

    std::map<GameFeature, bool> features;
    // place for non-standard OTCv8 features
    features[GameExtendedOpcode] = true;
    features[GameEnvironmentEffect] = false; // disable it, useless 2 byte with every tile
    features[GameExtendedClientPing] = true;

    if(features.empty())
        return;

    NetworkMessage msg;
    msg.addByte(0x43);
    msg.add<uint16_t>(features.size());
    for(auto& feature : features) {
        msg.addByte((uint8_t)feature.first);
        msg.addByte(feature.second ? 1 : 0);
    }
    writeToOutputBuffer(msg);
}

going to add this

    features[GamePlayerMarket] = true;  // << THIS IS IMPORTANT

and review
edit: error persists

 

[johnsamir]

Up