Solved Monster no hit summon moster

[Natan Beckman]

The monster no attack summon moster:
Help
Code:

    else if(target->getMonster())
    {
        if(attacker->getMonster())
            return RET_YOUMAYNOTATTACKTHISCREATURE;

        if(!target->isAttackable())
            return RET_YOUMAYNOTATTACKTHISCREATURE;

        const Player* attackerPlayer = NULL;
        if((attackerPlayer = attacker->getPlayer()) || (attackerPlayer = attacker->getPlayerMaster()))
        {
            if(attackerPlayer->hasFlag(PlayerFlag_CannotAttackMonster))
                return RET_YOUMAYNOTATTACKTHISCREATURE;

            if(target->isPlayerSummon())
            {
                checkZones = true;
                if(g_game.getWorldType() == WORLDTYPE_OPTIONAL && !Combat::isInPvpZone(attacker, target)
                    && !attackerPlayer->isEnemy(target->getPlayerMaster(), true))
                    return RET_YOUMAYNOTATTACKTHISCREATURE;
            }
        }
    }

Complete code combat.cpp:
http://pastebin.com/b1whZ9dn

 

[Natan Beckman]

bump

 

[Summ]

if(attacker->getMonster() && !attacker->getPlayerMaster())

 

[Natan Beckman]

if(attacker->getMonster() && !attacker->getPlayerMaster())

Summ Sorry, i'm newbie how i add code?

Look:

    else if(target->getMonster())
    {
        if(attacker->getMonster() && !attacker->getPlayerMaster())
            return RET_YOUMAYNOTATTACKTHISCREATURE;
      
        if(attacker->getMonster())
            return RET_YOUMAYNOTATTACKTHISCREATURE;

        if(!target->isAttackable())
            return RET_YOUMAYNOTATTACKTHISCREATURE;

        const Player* attackerPlayer = NULL;
        if((attackerPlayer = attacker->getPlayer()) || (attackerPlayer = attacker->getPlayerMaster()))
        {
            if(attackerPlayer->hasFlag(PlayerFlag_CannotAttackMonster))
                return RET_YOUMAYNOTATTACKTHISCREATURE;

            if(target->isPlayerSummon())
            {
                checkZones = true;
                if(g_game.getWorldType() == WORLDTYPE_OPTIONAL && !Combat::isInPvpZone(attacker, target)
                    && !attackerPlayer->isEnemy(target->getPlayerMaster(), true))
                    return RET_YOUMAYNOTATTACKTHISCREATURE;
            }
        }
    }

OR

    else if(target->getMonster())
    {
        if(attacker->getMonster())
            return RET_YOUMAYNOTATTACKTHISCREATURE;

        if(!target->isAttackable())
            return RET_YOUMAYNOTATTACKTHISCREATURE;

        const Player* attackerPlayer = NULL;
        if(attacker->getMonster() && !attacker->getPlayerMaster())
        {
            if(attackerPlayer->hasFlag(PlayerFlag_CannotAttackMonster))
                return RET_YOUMAYNOTATTACKTHISCREATURE;

            if(target->isPlayerSummon())
            {
                checkZones = true;
                if(g_game.getWorldType() == WORLDTYPE_OPTIONAL && !Combat::isInPvpZone(attacker, target)
                    && !attackerPlayer->isEnemy(target->getPlayerMaster(), true))
                    return RET_YOUMAYNOTATTACKTHISCREATURE;
            }
        }
    }

 

[Summ]

The first

 

[Natan Beckman]

The first

No solved :C
i tested all

 

[Summ]

if(attacker->getMonster() && !target->getPlayerMaster())

 

[Natan Beckman]

if(attacker->getMonster() && !target->getPlayerMaster())

I ADD Summ, no solved:

    else if(target->getMonster())
    {
        if(attacker->getMonster() && !target->getPlayerMaster())
            return RET_YOUMAYNOTATTACKTHISCREATURE;
        
        if(attacker->getMonster())
            return RET_YOUMAYNOTATTACKTHISCREATURE;

        if(!target->isAttackable())
            return RET_YOUMAYNOTATTACKTHISCREATURE;

        const Player* attackerPlayer = NULL;
        if((attackerPlayer = attacker->getPlayer()) || (attackerPlayer = attacker->getPlayerMaster()))
        {
            if(attackerPlayer->hasFlag(PlayerFlag_CannotAttackMonster))
                return RET_YOUMAYNOTATTACKTHISCREATURE;

            if(target->isPlayerSummon())
            {
                checkZones = true;
                if(g_game.getWorldType() == WORLDTYPE_OPTIONAL && !Combat::isInPvpZone(attacker, target)
                    && !attackerPlayer->isEnemy(target->getPlayerMaster(), true))
                    return RET_YOUMAYNOTATTACKTHISCREATURE;
            }
        }
    }

 

[Summ]

Remove this:
if(attacker->getMonster())
return RET_YOUMAYNOTATTACKTHISCREATURE;

 

[Natan Beckman]

Perfect Summ you is the best!
Thanks a lot.

 

[Natan Beckman]

Hello Summ
The monster attack monster summon
the monster summon no attack monster =/

 

[Natan Beckman]

bump

 

[Natan Beckman]

bump

 

[Natan Beckman]

bump

 

[Natan Beckman]

After several tests.
I Solved:

    else if(target->getMonster())
    {
        if(attacker->getMonster() && !target->getPlayerMaster() && !attacker->getPlayerMaster())
            return RET_YOUMAYNOTATTACKTHISCREATURE;
           
        if(!target->isAttackable())
            return RET_YOUMAYNOTATTACKTHISCREATURE;

        const Player* attackerPlayer = NULL;
        if((attackerPlayer = attacker->getPlayer()) || (attackerPlayer = attacker->getPlayerMaster()))
        {
            if(attackerPlayer->hasFlag(PlayerFlag_CannotAttackMonster))
                return RET_YOUMAYNOTATTACKTHISCREATURE;

            if(target->isPlayerSummon())
            {
                checkZones = true;
                if(g_game.getWorldType() == WORLDTYPE_OPTIONAL && !Combat::isInPvpZone(attacker, target)
                    && !attackerPlayer->isEnemy(target->getPlayerMaster(), true))
                    return RET_YOUMAYNOTATTACKTHISCREATURE;
            }
        }
    }