MyACC characters how to show kills

SixNine · Apr 24, 2021

Hi i have custom character page and for some reason it doesnt show kills it always stays at zero

i think its these code parts

PHP:

                '.$twig->render('characters.html.twig', array(
                    'outfit' => isset($outfit) ? $outfit : null,
                    'player' => $player,
                    'account' => $account,
                    'flag' => $flag,
                    'frags_enabled' => $frags_enabled,
                    'frags_count' => $frags_count,
                    'skills' => isset($skills) ? $skills : null,
                    'skull' => $player->getSkullTime() > 0 && ($player->getSkull() == 4 || $player->getSkull() == 5) ? $skulls[$player->getSkull()] : null,
                    'deaths' => $deaths,
                    'frags' => $frags,
                    'player_link' => getPlayerLink($player->getName(), false),
                    'hidden' => $hidden,
                    'bannedUntil' => isset($bannedUntil) ? $bannedUntil : null,
                    'characters_link' => getLink('characters'),
                    'account_players' => isset($account_players) ? $account_players : null,
                    'achievements' => $playerAchievements,
                    'search_form' => generate_search_form()
                )).'

PHP:

    $frags_enabled = tableExist('player_killers') && $config['characters']['frags'];
    $frags_count = 0;
    if($frags_enabled) {
        $query = $db->query(
            'SELECT COUNT(`player_id`) as `frags`' .
            'FROM `player_killers`' .
            'WHERE `player_id` = ' .$player->getId() . ' ' .
            'GROUP BY `player_id`' .
            'ORDER BY COUNT(`player_id`) DESC');
        
        if($query->rowCount() > 0)
        {
            $query = $query->fetch();
            $frags_count = $query['frags'];
        }
    }

PHP:

    $frags = array();
    $frag_add_content = '';
    if($config['characters']['frags'])
    {
        //frags list by Xampy
        $i = 0;
        $frags_limit = 10; // frags limit to show? // default: 10
        $player_frags = $db->query('SELECT `player_deaths`.*, `players`.`name`, `killers`.`unjustified` FROM `player_deaths` LEFT JOIN `killers` ON `killers`.`death_id` = `player_deaths`.`id` LEFT JOIN `player_killers` ON `player_killers`.`kill_id` = `killers`.`id` LEFT JOIN `players` ON `players`.`id` = `player_deaths`.`player_id` WHERE `player_killers`.`player_id` = '.$player->getId().' ORDER BY `date` DESC LIMIT 0,'.$frags_limit.';')->fetchAll();
        if(count($player_frags))
        {
            $row_count = 0;
            foreach($player_frags as $frag)
            {
                $description = 'Fragged <a href="' . getPlayerLink($frag['name'], false) . '">' . $frag['name'] . '</a> at level ' . $frag['level'];
                $frags[] = array('time' => $frag['date'], 'description' => $description, 'unjustified' => $frag['unjustified'] != 0);
            }
        }
    }

SixNine · Apr 25, 2021

slaw · Apr 25, 2021

What version of TFS? 1.x or 0.3?

SixNine · Apr 25, 2021

slaw said:
What version of TFS? 1.x or 0.3?

tfs 1.2

slaw · Apr 25, 2021

Then the query should be:

Code:

SELECT COUNT(`player_deaths`.`killed_by`) as frags
FROM `player_deaths`
WHERE `player_deaths`.`killed_by` = ' . $db->quote($player->getName()) . '
AND `player_deaths`.`unjustified` = 1

Because TFS 1.2 uses player_deaths table.

Post automatically merged: Apr 25, 2021

Also, change this:

Code:

$frags_enabled = tableExist('player_killers') && $config['characters']['frags'];

To:

Code:

$frags_enabled = tableExist('player_deaths') && $config['characters']['frags'];

SixNine · Apr 25, 2021

slaw said:
Then the query should be:

Code:

SELECT COUNT(`player_deaths`.`killed_by`) as frags FROM `player_deaths` WHERE `player_deaths`.`killed_by` = ' . $db->quote($player->getName()) . ' AND `player_deaths`.`unjustified` = 1

Because TFS 1.2 uses player_deaths table.

Post automatically merged: Apr 25, 2021

Also, change this:

Code:

$frags_enabled = tableExist('player_killers') && $config['characters']['frags'];

To:

Code:

$frags_enabled = tableExist('player_deaths') && $config['characters']['frags'];

So weird that its player_deaths

but im getting
Parse error: syntax error, unexpected 'COUNT' (T_STRING), expecting ')' in C:\xampp\htdocs\system\pages\characters.php on line 130

Code:

$frags_enabled = tableExist('player_deaths') && $config['characters']['frags']; $frags_count = 20; if($frags_enabled) { $query = $db->query( SELECT COUNT(`player_deaths`.`killed_by`) as frags FROM `player_deaths` WHERE `player_deaths`.`killed_by` = ' . $db->quote($player->getName()) . ' AND `player_deaths`.`unjustified` = 1 if($query->rowCount() > 20) { $query = $query->fetch(); $frags_count = $query['frags']; } }

slaw · Apr 25, 2021

PHP:

    $frags_enabled = tableExist('player_deaths') && $config['characters']['frags'];
    $frags_count = 20;
    if($frags_enabled) {
        $query = $db->query(
            'SELECT COUNT(`player_deaths`.`killed_by`) as frags
            FROM `player_deaths`
            WHERE `player_deaths`.`killed_by` = ' . $db->quote($player->getName()) . '
            AND `player_deaths`.`unjustified` = 1');
        
        if($query->rowCount() > 20)
        {
            $query = $query->fetch();
            $frags_count = $query['frags'];
        }
    }

SixNine · Apr 25, 2021

slaw said:

PHP:

    $frags_enabled = tableExist('player_deaths') && $config['characters']['frags'];
    $frags_count = 20;
    if($frags_enabled) {
        $query = $db->query(
            'SELECT COUNT(`player_deaths`.`killed_by`) as frags
            FROM `player_deaths`
            WHERE `player_deaths`.`killed_by` = ' . $db->quote($player->getName()) . '
            AND `player_deaths`.`unjustified` = 1');
       
        if($query->rowCount() > 20)
        {
            $query = $query->fetch();
            $frags_count = $query['frags'];
        }
    }

Hmm it doesnt work :/

Last Kill page
Player1 died at level 101 by Player2.

Player1 character page
Killed at level 101 by Player2..

But Player2 still have 0 Kills. Tried clearing cache, using different browsers but still zero

slaw · Apr 25, 2021

Change this:

Code:

if($query->rowCount() > 20)

20 to 0

SixNine · Apr 25, 2021

slaw said:
Change this:

Code:

if($query->rowCount() > 20)

20 to 0

Still 0

slaw · Apr 25, 2021

Are you sure it was unjustified kill? Check in database, table player_deaths, if there is anything with "unjustified" set to 1.

SixNine · Apr 25, 2021

slaw said:
Are you sure it was unjustified kill? Check in database, table player_deaths, if there is anything with "unjustified" set to 1.

Yes as you can see those two deaths are unjustified and it says killed by Test2 and mostdamage_by Test2

slaw · Apr 25, 2021

Weird, try to paste this into PhpMyAdmin and see if there are any results:

Code:

SELECT COUNT(`player_deaths`.`killed_by`) as frags
            FROM `player_deaths`
            WHERE `player_deaths`.`killed_by` = "Test2"
            AND `player_deaths`.`unjustified` = 1

SixNine · Apr 25, 2021

slaw said:
Weird, try to paste this into PhpMyAdmin and see if there are any results:

Code:

SELECT COUNT(`player_deaths`.`killed_by`) as frags FROM `player_deaths` WHERE `player_deaths`.`killed_by` = "Test2" AND `player_deaths`.`unjustified` = 1

Hmm still zero. Maybe its issue with overall characters.php and we editing the wrong code part?

<?phpdefined('MYAAC') or die('Direct access not allowed!');$title = 'Charact - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

pastebin.com

Leesne · Apr 25, 2021

SixNine said:
Hmm still zero. Maybe its issue with overall characters.php and we editing the wrong code part?

<?phpdefined('MYAAC') or die('Direct access not allowed!');$title = 'Charact - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

pastebin.com

If its zero in phpmyadmin its not the code being edited on the page.
What results does phpmyadmin give when you type that into the SQL query builder.

I just tested this and it sees the 3 frags the tests i made has.
Post an image of the structure and the data tab with all columns for the deaths in question.

SixNine · Apr 25, 2021

Leesne said:
If its zero in phpmyadmin its not the code being edited on the page.
What results does phpmyadmin give when you type that into the SQL query builder.

I just tested this and it sees the 3 frags the tests i made has.
Post an image of the structure and the data tab with all columns for the deaths in question.

Its not zero

https://i.gyazo.com/28ad0a369b9c1ceeb4d6622c9d90e6ef.png

https://i.gyazo.com/d6584710f6909f7f358e374e74134e77.png

Leesne · Apr 25, 2021

Where are you looking at the frags?

$frags_count and $frags are two separate functions in characters page

SixNine · Apr 25, 2021

Leesne said:
Where are you looking at the frags?

$frags_count and $frags are two separate functions in characters page

Im looking at the frags in player_deaths

Leesne · Apr 25, 2021

I mean on the characters twig page.

Are you using $frags or $frags_count

SixNine · Apr 25, 2021

Leesne said:
I mean on the characters twig page.

Are you using $frags or $frags_count

It uses non because trough sublime it found only used in characters.php in entire system folder

MyACC characters how to show kills

Active Member

Active Member

Software Developer

Active Member

Software Developer

Active Member

Software Developer

Active Member

Software Developer

Active Member

Software Developer

Active Member

Software Developer

Active Member

i r peekay

Active Member

i r peekay

Active Member

i r peekay

Active Member

Similar threads